1. 03 Mar, 2017 1 commit
  2. 08 Feb, 2017 22 commits
  3. 07 Feb, 2017 2 commits
  4. 03 Feb, 2017 15 commits
    • Tuukka Toivonen's avatar
      [media] v4l2-async: failing functions shouldn't have side effects · 47b037a0
      Tuukka Toivonen authored
      v4l2-async had several functions doing some operations and then
      not undoing the operations in a failure situation. For example,
      v4l2_async_test_notify() moved a subdev into notifier's done list
      even if registering the subdev (v4l2_device_register_subdev) failed.
      If the subdev was allocated and v4l2_async_register_subdev() called
      from the driver's probe() function, as usually, the probe()
      function freed the allocated subdev and returned a failure.
      Nevertheless, the subdev was still left into the notifier's done
      list, causing an access to already freed memory when the notifier
      was later unregistered.
      
      A hand-edited call trace leaving freed subdevs into the notifier:
      
      v4l2_async_register_notifier(notifier, asd)
      cameradrv_probe
       sd = devm_kzalloc()
       v4l2_async_register_subdev(sd)
        v4l2_async_test_notify(notifier, sd, asd)
         list_move(sd, &notifier->done)
         v4l2_device_register_subdev(notifier->v4l2_dev, sd)
          cameradrv_registered(sd) -> fails
      ->v4l2_async_register_subdev returns failure
      ->cameradrv_probe returns failure
      ->devres frees the allocated sd
      ->sd was freed but it still remains in the notifier's list.
      
      This patch fixes this and several other cases where a failing
      function could leave nodes into a linked list while the caller
      might free the node due to a failure.
      Signed-off-by: default avatarTuukka Toivonen <tuukka.toivonen@intel.com>
      Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      47b037a0
    • Dan Carpenter's avatar
      [media] mantis_dvb: fix some error codes in mantis_dvb_init() · 79a2eda8
      Dan Carpenter authored
      We should be returning negative error codes here or it leads to a crash.
      This also silences a static checker warning.
      
      	drivers/media/pci/mantis/mantis_cards.c:250 mantis_pci_probe()
      	warn: 'mantis->dmxdev.dvbdev->fops' double freed
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      79a2eda8
    • Javier Martinez Canillas's avatar
      [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT · c2987aaf
      Javier Martinez Canillas authored
      There isn't an ioctl to enum the supported field orders, so a user-space
      application can call VIDIOC_TRY_FMT using different field orders to know
      if one is supported. For example, GStreamer does this so during playback
      dozens of the following messages appear in the kernel log buffer:
      
      [ 442.143393] Not supported field order(4)
      
      Instead of printing this as an error, just keep it as debug information.
      Signed-off-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      c2987aaf
    • Mauro Carvalho Chehab's avatar
      [media] dvb-usb: don't use stack for firmware load · 43fab979
      Mauro Carvalho Chehab authored
      As reported by Marc Duponcheel <marc@offline.be>, firmware load on
      dvb-usb is using the stack, with is not allowed anymore on default
      Kernel configurations:
      
      [ 1025.958836] dvb-usb: found a 'WideView WT-220U PenType Receiver (based on ZL353)' in cold state, will try to load a firmware
      [ 1025.958853] dvb-usb: downloading firmware from file 'dvb-usb-wt220u-zl0353-01.fw'
      [ 1025.958855] dvb-usb: could not stop the USB controller CPU.
      [ 1025.958856] dvb-usb: error while transferring firmware (transferred size: -11, block size: 3)
      [ 1025.958856] dvb-usb: firmware download failed at 8 with -22
      [ 1025.958867] usbcore: registered new interface driver dvb_usb_dtt200u
      
      [    2.789902] dvb-usb: downloading firmware from file 'dvb-usb-wt220u-zl0353-01.fw'
      [    2.789905] ------------[ cut here ]------------
      [    2.789911] WARNING: CPU: 3 PID: 2196 at drivers/usb/core/hcd.c:1584 usb_hcd_map_urb_for_dma+0x430/0x560 [usbcore]
      [    2.789912] transfer buffer not dma capable
      [    2.789912] Modules linked in: btusb dvb_usb_dtt200u(+) dvb_usb_af9035(+) btrtl btbcm dvb_usb dvb_usb_v2 btintel dvb_core bluetooth rc_core rfkill x86_pkg_temp_thermal intel_powerclamp coretemp crc32_pclmul aesni_intel aes_x86_64 glue_helper lrw gf128mul ablk_helper cryptd drm_kms_helper syscopyarea sysfillrect pcspkr i2c_i801 sysimgblt fb_sys_fops drm i2c_smbus i2c_core r8169 lpc_ich mfd_core mii thermal fan rtc_cmos video button acpi_cpufreq processor snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core snd_pcm snd_timer snd crc32c_intel ahci libahci libata xhci_pci ehci_pci xhci_hcd ehci_hcd usbcore usb_common dm_mirror dm_region_hash dm_log dm_mod
      [    2.789936] CPU: 3 PID: 2196 Comm: systemd-udevd Not tainted 4.9.0-gentoo #1
      [    2.789937] Hardware name: ASUS All Series/H81I-PLUS, BIOS 0401 07/23/2013
      [    2.789938]  ffffc9000339b690 ffffffff812bd397 ffffc9000339b6e0 0000000000000000
      [    2.789939]  ffffc9000339b6d0 ffffffff81055c86 000006300339b6a0 ffff880116c0c000
      [    2.789941]  0000000000000000 0000000000000000 0000000000000001 ffff880116c08000
      [    2.789942] Call Trace:
      [    2.789945]  [<ffffffff812bd397>] dump_stack+0x4d/0x66
      [    2.789947]  [<ffffffff81055c86>] __warn+0xc6/0xe0
      [    2.789948]  [<ffffffff81055cea>] warn_slowpath_fmt+0x4a/0x50
      [    2.789952]  [<ffffffffa006d460>] usb_hcd_map_urb_for_dma+0x430/0x560 [usbcore]
      [    2.789954]  [<ffffffff814ed5a8>] ? io_schedule_timeout+0xd8/0x110
      [    2.789956]  [<ffffffffa006e09c>] usb_hcd_submit_urb+0x9c/0x980 [usbcore]
      [    2.789958]  [<ffffffff812d0ebf>] ? copy_page_to_iter+0x14f/0x2b0
      [    2.789960]  [<ffffffff81126818>] ? pagecache_get_page+0x28/0x240
      [    2.789962]  [<ffffffff8118c2a0>] ? touch_atime+0x20/0xa0
      [    2.789964]  [<ffffffffa006f7c4>] usb_submit_urb+0x2c4/0x520 [usbcore]
      [    2.789967]  [<ffffffffa006feca>] usb_start_wait_urb+0x5a/0xe0 [usbcore]
      [    2.789969]  [<ffffffffa007000c>] usb_control_msg+0xbc/0xf0 [usbcore]
      [    2.789970]  [<ffffffffa067903d>] usb_cypress_writemem+0x3d/0x40 [dvb_usb]
      [    2.789972]  [<ffffffffa06791cf>] usb_cypress_load_firmware+0x4f/0x130 [dvb_usb]
      [    2.789973]  [<ffffffff8109dbbe>] ? console_unlock+0x2fe/0x5d0
      [    2.789974]  [<ffffffff8109e10c>] ? vprintk_emit+0x27c/0x410
      [    2.789975]  [<ffffffff8109e40a>] ? vprintk_default+0x1a/0x20
      [    2.789976]  [<ffffffff81124d76>] ? printk+0x43/0x4b
      [    2.789977]  [<ffffffffa0679310>] dvb_usb_download_firmware+0x60/0xd0 [dvb_usb]
      [    2.789979]  [<ffffffffa0679898>] dvb_usb_device_init+0x3d8/0x610 [dvb_usb]
      [    2.789981]  [<ffffffffa069e302>] dtt200u_usb_probe+0x92/0xd0 [dvb_usb_dtt200u]
      [    2.789984]  [<ffffffffa007420c>] usb_probe_interface+0xfc/0x270 [usbcore]
      [    2.789985]  [<ffffffff8138bf95>] driver_probe_device+0x215/0x2d0
      [    2.789986]  [<ffffffff8138c0e6>] __driver_attach+0x96/0xa0
      [    2.789987]  [<ffffffff8138c050>] ? driver_probe_device+0x2d0/0x2d0
      [    2.789988]  [<ffffffff81389ffb>] bus_for_each_dev+0x5b/0x90
      [    2.789989]  [<ffffffff8138b7b9>] driver_attach+0x19/0x20
      [    2.789990]  [<ffffffff8138b33c>] bus_add_driver+0x11c/0x220
      [    2.789991]  [<ffffffff8138c91b>] driver_register+0x5b/0xd0
      [    2.789994]  [<ffffffffa0072f6c>] usb_register_driver+0x7c/0x130 [usbcore]
      [    2.789994]  [<ffffffffa06a5000>] ? 0xffffffffa06a5000
      [    2.789996]  [<ffffffffa06a501e>] dtt200u_usb_driver_init+0x1e/0x20 [dvb_usb_dtt200u]
      [    2.789997]  [<ffffffff81000408>] do_one_initcall+0x38/0x140
      [    2.789998]  [<ffffffff8116001c>] ? __vunmap+0x7c/0xc0
      [    2.789999]  [<ffffffff81124fb0>] ? do_init_module+0x22/0x1d2
      [    2.790000]  [<ffffffff81124fe8>] do_init_module+0x5a/0x1d2
      [    2.790002]  [<ffffffff810c96b1>] load_module+0x1e11/0x2580
      [    2.790003]  [<ffffffff810c68b0>] ? show_taint+0x30/0x30
      [    2.790004]  [<ffffffff81177250>] ? kernel_read_file+0x100/0x190
      [    2.790005]  [<ffffffff810c9ffa>] SyS_finit_module+0xba/0xc0
      [    2.790007]  [<ffffffff814f13e0>] entry_SYSCALL_64_fastpath+0x13/0x94
      [    2.790008] ---[ end trace c78a74e78baec6fc ]---
      
      So, allocate the structure dynamically.
      
      Cc: stable@vger.kernel.org # Kernel 4.9+
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      43fab979
    • Christophe JAILLET's avatar
      [media] exynos4-is: Add missing 'of_node_put' · 2b2d1d40
      Christophe JAILLET authored
      It is likely that a "of_node_put(ep)" is missing here.
      There is one in the previous error handling code, and one a few lines
      below in the normal case as well.
      Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      2b2d1d40
    • Bhumika Goyal's avatar
      [media] media: dvb-frontends: constify vb2_ops structure · dd93e79c
      Bhumika Goyal authored
      Declare vb2_ops structure as const as it is only stored in
      the ops field of a vb2_queue structure. This field is of type
      const, so vb2_ops structures having same properties can be made
      const too.
      Done using Coccinelle:
      
      @r1 disable optional_qualifier@
      identifier i;
      position p;
      @@
      static struct vb2_ops i@p={...};
      
      @ok1@
      identifier r1.i;
      position p;
      struct sta2x11_vip vip;
      struct vb2_queue q;
      @@
      (
      vip.vb_vidq.ops=&i@p
      |
      q.ops=&i@p
      )
      
      @bad@
      position p!={r1.p,ok1.p};
      identifier r1.i;
      @@
      i@p
      
      @depends on !bad disable optional_qualifier@
      identifier r1.i;
      @@
      +const
      struct vb2_ops i;
      
      File size details of media/dvb-frontends/rtl2832_sdr.o file remains the
      same before and after applying the patch.
      Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      dd93e79c
    • Bhumika Goyal's avatar
      [media] media: pci: constify vb2_ops structure · 8b6fe20a
      Bhumika Goyal authored
      Declare vb2_ops structure as const as it is only stored in
      the ops field of a vb2_queue structure. This field is of type
      const, so vb2_ops structures having same properties can be made
      const too.
      Done using Coccinelle:
      
      @r1 disable optional_qualifier@
      identifier i;
      position p;
      @@
      static struct vb2_ops i@p={...};
      
      @ok1@
      identifier r1.i;
      position p;
      struct sta2x11_vip vip;
      struct vb2_queue q;
      @@
      (
      vip.vb_vidq.ops=&i@p
      |
      q.ops=&i@p
      )
      
      @bad@
      position p!={r1.p,ok1.p};
      identifier r1.i;
      @@
      i@p
      
      @depends on !bad disable optional_qualifier@
      identifier r1.i;
      @@
      +const
      struct vb2_ops i;
      
      File size before:
         text	   data	    bss	    dec	    hex	filename
         8448	    440	      0	   8888	   22b8	media/pci/sta2x11/sta2x11_vip.o
      
      File size after:
         text	   data	    bss	    dec	    hex	filename
         8552	    352	      0	   8904	   22c8	media/pci/sta2x11/sta2x11_vip.o
      Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      8b6fe20a
    • Laurent Pinchart's avatar
      [media] v4l: subdev: Clean up properly in subdev devnode registration error path · 909aa003
      Laurent Pinchart authored
      Set the subdev devnode pointer right after registration to ensure that
      later errors won't skip the subdev when unregistering all devnodes.
      Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      909aa003
    • Baruch Siach's avatar
      [media] coda: add Freescale firmware compatibility location · 8af7779f
      Baruch Siach authored
      The Freescale provided imx-vpu looks for firmware files under /lib/firmware/vpu
      by default. Make coda look there for firmware files to ease the update path.
      
      Cc: Fabio Estevam <festevam@gmail.com>
      Signed-off-by: default avatarBaruch Siach <baruch@tkos.co.il>
      Reviewed-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      8af7779f
    • Sean Young's avatar
      [media] mce_kbd: add missing keys from UK layout · 44750606
      Sean Young authored
      The UK layout of the Microsoft Remote Keyboard has two missing keys:
      the hash key, and the messenger key which is sent using rc6 mce.
      Signed-off-by: default avatarSean Young <sean@mess.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      44750606
    • Sean Young's avatar
      [media] lirc: cannot read from tx-only device · 32002f72
      Sean Young authored
      Bail out early, otherwise we follow a null pointer.
      Signed-off-by: default avatarSean Young <sean@mess.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      32002f72
    • Martin Blumenstingl's avatar
      7a6628b5
    • Martin Blumenstingl's avatar
      [media] Documentation: devicetree: meson-ir: "linux,rc-map-name" is supported · 031d3e18
      Martin Blumenstingl authored
      The driver already parses the "linux,rc-map-name" property. Add this
      information to the documentation so .dts maintainers don't have to look
      it up in the source-code.
      Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
      Acked-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarSean Young <sean@mess.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      031d3e18
    • Wei Yongjun's avatar
      [media] gp8psk: make local symbol gp8psk_fe_ops static · d46e0a8b
      Wei Yongjun authored
      Fixes the following sparse warning:
      
      drivers/media/usb/dvb-usb/gp8psk.c:281:28: warning:
       symbol 'gp8psk_fe_ops' was not declared. Should it be static?
      Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d46e0a8b
    • Wei Yongjun's avatar
      [media] tm6000: fix typo in parameter description · 634b2b5c
      Wei Yongjun authored
      Fix typo in parameter description.
      Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      634b2b5c