- 09 Jun, 2023 39 commits
-
-
Zhangjin Wu authored
The ppoll and ppoll_time64 syscalls have 5 arguments, but we only provide 4, align with kernel and add the missing sigsetsize argument. Because the sigmask is NULL, the last sigsetsize argument is ignored, keep it as 0 here is safe enough. Signed-off-by:
Zhangjin Wu <falcon@tinylab.org> Signed-off-by:
Willy Tarreau <w@1wt.eu> Signed-off-by:
Paul E. McKenney <paulmck@kernel.org>
-
Zhangjin Wu authored
There were two exactly similar occurrences of this test. Signed-off-by:
-
Zhangjin Wu authored
EOVERFLOW will be used in the coming time64 syscalls support. Signed-off-by:
Thomas Weißschuh <linux@weissschuh.net> Signed-off-by:
-
Thomas Weißschuh authored
Keep backwards compatibility through unions. The compatibility macros like #define st_atime st_atim.tv_sec as documented in stat(3type) don't work for nolibc because it would break with other stat-like structures that contain the field st_atime. The stx_atime, stx_mtime, stx_ctime are in type of 'struct statx_timestamp', which is incompatible with 'struct timespec', should be converted explicitly. /* include/uapi/linux/stat.h */ struct statx_timestamp { __s64 tv_sec; __u32 tv_nsec; __s32 __reserved; }; /* include/uapi/linux/time.h */ struct timespec { __kernel_old_time_t tv_sec; /* seconds */ long tv_nsec; /* nanoseconds */ }; Signed-off-by: -
Thomas Weißschuh authored
The child process forked during stackprotector tests intentionally gets killed with SIGABRT. By default this will trigger writing a coredump. The writing of the coredump can spam the systems coredump machinery and take some time. Timings for the full run of nolibc-test: Before: 200ms After: 20ms This is on a desktop x86 system with systemd-coredumpd enabled. Signed-off-by:
-
Thomas Weißschuh authored
It will be used to disable core dumps from the child spawned to validate the stack protector functionality. Signed-off-by:
-
Thomas Weißschuh authored
s390 does not support the "global" stack protector mode that is implemented in nolibc. Now that nolibc detects if stack protectors are enabled at runtime it could happen that a future compiler does indeed use global mode on and nolibc would compile but segfault at runtime. To avoid this hypothetic case and to align s390 with the other architectures disable stack protectors when compiling _start(). Signed-off-by:
-
Thomas Weißschuh authored
Not all compilers, notably GCC < 10, have support for __attribute__((no_stack_protector)). Fall back to a mechanism that also works there. Tested with GCC 9.5.0 from kernel.org crosstools. Signed-off-by:
-
Thomas Weißschuh authored
Now that nolibc enable stackprotector support automatically when the compiler enables it we only have to get the -fstack-protector flags correct. The cc-options are structured so that -fstack-protector-all is only enabled if -mstack-protector=guard works, as that is the only mode supported by nolibc. Signed-off-by:
-
Thomas Weißschuh authored
The stackprotector support in nolibc should be enabled iff it is also enabled in the compiler. Use the preprocessor defines added by gcc and clang if stackprotector support is enable to automatically do so in nolibc. This completely removes the need for any user-visible API. To avoid inlining the lengthy preprocessor check into every user introduce a new header compiler.h that abstracts the logic away. As the define NOLIBC_STACKPROTECTOR is now not user-relevant anymore prefix it with an underscore. Suggested-by:
-
Thomas Weißschuh authored
This makes it easier to add and remove more entries in the future without creating spurious diff hunks. Signed-off-by:
-
Thomas Weißschuh authored
Signed-off-by:
-
Thomas Weißschuh authored
The all-zero pattern is one of the more probable out-of-bound writes so add a special case to not accidentally accept it. Also it enables the reliable detection of stack protector initialization during testing. Signed-off-by:
-
Thomas Weißschuh authored
This was forgotten in the original submission. It is unknown why it worked for x86_64 on some compiler without this attribute. Reported-by:
-
Thomas Weißschuh authored
Signed-off-by:
-
Thomas Weißschuh authored
Signed-off-by:
Palmer Dabbelt <palmer@rivosinc.com> Signed-off-by:
-
Thomas Weißschuh authored
Signed-off-by:
-
Thomas Weißschuh authored
Signed-off-by:
-
Thomas Weißschuh authored
Signed-off-by:
-
Thomas Weißschuh authored
Signed-off-by:
-
Thomas Weißschuh authored
Previously each space character used for alignment during test execution was written in a single write() call. This would make the output from strace fairly unreadable. Coalesce all spaces into a single call to write(). Signed-off-by:
-
Zhangjin Wu authored
Compiling nolibc-test.c for rv32 got such error: tools/testing/selftests/nolibc/nolibc-test.c:599:57: error: ‘__NR_fstat’ undeclared (first use in this function) 599 | CASE_TEST(syscall_args); EXPECT_SYSER(1, syscall(__NR_fstat, 0, NULL), -1, EFAULT); break; The generic include/uapi/asm-generic/unistd.h used by rv32 doesn't support __NR_fstat, use the more generic __NR_statx instead: Running test 'syscall' 69 syscall_noargs = 1 [OK] 70 syscall_args = -1 EFAULT [OK] __NR_statx has been added from v4.10: commit a528d35e ("statx: Add a system call to make enhanced file info available") It has been supported by all of the platforms since at least from v4.20. Suggested-by:Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/linux-riscv/ee8b1f02-ded1-488b-a3a5-68774f0349b5@app.fastmail.com/Signed-off-by:
-
Thomas Weißschuh authored
syscall() is used by "normal" libcs to allow users to directly call syscalls. By having the same syntax inside nolibc users can more easily write code that works with different libcs. The macro logic is adapted from systemtaps STAP_PROBEV() macro that is released in the public domain / CC0. Signed-off-by:
-
Zhangjin Wu authored
When compile nolibc application for rv32, we got such errors: nolibc/sysroot/riscv/include/arch.h:190: Error: unrecognized opcode `ld a4,0(a3)' nolibc/sysroot/riscv/include/arch.h:194: Error: unrecognized opcode `sd a3,%lo(_auxv)(a4)' nolibc/sysroot/riscv/include/arch.h:196: Error: unrecognized opcode `sd a2,%lo(environ)(a3)' Refer to arch/riscv/include/asm/asm.h and add REG_L/REG_S macros here to let rv32 uses its own lw/sw instructions. Signed-off-by:
-
Thomas Weißschuh authored
The same constants and some more have been exposed to userspace via linux/reboot.h for a long time. To avoid conflicts and trim down nolibc a bit drop the custom definitions. Signed-off-by:
-
Thomas Weißschuh authored
On s390 the arguments to clone() which is used by fork() are different than other archs. Make sure everything works correctly. Signed-off-by:
-
Thomas Weißschuh authored
On s390 the first two arguments to the clone() syscall are swapped, as documented in clone(2). Signed-off-by:
-
Thomas Weißschuh authored
To make sure no non-compatible changes are introduced accidentally validate the language standard when building the tests. Signed-off-by:
-
Thomas Weißschuh authored
Most of nolibc is already using C89 comments. Signed-off-by:
-
Thomas Weißschuh authored
When building in strict C89 mode the "inline" keyword is unknown. While "__inline__" is non-standard it is used by the kernel headers themselves. So the used compilers would have to support it or the users shim it with a #define. Signed-off-by:
-
Thomas Weißschuh authored
Most of the code was migrated to C99-conformant __asm__ statements before. It seems string.h was missed. Signed-off-by:
-
Mark Brown authored
When we added fd based file streams we created references to STx_FILENO in stdio.h but these constants are declared in unistd.h which is the last file included by the top level nolibc.h meaning those constants are not defined when we try to build stdio.h. This causes programs using nolibc.h to fail to build. Reorder the headers to avoid this issue. Fixes: d449546c957f ("tools/nolibc: implement fd-based FILE streams") Signed-off-by:Mark Brown <broonie@kernel.org> Signed-off-by:
-
Thomas Weißschuh authored
vfprintf() is complex and so far did not have proper tests. Signed-off-by:
-
Thomas Weißschuh authored
This enables the usage of the stream APIs with arbitrary filedescriptors. It will be used by a future testcase. Signed-off-by:
-
Thomas Weißschuh authored
This is useful for users and will also be used by a future testcase. Signed-off-by:
-
Thomas Weißschuh authored
This can be used to easily compare the behavior of nolibc to the system libc. Signed-off-by:
-
Willy Tarreau authored
Some extra tests for various integer types and limits were added by commit d1209597 ("tools/nolibc: add tests for the integer limits in stdint.h"), but we forgot to retest with glibc. Stddef and stdint are now needed for the program to build there. Cc: Vincent Dagonneau <v@vda.io> Signed-off-by:
-
Willy Tarreau authored
Commit 97357168 ("tools/nolibc: tests: add test for -fstack-protector") brought a declaration inside the initialization statement of a for loop, which breaks the build on compilers that do not default to c99 compatibility, making it more difficult to validate that the lib still builds on such compilers. The fix is trivial, so let's move the declaration to the variables block of the function instead. No backport is needed. Cc: Thomas Weißschuh <linux@weissschuh.net> Signed-off-by:
-
Thomas Weißschuh authored
Use a volatile pointer to write outside the buffer so the compiler can't optimize it away. Reported-by:
Alexey Dobriyan <adobriyan@gmail.com> Link: https://lore.kernel.org/lkml/c0584807-511c-4496-b062-1263ea38f349@p183/Signed-off-by:
-
- 07 May, 2023 1 commit
-
-
Linus Torvalds authored
-
