1. 06 Nov, 2009 1 commit
    • David S. Miller's avatar
      Revert "ide: try to use PIO Mode 0 during probe if possible" · 0fb18c47
      David S. Miller authored
      This reverts commit 60293364.
      
      Ok, we really do need to revert this, even with Bart's sis5513.c
      fix in there.
      
      The problem is that several driver's ->set_pio_mode() method
      depends upon the drive->media type being set properly.  Most
      of them use this to enable prefetching, which can only be done
      for disk media.
      
      But the commit being reverted here calls ->set_pio_mode() before
      it's setup.  Actually it considers everything disk because that
      is the default media type set by ide_port_init_devices_data().
      
      The set of drivers that depend upon the media type in their
      ->set_pio_method() are:
      
      drivers/ide/alim15x3.c
      drivers/ide/it8172.c
      drivers/ide/it8213.c
      drivers/ide/pdc202xx_old.c
      drivers/ide/piix.c
      drivers/ide/qd65xx.c
      drivers/ide/sis5513.c
      drivers/ide/slc90e66.c
      
      And it is possible that we could fix this by guarding the prefetching
      and other media dependent setting changes with a test on
      IDE_PFLAG_PROBING in hwif->port_flags, that's simply too risky for
      2.6.32-rcX and -stable.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0fb18c47
  2. 29 Oct, 2009 1 commit
    • Mikulas Patocka's avatar
      ide: Serialize CMD643 and CMD646 to fix a hardware bug with SSD · 9bd7496f
      Mikulas Patocka authored
      CMD646 corrupts data on concurrent transfers on both channels when IDE SSD is
      connected to one of the channels.
      
      Setup that demonstrates this hardware bug: Ultra 5, onboard CMD646, rev 3.
      /dev/hda is 8GB Seagate ST38410A in MWDMA2
      /dev/hdd is 32GB SSD SiliconHardDisk in MWDMA2
      
      - When reading /dev/hdd (for example with dd or fsck), reads from /dev/hda
        are corrupted, there are twiddled single bits 1->0 and some full 32-bit
        words corrupted, sometimes commands fail (which switches /dev/hda to
        PIO mode but the corruptions happen even in PIO).
      - Reads from /dev/hdd don't seem to be corrupted (i.e. fsck passes fine).
      - When I connected normal rotating harddisk to /dev/hdd, there was no
        corruption, so the corruption is something specific to SSD.
      - I tried the same setup on a PCI card with CMD649 and saw no corruption.
      
      This patch serializes the operation for CMD646 and 643 (I didn't test
      CMD643 but it may have the same hw bug too because it's earlier design).
      CMD649 is good. I don't know anything about CMD 648.
      Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
      Tested-by: default avatarFrans Pop <elendil@planet.nl>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9bd7496f
  3. 07 Oct, 2009 2 commits
  4. 05 Oct, 2009 1 commit
  5. 22 Sep, 2009 35 commits