Skip to content

L
linux
Switch branch/tag
  1. 29 Nov, 2016 8 commits
    • Brian Norris's avatar
      mwifiex: pcie: implement timeout loop for FW programming doorbell · 22dde1ed
      Brian Norris authored 
      Marvell Wifi PCIe modules don't always behave nicely for PCIe power
management when their firmware hasn't been loaded, particularly after
suspending the PCIe link one or more times. When this happens, we might
end up spinning forever in this status-polling tight loop. Let's make
this less tight by adding a timeout and by sleeping a bit in between
reads, as we do with the other similar loops.

This prevents us from hogging a CPU even in such pathological cases, and
allows the FW initialization to just fail gracefully instead.

I chose the same polling parameters as the earlier loop in this
function, and empirically, I found that this loop never makes it more
than about 12 cycles in a sane FW init sequence. I had no official
information on the actual intended latency for this portion of the
download.
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Acked-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      22dde1ed
    • Kirtika Ruchandani's avatar
      mwifiex: Remove unused 'bcd_usb' variable · 4133828c
      Kirtika Ruchandani authored 
      mwifiex_usb_probe() defines and sets bcd_usb but does not use it,
Compiling with W=1 gives the following warning, fix it.
mwifiex/usb.c: In function ‘mwifiex_usb_probe’:
mwifiex/usb.c:383:41: warning: variable ‘bcd_usb’ set but not used [-Wunused-but-set-variable]

The unused variable seems to be present since 4daffe35 which introduced
mwifiex_usb_probe().

Fixes: 4daffe35 ("mwifiex: add support for Marvell USB8797 chipset")
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKirtika Ruchandani <kirtika@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      4133828c
    • Kirtika Ruchandani's avatar
      mwifiex: Removed unused 'pkt_type' variable · 67dd2a75
      Kirtika Ruchandani authored 
      Commit 92263a84 introduced mwifiex_deaggr_sdio_pkt which initializes
variable pkt_type but does not use it. Compiling with W=1 gives the following
warning, fix it.
mwifiex/sdio.c: In function ‘mwifiex_deaggr_sdio_pkt’:
mwifiex/sdio.c:1198:6: warning: variable ‘pkt_type’ set but not used [-Wunused-but-set-variable]

Fixes: 92263a84 ("mwifiex: add SDIO rx single port aggregation")
Cc: Zhaoyang Liu <liuzy@marvell.com>
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKirtika Ruchandani <kirtika@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      67dd2a75
    • Kirtika Ruchandani's avatar
      mwifiex: Remove unused 'pm_flag' variable · e9f1db8b
      Kirtika Ruchandani authored 
      mwifiex_sdio_resume() intializes pm_flag, just like
mwifiex_sdio_suspend(), but does not use it. Compiling with W=1 gives
the following warning, fix it.
mwifiex/sdio.c: In function ‘mwifiex_sdio_resume’:
mwifiex/sdio.c:234:16: warning: variable ‘pm_flag’ set but not used [-Wunused-but-set-variable]

sdio_get_host_pm_caps() is just an acessor, so the call to it is safe
to remove. The unused variable seems to be present since
5e6e3a92 which introduced mwifiex_sdio_resume().

Fixes: 5e6e3a92 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
Cc: Bing Zhao <bzhao@marvell.com>
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKirtika Ruchandani <kirtika@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      e9f1db8b
    • Kirtika Ruchandani's avatar
      mwifiex: Remove unused 'adapter'variable · 60261b26
      Kirtika Ruchandani authored 
      Commit 3935ccc1 introduced mwifiex_tm_cmd() which initializes
struct mwifiex_adapter* adapter, but doesn't use it.
Compiling with W=1 gives the following warning, fix it.
mwifiex/cfg80211.c: In function ‘mwifiex_tm_cmd’:
mwifiex/cfg80211.c:3973:26: warning: variable ‘adapter’ set but not used [-Wunused-but-set-variable]

Fixes: 3935ccc1 ("mwifiex: add cfg80211 testmode support")
Cc: Xinming Hu <huxm@marvell.com>
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKirtika Ruchandani <kirtika@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      60261b26
    • Kirtika Ruchandani's avatar
      mwifiex: Remove unused 'sta_ptr' variable · 2c2bcabf
      Kirtika Ruchandani authored 
      Commit 429d90d2 introduced mwifiex_cmd_tdls_oper() which initializes
struct mwifiex_sta_node* sta_ptr, but does not use it. Compiling with W=1 gives
the following warning, fix it.
mwifiex/sta_cmd.c: In function ‘mwifiex_cmd_tdls_oper’:
mwifiex/sta_cmd.c:1732:27: warning: variable ‘sta_ptr’ set but not used [-Wunused-but-set-variable]

Fixes: 429d90d2 ("mwifiex: add cfg80211 tdls_oper handler support")
Cc: Avinash Patil <patila@marvell.com>
Signed-off-by: default avatarKirtika Ruchandani <kirtika@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      2c2bcabf
    • Kirtika Ruchandani's avatar
      mwifiex: Remove unused 'chan_num' variable · 8ac91341
      Kirtika Ruchandani authored 
      Commit b5413e6b removed all uses of chan_num in mwifiex_config_scan().
Compiling mwifiex with W=1 gives the following warning, fix it.

mwifiex/scan.c: In function ‘mwifiex_config_scan’:
mwifiex/scan.c:830:6: warning: variable ‘chan_num’ set but not used [-Wunused-but-set-variable]

Fixes: b5413e6b ("mwifiex: increase the number of nodes in command pool")
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKirtika Ruchandani <kirtika@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      8ac91341
    • Kirtika Ruchandani's avatar
      mwifiex: Removed unused mwifiex_private* 'priv' variable · 70d74059
      Kirtika Ruchandani authored 
      Commit bec568ff removed the last remaining usage of struct
mwifiex_private* priv in mwifiex_fw_dpc(), by removing the call to
mwifiex_del_virtual_intf().
Compiling mwifiex/ with W=1 gives the following warning, fix it.
mwifiex/main.c: In function ‘mwifiex_fw_dpc’:
mwifiex/main.c:520:26: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]

Fixes: bec568ff ("mwifiex: failure path handling in mwifiex_add_virtual_intf()")
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKirtika Ruchandani <kirtika@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      70d74059
  3. 28 Nov, 2016 1 commit
  5. 25 Nov, 2016 15 commits
  7. 23 Nov, 2016 12 commits
  9. 19 Nov, 2016 4 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7