- 24 Jun, 2021 33 commits
-
-
Fabio Aiuto authored
remove all code branchings tied to dual band support. The device works only on 2.4Ghz band so there's no need to check which band we are on. Removed all code branches that would be valid only for 5Ghz for it's dead code. Removed enums, table fields indexing by band type, function arguments passing current band type and all other thing related to telling us which band we are on. Acked-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Fabio Aiuto <fabioaiuto83@gmail.com> Link: https://lore.kernel.org/r/72bb27f6a7b3be607f93f5b406d863dd08376986.1624367071.git.fabioaiuto83@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Fabio Aiuto authored
remove struct rt_channel_plan_5g, for rtl8723bs works only on 2.4Ghz band. Acked-by:
-
Fabio Aiuto authored
remove unused 5Ghz field in struct registry_priv. Acked-by:
-
Fabio Aiuto authored
since rtl8723bs card allows only 20Mhz and 40Mhz channels, rename enum items related to channel bonding accordingly to the only composite channel bandwidth allowed in 2.4Ghz (i.e. 40Mhz) in a HT context (since VHT isn't supported) Example: VHT_DATA_SC_20_LOWER_OF_80MHZ -> HT_DATA_SC_LOWER_OF_40MHZ Acked-by:
-
Fabio Aiuto authored
remove unused enum items related to channel bonding. Acked-by:
-
Fabio Aiuto authored
remove all code related to unsupported channel bandwidth (i.e. 80, 80+80, 160 Mhz). rtl8723bs NIC works only on 20 and 40 Mhz channels. Module parameter rtw_bw_mode can only have two values: 0 and 1 (20 Mhz and 40Mhz). So modify the default value setting to zero the 5Ghz nibble. Comments modified accordingly. Acked-by:
-
Fabio Aiuto authored
remove all 5Ghz network types. rtl8723bs works on 802.11bgn standards and on 2.4Ghz band. So remove all code related to 802.11a and 802.11ac standards, which the device doesn't support. Acked-by:
-
Phillip Potter authored
Remove definition of MSG_88E macro from include/rtw_debug.h, as it no longer has any callers and does not follow kernel coding conventions. Removing this macro leaves only RT_TRACE and associated definitions. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20210623234902.7411-10-phil@philpotter.co.ukSigned-off-by:
-
Phillip Potter authored
Remove MSG_88E call from hal/odm.c as this macro is unnecessary, and this call is dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove definition of DBG_88E_LEVEL macro from include/rtw_debug.h, as it no longer has any callers and does not follow kernel coding conventions. Removing all such macros will ultimately allow the removal of this file. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E_LEVEL calls from core/rtw_xmit.c as this macro is unnecessary, and these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E_LEVEL calls from core/rtw_pwrctrl.c as this macro is unnecessary, and these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E_LEVEL calls from core/rtw_ioctl_set.c as this macro is unnecessary, and these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E_LEVEL calls from core/rtw_mlmw_ext.c as this macro is unnecessary, and these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Phillip Potter authored
Remove all DBG_88E_LEVEL calls from os_dep/ioctl_linux.c as this macro is unnecessary, and these calls are dubious in terms of necessity. Removing all calls will ultimately allow the removal of the macro itself. Signed-off-by:
-
Martin Kaiser authored
Remove some defines for register addresses and bits which obviously refer to chipsets other than rtl8188eu. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210620175301.14988-13-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
Remove sdio defines which are not used by this driver. Signed-off-by:
-
Martin Kaiser authored
The function is used only inside rtw_efuse.c. Signed-off-by:
-
Martin Kaiser authored
Eventually, all driver-specific debug prints should be removed. Take another step in that direction. Signed-off-by:
-
Martin Kaiser authored
The code looks a bit nicer without goto. Signed-off-by:
-
Martin Kaiser authored
Remove HAL_INIT_PROFILE_TAG, which is an empty loop already. Signed-off-by:
-
Martin Kaiser authored
Eventually, all driver-specific debug prints should be removed. Take another step in that direction. Signed-off-by:
-
Martin Kaiser authored
if and else do the same thing. Signed-off-by:
-
Martin Kaiser authored
A number of efuse-related functions have an "efuse type" parameter. This type is not used and can be removed. Signed-off-by:
-
Martin Kaiser authored
Remove some defines which are not used by this driver. Signed-off-by:
-
Martin Kaiser authored
Eventually, all driver-specific debug prints should be removed. Take another step in that direction. Signed-off-by:
-
Martin Kaiser authored
Eventually, all driver-specific debug prints should be removed. Take another step in that direction. Signed-off-by:
-
Martin Kaiser authored
Fail the usb interface initialization if dev_alloc_name returns an error. Other wlan drivers like natsemi or atmel use the same error handling. Signed-off-by:
-
Martin Kaiser authored
usb_read_port prepares a bulk in urb and calls usb_submit_urb to pass the usb to the usb core. It seems wrong that usb_read_port returns success to its caller if usb_submit_urb failed with -EPERM. According to drivers/usb/core/urb.c, usb_submit_urb returns -EPERM when an urb is resubmitted after being cancelled by usb_kill_urb etc. The only caller who checks the return value of usb_read_port is rtw_hal_inirp_init. This function submits the bulk in urbs for the first time after the netdevice is opened. We'll not receive -EPERM from usb_submit_urb in this case. The urbs are resubmitted by read_port_complete, which does not check for errors from usb_read_port. This driver may kill pending bulk in urbs when the netdevice is closed when the driver is unloaded or the system goes to sleep. I don't think that this will interrupt an ongoing netdev open. Suggested-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Christophe JAILLET authored
This enum is unused. It is also close to "ieee80211_back_parties" in "include/linux/ieee80211.h", which should be used if needed. So remove it Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/f389e0d54a5a8a46c9a696207541aa1cb433676b.1624132543.git.christophe.jaillet@wanadoo.frSigned-off-by:
-
Christophe JAILLET authored
This enum is the same as "ieee80211_back_actioncode" in "include/linux/ieee80211.h". Update the code accordingly and remove useless comment. Signed-off-by:
-
Michael Straube authored
Remove block comment about function HwSuspendModeEnable92Cu. The comment contains no useful information and there is even no HwSuspendModeEnable92Cu function in the driver code. 'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu' returns nothing. Reviewed-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210619175055.5122-1-straube.linux@gmail.comSigned-off-by:
-
Christophe JAILLET authored
'ret' is known to be 0 at this point. It must be set to -ENOMEM if a memory allocation occurs. Fixes: 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by:
-
- 18 Jun, 2021 7 commits
-
-
Shreyas Krishnakumar authored
Remove unnecessary braces around single statement blocks as warned by checkpatch.pl Signed-off-by:
Shreyas Krishnakumar <shreyaskumar1035@gmail.com> Link: https://lore.kernel.org/r/20210616073921.156814-1-shreyaskumar1035@gmail.comSigned-off-by:
-
Yang Yingliang authored
Using eth_broadcast_addr() to assign broadcast address instead of copying from an array that contains the all-ones broadcast address. Signed-off-by:
Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20210616081243.2511663-4-yangyingliang@huawei.comSigned-off-by:
-
Yang Yingliang authored
Using eth_broadcast_addr() to assign broadcast address instead of copying from an array that contains the all-ones broadcast address. Signed-off-by:
-
Yang Yingliang authored
Using eth_broadcast_addr() to assign broadcast address instead of memset() or copying from an array that contains the all-ones broadcast address. Signed-off-by:
-
Qiang Ma authored
Remove the check for _rtw_enqueue_cmd(), because rtw_enqueue_cmd() already has a check of NULL pointer, so this condition is not possible. Signed-off-by:
Qiang Ma <maqianga@uniontech.com> Link: https://lore.kernel.org/r/20210616125332.31674-1-maqianga@uniontech.comSigned-off-by:
-
Caleb D.S. Brzezinski authored
Wrap the definition of TX_RATE_* constants in parenthesis to prevent incorrect casting during expansion, as recommended by checkpatch.pl. Signed-off-by:
Caleb D.S. Brzezinski <calebdsb@protonmail.com> Link: https://lore.kernel.org/r/20210616212552.117604-1-calebdsb@protonmail.comSigned-off-by:
-
Colin Ian King authored
The continue statement at the end of a for-loop has no effect, remove it. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Addresses-Coverity: ("Continue has no effect") Link: https://lore.kernel.org/r/20210617120411.11612-1-colin.king@canonical.comSigned-off-by:
-
