1. 19 Mar, 2021 40 commits
    • Lee Jones's avatar
      scsi: cxlflash: Fix a few misnaming issues · 32b3edfd
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/cxlflash/superpipe.c:38: warning: Function parameter or member 'release' not described in 'marshal_rele_to_resize'
       drivers/scsi/cxlflash/superpipe.c:38: warning: Excess function parameter 'rele' description in 'marshal_rele_to_resize'
       drivers/scsi/cxlflash/superpipe.c:51: warning: Function parameter or member 'release' not described in 'marshal_det_to_rele'
       drivers/scsi/cxlflash/superpipe.c:51: warning: Excess function parameter 'rele' description in 'marshal_det_to_rele'
       drivers/scsi/cxlflash/superpipe.c:528: warning: expecting prototype for rhte_format1(). Prototype was for rht_format1() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-33-lee.jones@linaro.org
      Cc: "Manoj N. Kumar" <manoj@linux.ibm.com>
      Cc: "Matthew R. Ochs" <mrochs@linux.ibm.com>
      Cc: Uma Krishnan <ukrishn@linux.ibm.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      32b3edfd
    • Lee Jones's avatar
      scsi: cxlflash: Fix a little doc-rot · cf0ad7a1
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/cxlflash/main.c:1369: warning: Function parameter or member 'hwq' not described in 'process_hrrq'
       drivers/scsi/cxlflash/main.c:1369: warning: Excess function parameter 'afu' description in 'process_hrrq'
       drivers/scsi/cxlflash/main.c:2005: warning: Function parameter or member 'index' not described in 'init_mc'
       drivers/scsi/cxlflash/main.c:3303: warning: Function parameter or member 'lunprov' not described in 'cxlflash_lun_provision'
       drivers/scsi/cxlflash/main.c:3303: warning: Excess function parameter 'arg' description in 'cxlflash_lun_provision'
       drivers/scsi/cxlflash/main.c:3397: warning: Function parameter or member 'afu_dbg' not described in 'cxlflash_afu_debug'
       drivers/scsi/cxlflash/main.c:3397: warning: Excess function parameter 'arg' description in 'cxlflash_afu_debug'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-32-lee.jones@linaro.org
      Cc: "Manoj N. Kumar" <manoj@linux.ibm.com>
      Cc: "Matthew R. Ochs" <mrochs@linux.ibm.com>
      Cc: Uma Krishnan <ukrishn@linux.ibm.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      cf0ad7a1
    • Lee Jones's avatar
      scsi: isci: remote_node_table: Provide some missing params and remove others · 188f513d
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/remote_node_table.c:113: warning: Function parameter or member 'group_table_index' not described in 'sci_remote_node_table_clear_group_index'
       drivers/scsi/isci/remote_node_table.c:113: warning: Excess function parameter 'set_index' description in 'sci_remote_node_table_clear_group_index'
       drivers/scsi/isci/remote_node_table.c:262: warning: Function parameter or member 'group_index' not described in 'sci_remote_node_table_set_group'
       drivers/scsi/isci/remote_node_table.c:383: warning: Function parameter or member 'group_table_index' not described in 'sci_remote_node_table_allocate_single_remote_node'
       drivers/scsi/isci/remote_node_table.c:383: warning: Excess function parameter 'table_index' description in 'sci_remote_node_table_allocate_single_remote_node'
       drivers/scsi/isci/remote_node_table.c:516: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_single_remote_node'
       drivers/scsi/isci/remote_node_table.c:562: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_triple_remote_node'
       drivers/scsi/isci/remote_node_table.c:588: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_remote_node_index'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-31-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      188f513d
    • Lee Jones's avatar
      scsi: isci: remote_node_context: Demote kernel-doc abuse · d2d480f1
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/remote_node_context.c:206: warning: Function parameter or member 'rnc' not described in 'sci_remote_node_context_notify_user'
       drivers/scsi/isci/remote_node_context.c:206: warning: expecting prototype for This method just calls the user callback function and then resets the(). Prototype was for sci_remote_node_context_notify_user() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-30-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      d2d480f1
    • Lee Jones's avatar
      scsi: isci: port: Fix a bunch of kernel-doc issues · 7292a8b0
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/port.c:130: warning: Function parameter or member 'iport' not described in 'sci_port_get_properties'
       drivers/scsi/isci/port.c:130: warning: Function parameter or member 'prop' not described in 'sci_port_get_properties'
       drivers/scsi/isci/port.c:130: warning: Excess function parameter 'port' description in 'sci_port_get_properties'
       drivers/scsi/isci/port.c:130: warning: Excess function parameter 'properties' description in 'sci_port_get_properties'
       drivers/scsi/isci/port.c:243: warning: Function parameter or member 'isci_phy' not described in 'isci_port_link_down'
       drivers/scsi/isci/port.c:243: warning: Function parameter or member 'isci_port' not described in 'isci_port_link_down'
       drivers/scsi/isci/port.c:243: warning: Excess function parameter 'phy' description in 'isci_port_link_down'
       drivers/scsi/isci/port.c:243: warning: Excess function parameter 'port' description in 'isci_port_link_down'
       drivers/scsi/isci/port.c:318: warning: Function parameter or member 'isci_port' not described in 'isci_port_hard_reset_complete'
       drivers/scsi/isci/port.c:318: warning: Excess function parameter 'port' description in 'isci_port_hard_reset_complete'
       drivers/scsi/isci/port.c:398: warning: Cannot understand  *
       drivers/scsi/isci/port.c:544: warning: Function parameter or member 'iport' not described in 'sci_port_construct_dummy_rnc'
       drivers/scsi/isci/port.c:544: warning: Excess function parameter 'sci_port' description in 'sci_port_construct_dummy_rnc'
       drivers/scsi/isci/port.c:692: warning: Function parameter or member 'iport' not described in 'sci_port_general_link_up_handler'
       drivers/scsi/isci/port.c:692: warning: Function parameter or member 'iphy' not described in 'sci_port_general_link_up_handler'
       drivers/scsi/isci/port.c:692: warning: Excess function parameter 'sci_port' description in 'sci_port_general_link_up_handler'
       drivers/scsi/isci/port.c:692: warning: Excess function parameter 'sci_phy' description in 'sci_port_general_link_up_handler'
       drivers/scsi/isci/port.c:719: warning: wrong kernel-doc identifier on line:
       drivers/scsi/isci/port.c:756: warning: Function parameter or member 'iport' not described in 'sci_port_link_detected'
       drivers/scsi/isci/port.c:756: warning: Function parameter or member 'iphy' not described in 'sci_port_link_detected'
       drivers/scsi/isci/port.c:756: warning: expecting prototype for if the(). Prototype was for sci_port_link_detected() instead
       drivers/scsi/isci/port.c:821: warning: wrong kernel-doc identifier on line:
       drivers/scsi/isci/port.c:885: warning: Function parameter or member 'iport' not described in 'sci_port_post_dummy_request'
       drivers/scsi/isci/port.c:885: warning: Excess function parameter 'sci_port' description in 'sci_port_post_dummy_request'
       drivers/scsi/isci/port.c:909: warning: Function parameter or member 'iport' not described in 'sci_port_abort_dummy_request'
       drivers/scsi/isci/port.c:909: warning: expecting prototype for This will alow the hardware to(). Prototype was for sci_port_abort_dummy_request() instead
       drivers/scsi/isci/port.c:926: warning: Cannot understand  *
       drivers/scsi/isci/port.c:1017: warning: Cannot understand  *
       drivers/scsi/isci/port.c:1199: warning: Function parameter or member 'iport' not described in 'sci_port_add_phy'
       drivers/scsi/isci/port.c:1199: warning: Function parameter or member 'iphy' not described in 'sci_port_add_phy'
       drivers/scsi/isci/port.c:1199: warning: Excess function parameter 'sci_port' description in 'sci_port_add_phy'
       drivers/scsi/isci/port.c:1199: warning: Excess function parameter 'sci_phy' description in 'sci_port_add_phy'
       drivers/scsi/isci/port.c:1270: warning: Function parameter or member 'iport' not described in 'sci_port_remove_phy'
       drivers/scsi/isci/port.c:1270: warning: Function parameter or member 'iphy' not described in 'sci_port_remove_phy'
       drivers/scsi/isci/port.c:1270: warning: Excess function parameter 'sci_port' description in 'sci_port_remove_phy'
       drivers/scsi/isci/port.c:1270: warning: Excess function parameter 'sci_phy' description in 'sci_port_remove_phy'
      
      [mkp: fixed typo alow->allow]
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-29-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      7292a8b0
    • Lee Jones's avatar
      scsi: isci: request: Fix doc-rot issue relating to 'ireq' param · a8604e44
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/request.c:496: warning: Function parameter or member 'ireq' not described in 'scu_sata_request_construct_task_context'
       drivers/scsi/isci/request.c:496: warning: Excess function parameter 'sci_req' description in 'scu_sata_request_construct_task_context'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-28-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      a8604e44
    • Lee Jones's avatar
      scsi: isci: remote_device: Fix a bunch of doc-rot issues · 242e15d7
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/remote_device.c:299: warning: Function parameter or member 'ihost' not described in 'isci_remote_device_not_ready'
       drivers/scsi/isci/remote_device.c:299: warning: Function parameter or member 'idev' not described in 'isci_remote_device_not_ready'
       drivers/scsi/isci/remote_device.c:299: warning: Function parameter or member 'reason' not described in 'isci_remote_device_not_ready'
       drivers/scsi/isci/remote_device.c:299: warning: Excess function parameter 'isci_host' description in 'isci_remote_device_not_ready'
       drivers/scsi/isci/remote_device.c:299: warning: Excess function parameter 'isci_device' description in 'isci_remote_device_not_ready'
       drivers/scsi/isci/remote_device.c:1015: warning: Function parameter or member 'idev' not described in 'sci_remote_device_destruct'
       drivers/scsi/isci/remote_device.c:1015: warning: Excess function parameter 'remote_device' description in 'sci_remote_device_destruct'
       drivers/scsi/isci/remote_device.c:1249: warning: Function parameter or member 'iport' not described in 'sci_remote_device_construct'
       drivers/scsi/isci/remote_device.c:1249: warning: Function parameter or member 'idev' not described in 'sci_remote_device_construct'
       drivers/scsi/isci/remote_device.c:1249: warning: Excess function parameter 'sci_port' description in 'sci_remote_device_construct'
       drivers/scsi/isci/remote_device.c:1249: warning: Excess function parameter 'sci_dev' description in 'sci_remote_device_construct'
       drivers/scsi/isci/remote_device.c:1275: warning: Function parameter or member 'iport' not described in 'sci_remote_device_da_construct'
       drivers/scsi/isci/remote_device.c:1275: warning: Function parameter or member 'idev' not described in 'sci_remote_device_da_construct'
       drivers/scsi/isci/remote_device.c:1311: warning: Function parameter or member 'iport' not described in 'sci_remote_device_ea_construct'
       drivers/scsi/isci/remote_device.c:1311: warning: Function parameter or member 'idev' not described in 'sci_remote_device_ea_construct'
       drivers/scsi/isci/remote_device.c:1453: warning: Function parameter or member 'idev' not described in 'sci_remote_device_start'
       drivers/scsi/isci/remote_device.c:1453: warning: Excess function parameter 'remote_device' description in 'sci_remote_device_start'
       drivers/scsi/isci/remote_device.c:1513: warning: Function parameter or member 'ihost' not described in 'isci_remote_device_alloc'
       drivers/scsi/isci/remote_device.c:1513: warning: Function parameter or member 'iport' not described in 'isci_remote_device_alloc'
       drivers/scsi/isci/remote_device.c:1513: warning: expecting prototype for This function builds the isci_remote_device when a libsas dev_found message(). Prototype was for isci_remote_device_alloc() instead
       drivers/scsi/isci/remote_device.c:1558: warning: Function parameter or member 'ihost' not described in 'isci_remote_device_stop'
       drivers/scsi/isci/remote_device.c:1558: warning: Function parameter or member 'idev' not described in 'isci_remote_device_stop'
       drivers/scsi/isci/remote_device.c:1558: warning: Excess function parameter 'isci_host' description in 'isci_remote_device_stop'
       drivers/scsi/isci/remote_device.c:1558: warning: Excess function parameter 'isci_device' description in 'isci_remote_device_stop'
       drivers/scsi/isci/remote_device.c:1592: warning: Function parameter or member 'dev' not described in 'isci_remote_device_gone'
       drivers/scsi/isci/remote_device.c:1592: warning: Excess function parameter 'domain_device' description in 'isci_remote_device_gone'
       drivers/scsi/isci/remote_device.c:1614: warning: Function parameter or member 'dev' not described in 'isci_remote_device_found'
       drivers/scsi/isci/remote_device.c:1614: warning: Excess function parameter 'domain_device' description in 'isci_remote_device_found'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-27-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      242e15d7
    • Lee Jones's avatar
      scsi: isci: port_config: Fix a bunch of doc-rot and demote abuses · 29faa5ce
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/port_config.c:76: warning: Cannot understand  *
       drivers/scsi/isci/port_config.c:105: warning: Cannot understand  *
       drivers/scsi/isci/port_config.c:148: warning: Cannot understand  *
       drivers/scsi/isci/port_config.c:376: warning: Cannot understand  *
       drivers/scsi/isci/port_config.c:607: warning: Function parameter or member 'ihost' not described in 'sci_apc_agent_link_up'
       drivers/scsi/isci/port_config.c:607: warning: Function parameter or member 'port_agent' not described in 'sci_apc_agent_link_up'
       drivers/scsi/isci/port_config.c:607: warning: Function parameter or member 'iport' not described in 'sci_apc_agent_link_up'
       drivers/scsi/isci/port_config.c:607: warning: Function parameter or member 'iphy' not described in 'sci_apc_agent_link_up'
       drivers/scsi/isci/port_config.c:607: warning: Excess function parameter 'scic' description in 'sci_apc_agent_link_up'
       drivers/scsi/isci/port_config.c:607: warning: Excess function parameter 'sci_port' description in 'sci_apc_agent_link_up'
       drivers/scsi/isci/port_config.c:607: warning: Excess function parameter 'sci_phy' description in 'sci_apc_agent_link_up'
       drivers/scsi/isci/port_config.c:623: warning: Cannot understand  *
       drivers/scsi/isci/port_config.c:701: warning: Cannot understand  *
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-26-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      29faa5ce
    • Lee Jones's avatar
      scsi: isci: remote_node_context: Fix one function header and demote a couple more · ad276048
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/remote_node_context.c:77: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_context.c:167: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_context.c:206: warning: Cannot understand  *
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-25-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      ad276048
    • Lee Jones's avatar
      scsi: isci: remote_node_table: Fix a bunch of kernel-doc misdemeanours · 103d6192
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/remote_node_table.c:66: warning: Incorrect use of kernel-doc format:  *
       drivers/scsi/isci/remote_node_table.c:80: warning: Function parameter or member 'remote_node_table' not described in 'sci_remote_node_table_get_group_index'
       drivers/scsi/isci/remote_node_table.c:80: warning: Function parameter or member 'group_table_index' not described in 'sci_remote_node_table_get_group_index'
       drivers/scsi/isci/remote_node_table.c:80: warning: expecting prototype for This file contains the implementation of the SCIC_SDS_REMOTE_NODE_TABLE(). Prototype was for sci_remote_node_table_get_group_index() instead
       drivers/scsi/isci/remote_node_table.c:101: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:131: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:161: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:194: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:227: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:256: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:283: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:310: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:368: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:428: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:465: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:508: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:553: warning: Cannot understand  *
       drivers/scsi/isci/remote_node_table.c:576: warning: Cannot understand  *
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-24-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      103d6192
    • Lee Jones's avatar
      scsi: isci: task: Demote non-conformant header and remove superfluous param · 0afdee03
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/task.c:383: warning: Function parameter or member 'isci_host' not described in 'isci_task_send_lu_reset_sas'
       drivers/scsi/isci/task.c:383: warning: Function parameter or member 'isci_device' not described in 'isci_task_send_lu_reset_sas'
       drivers/scsi/isci/task.c:677: warning: Excess function parameter 'lun' description in 'isci_task_query_task'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-23-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      0afdee03
    • Lee Jones's avatar
      scsi: isci: host: Fix bunch of kernel-doc related issues · 44b7ca96
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/host.c:93: warning: Cannot understand  *
       drivers/scsi/isci/host.c:108: warning: Function parameter or member 'x' not described in 'NORMALIZE_PUT_POINTER'
       drivers/scsi/isci/host.c:121: warning: Function parameter or member 'x' not described in 'NORMALIZE_EVENT_POINTER'
       drivers/scsi/isci/host.c:130: warning: Function parameter or member 'x' not described in 'NORMALIZE_GET_POINTER'
       drivers/scsi/isci/host.c:139: warning: Function parameter or member 'x' not described in 'NORMALIZE_GET_POINTER_CYCLE_BIT'
       drivers/scsi/isci/host.c:146: warning: Function parameter or member 'x' not described in 'COMPLETION_QUEUE_CYCLE_BIT'
       drivers/scsi/isci/host.c:646: warning: Function parameter or member 'ihost' not described in 'isci_host_start_complete'
       drivers/scsi/isci/host.c:646: warning: Excess function parameter 'isci_host' description in 'isci_host_start_complete'
       drivers/scsi/isci/host.c:680: warning: Function parameter or member 'ihost' not described in 'sci_controller_get_suggested_start_timeout'
       drivers/scsi/isci/host.c:680: warning: Excess function parameter 'controller' description in 'sci_controller_get_suggested_start_timeout'
       drivers/scsi/isci/host.c:903: warning: Function parameter or member 'ihost' not described in 'sci_controller_start_next_phy'
       drivers/scsi/isci/host.c:903: warning: Excess function parameter 'scic' description in 'sci_controller_start_next_phy'
       drivers/scsi/isci/host.c:1159: warning: Function parameter or member 'ihost' not described in 'sci_controller_stop'
       drivers/scsi/isci/host.c:1159: warning: Excess function parameter 'controller' description in 'sci_controller_stop'
       drivers/scsi/isci/host.c:1184: warning: Function parameter or member 'ihost' not described in 'sci_controller_reset'
       drivers/scsi/isci/host.c:1184: warning: Excess function parameter 'controller' description in 'sci_controller_reset'
       drivers/scsi/isci/host.c:1352: warning: Function parameter or member 'ihost' not described in 'sci_controller_set_interrupt_coalescence'
       drivers/scsi/isci/host.c:1352: warning: Excess function parameter 'controller' description in 'sci_controller_set_interrupt_coalescence'
       drivers/scsi/isci/host.c:2498: warning: Function parameter or member 'ihost' not described in 'sci_controller_allocate_remote_node_context'
       drivers/scsi/isci/host.c:2498: warning: Function parameter or member 'idev' not described in 'sci_controller_allocate_remote_node_context'
       drivers/scsi/isci/host.c:2498: warning: expecting prototype for This method allocates remote node index and the reserves the remote node(). Prototype was for sci_controller_allocate_remote_node_context() instead
       drivers/scsi/isci/host.c:2721: warning: Function parameter or member 'ihost' not described in 'sci_controller_start_task'
       drivers/scsi/isci/host.c:2721: warning: Function parameter or member 'idev' not described in 'sci_controller_start_task'
       drivers/scsi/isci/host.c:2721: warning: Function parameter or member 'ireq' not described in 'sci_controller_start_task'
       drivers/scsi/isci/host.c:2721: warning: Excess function parameter 'controller' description in 'sci_controller_start_task'
       drivers/scsi/isci/host.c:2721: warning: Excess function parameter 'remote_device' description in 'sci_controller_start_task'
       drivers/scsi/isci/host.c:2721: warning: Excess function parameter 'task_request' description in 'sci_controller_start_task'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-22-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      44b7ca96
    • Lee Jones's avatar
      scsi: isci: request: Fix a myriad of kernel-doc issues · db35a083
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/request.c:211: warning: wrong kernel-doc identifier on line:
       drivers/scsi/isci/request.c:414: warning: wrong kernel-doc identifier on line:
       drivers/scsi/isci/request.c:472: warning: Function parameter or member 'ireq' not described in 'scu_ssp_task_request_construct_task_context'
       drivers/scsi/isci/request.c:472: warning: expecting prototype for The(). Prototype was for scu_ssp_task_request_construct_task_context() instead
       drivers/scsi/isci/request.c:501: warning: Function parameter or member 'ireq' not described in 'scu_sata_request_construct_task_context'
       drivers/scsi/isci/request.c:501: warning: expecting prototype for This method is will fill in the SCU Task Context for any type of SATA(). Prototype was for scu_sata_request_construct_task_context() instead
       drivers/scsi/isci/request.c:597: warning: Cannot understand  *
       drivers/scsi/isci/request.c:785: warning: expecting prototype for sci_req_tx_bytes(). Prototype was for SCU_TASK_CONTEXT_SRAM() instead
       drivers/scsi/isci/request.c:1399: warning: Cannot understand  *
       drivers/scsi/isci/request.c:1446: warning: Cannot understand  *
       drivers/scsi/isci/request.c:2465: warning: Function parameter or member 'task' not described in 'isci_request_process_response_iu'
       drivers/scsi/isci/request.c:2465: warning: Excess function parameter 'sas_task' description in 'isci_request_process_response_iu'
       drivers/scsi/isci/request.c:2501: warning: Function parameter or member 'task' not described in 'isci_request_set_open_reject_status'
       drivers/scsi/isci/request.c:2524: warning: Function parameter or member 'idev' not described in 'isci_request_handle_controller_specific_errors'
       drivers/scsi/isci/request.c:2524: warning: Function parameter or member 'task' not described in 'isci_request_handle_controller_specific_errors'
       drivers/scsi/isci/request.c:3337: warning: Function parameter or member 'idev' not described in 'isci_io_request_build'
       drivers/scsi/isci/request.c:3337: warning: Excess function parameter 'sci_device' description in 'isci_io_request_build'
      
      [mkp: fix typo reported by checkpatch]
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-21-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      db35a083
    • Lee Jones's avatar
      scsi: isci: phy: Provide function name and demote non-conforming header · 6ab7ca51
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/phy.c:354: warning: Function parameter or member 'iphy' not described in 'phy_get_non_dummy_port'
       drivers/scsi/isci/phy.c:354: warning: expecting prototype for If the phy is(). Prototype was for phy_get_non_dummy_port() instead
       drivers/scsi/isci/phy.c:371: warning: Function parameter or member 'iphy' not described in 'sci_phy_set_port'
       drivers/scsi/isci/phy.c:371: warning: Function parameter or member 'iport' not described in 'sci_phy_set_port'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-20-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      6ab7ca51
    • Lee Jones's avatar
      scsi: isci: phy: Fix a few different kernel-doc related issues · 6af1d9bd
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/phy.c:354: warning: Function parameter or member 'iphy' not described in 'phy_get_non_dummy_port'
       drivers/scsi/isci/phy.c:354: warning: expecting prototype for If the phy is(). Prototype was for phy_get_non_dummy_port() instead
       drivers/scsi/isci/phy.c:364: warning: wrong kernel-doc identifier on line:
       drivers/scsi/isci/phy.c:401: warning: wrong kernel-doc identifier on line:
       drivers/scsi/isci/phy.c:611: warning: Function parameter or member 'iphy' not described in 'sci_phy_complete_link_training'
       drivers/scsi/isci/phy.c:611: warning: Excess function parameter 'sci_phy' description in 'sci_phy_complete_link_training'
       drivers/scsi/isci/phy.c:1170: warning: Cannot understand  *
       drivers/scsi/isci/phy.c:1222: warning: Cannot understand  *
       drivers/scsi/isci/phy.c:1432: warning: Function parameter or member 'sas_phy' not described in 'isci_phy_control'
       drivers/scsi/isci/phy.c:1432: warning: Excess function parameter 'phy' description in 'isci_phy_control'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-17-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      6af1d9bd
    • Lee Jones's avatar
      scsi: fnic: Kernel-doc headers must contain the function name · 2efd8631
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/fnic/fnic_fcs.c:308: warning: expecting prototype for Check if the Received FIP FLOGI frame is rejected(). Prototype was for is_fnic_fip_flogi_reject() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-19-lee.jones@linaro.org
      Cc: Satish Kharat <satishkh@cisco.com>
      Cc: Sesidhar Baddela <sebaddel@cisco.com>
      Cc: Karan Tilak Kumar <kartilak@cisco.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      2efd8631
    • Lee Jones's avatar
      scsi: fnic: Demote non-conformant kernel-doc headers · c7eab070
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/fnic/fnic_scsi.c:183: warning: Function parameter or member 'fnic' not described in '__fnic_set_state_flags'
       drivers/scsi/fnic/fnic_scsi.c:183: warning: Function parameter or member 'st_flags' not described in '__fnic_set_state_flags'
       drivers/scsi/fnic/fnic_scsi.c:183: warning: Function parameter or member 'clearbits' not described in '__fnic_set_state_flags'
       drivers/scsi/fnic/fnic_scsi.c:2296: warning: Function parameter or member 'fnic' not described in 'fnic_scsi_host_start_tag'
       drivers/scsi/fnic/fnic_scsi.c:2296: warning: Function parameter or member 'sc' not described in 'fnic_scsi_host_start_tag'
       drivers/scsi/fnic/fnic_scsi.c:2316: warning: Function parameter or member 'fnic' not described in 'fnic_scsi_host_end_tag'
       drivers/scsi/fnic/fnic_scsi.c:2316: warning: Function parameter or member 'sc' not described in 'fnic_scsi_host_end_tag'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-18-lee.jones@linaro.org
      Cc: Satish Kharat <satishkh@cisco.com>
      Cc: Sesidhar Baddela <sebaddel@cisco.com>
      Cc: Karan Tilak Kumar <kartilak@cisco.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      c7eab070
    • Lee Jones's avatar
      scsi: be2iscsi: Demote incomplete/non-conformant kernel-doc header · a90a8c60
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/be2iscsi/be_main.c:4937: warning: Function parameter or member 'data' not described in 'beiscsi_show_boot_tgt_info'
       drivers/scsi/be2iscsi/be_main.c:4937: warning: Function parameter or member 'type' not described in 'beiscsi_show_boot_tgt_info'
       drivers/scsi/be2iscsi/be_main.c:4937: warning: Function parameter or member 'buf' not described in 'beiscsi_show_boot_tgt_info'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-16-lee.jones@linaro.org
      Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>
      Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
      Cc: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-drivers@broadcom.com
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      a90a8c60
    • Lee Jones's avatar
      scsi: mpt3sas: Fix a few kernel-doc issues · a8d548b0
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:763: warning: Function parameter or member 'sas_address' not described in '__mpt3sas_get_sdev_by_addr'
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:763: warning: expecting prototype for mpt3sas_get_sdev_by_addr(). Prototype was for __mpt3sas_get_sdev_by_addr() instead
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:4535: warning: expecting prototype for _scsih_check_for_pending_internal_cmds(). Prototype was for mpt3sas_check_for_pending_internal_cmds() instead
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'port_entry' not described in '_scsih_look_and_get_matched_port_entry'
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'matched_port_entry' not described in '_scsih_look_and_get_matched_port_entry'
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'count' not described in '_scsih_look_and_get_matched_port_entry'
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:6959: warning: Function parameter or member 'port' not described in 'mpt3sas_expander_remove'
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:10494: warning: expecting prototype for mpt3sas_scsih_reset_handler(). Prototype was for mpt3sas_scsih_pre_reset_handler() instead
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:10536: warning: expecting prototype for mpt3sas_scsih_reset_handler(). Prototype was for mpt3sas_scsih_reset_done_handler() instead
       drivers/scsi/mpt3sas/mpt3sas_scsih.c:12303: warning: expecting prototype for scsih__ncq_prio_supp(). Prototype was for scsih_ncq_prio_supp() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-15-lee.jones@linaro.org
      Cc: Sathya Prakash <sathya.prakash@broadcom.com>
      Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
      Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: MPT-FusionLinux.pdl@avagotech.com
      Cc: MPT-FusionLinux.pdl@broadcom.com
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      a8d548b0
    • Lee Jones's avatar
      scsi: pmcraid: Correct function name pmcraid_show_adapter_id() in header · a364a147
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/pmcraid.c:4079: warning: expecting prototype for pmcraid_show_io_adapter_id(). Prototype was for pmcraid_show_adapter_id() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-14-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      a364a147
    • Lee Jones's avatar
      scsi: myrs: Add missing ':' to make the kernel-doc checker happy · 9eb292eb
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/myrs.c:1965: warning: Function parameter or member 'dev' not described in 'myrs_is_raid'
       drivers/scsi/myrs.c:1978: warning: Function parameter or member 'dev' not described in 'myrs_get_resync'
       drivers/scsi/myrs.c:2002: warning: Function parameter or member 'dev' not described in 'myrs_get_state'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-13-lee.jones@linaro.org
      Cc: Hannes Reinecke <hare@kernel.org>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Linux GmbH <hare@suse.com>
      Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      9eb292eb
    • Lee Jones's avatar
      scsi: a100u2w: Fix some misnaming and formatting issues · c548a625
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/a100u2w.c:278: warning: expecting prototype for orc_exec_sb(). Prototype was for orc_exec_scb() instead
       drivers/scsi/a100u2w.c:596: warning: Function parameter or member 'target' not described in 'orc_device_reset'
       drivers/scsi/a100u2w.c:739: warning: Function parameter or member 'host' not described in 'orchid_abort_scb'
       drivers/scsi/a100u2w.c:739: warning: Function parameter or member 'scb' not described in 'orchid_abort_scb'
       drivers/scsi/a100u2w.c:915: warning: expecting prototype for inia100_queue(). Prototype was for inia100_queue_lck() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-12-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      c548a625
    • Lee Jones's avatar
      scsi: initio: Fix a few kernel-doc misdemeanours · 100ec495
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/initio.c:560: warning: Excess function parameter 'num_scbs' description in 'initio_init'
       drivers/scsi/initio.c:1899: warning: expecting prototype for int_initio_scsi_resel(). Prototype was for int_initio_resel() instead
       drivers/scsi/initio.c:2615: warning: expecting prototype for i91u_queuecommand(). Prototype was for i91u_queuecommand_lck() instead
       drivers/scsi/initio.c:2667: warning: Function parameter or member 'dev' not described in 'i91u_biosparam'
       drivers/scsi/initio.c:2667: warning: expecting prototype for i91u_biospararm(). Prototype was for i91u_biosparam() instead
       drivers/scsi/initio.c:2740: warning: Function parameter or member 'host_mem' not described in 'i91uSCBPost'
       drivers/scsi/initio.c:2740: warning: Function parameter or member 'cblk_mem' not described in 'i91uSCBPost'
       drivers/scsi/initio.c:2740: warning: Excess function parameter 'host' description in 'i91uSCBPost'
       drivers/scsi/initio.c:2740: warning: Excess function parameter 'cmnd' description in 'i91uSCBPost'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-11-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Bas Vermeulen <bvermeul@blackstar.xs4all.nl>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Brian Macy <bmacy@sunshinecomputing.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      100ec495
    • Lee Jones's avatar
      scsi: dc395x: Fix some function param descriptions · 33c8ef95
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/dc395x.c:4353: warning: Function parameter or member 'acb' not described in 'adapter_init'
       drivers/scsi/dc395x.c:4353: warning: Function parameter or member 'io_port_len' not described in 'adapter_init'
       drivers/scsi/dc395x.c:4353: warning: Excess function parameter 'host' description in 'adapter_init'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-10-lee.jones@linaro.org
      Cc: Oliver Neukum <oliver@neukum.org>
      Cc: Ali Akcaagac <aliakc@web.de>
      Cc: Jamie Lenehan <lenehan@twibble.org>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: "C.L. Huang" <ching@tekram.com.tw>
      Cc: Erich Chen <erich@tekram.com.tw>
      Cc: Kurt Garloff <garloff@suse.de>
      Cc: dc395x@twibble.org
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      33c8ef95
    • Lee Jones's avatar
      scsi: be2iscsi: Ensure function follows directly after its header · f1d50e8e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/be2iscsi/be_main.c:4935: warning: expecting prototype for beiscsi_show_boot_tgt_info(). Prototype was for BEISCSI_SYSFS_ISCSI_BOOT_FLAGS() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-9-lee.jones@linaro.org
      Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>
      Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
      Cc: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-drivers@broadcom.com
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      f1d50e8e
    • Lee Jones's avatar
      scsi: aic94xx: Correct misspelling of function asd_dump_seq_state() · 3e2f4679
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/aic94xx/aic94xx_dump.c:729: warning: expecting prototype for ads_dump_seq_state(). Prototype was for asd_dump_seq_state() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-8-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Lee Jones <lee.jones@linaro.org>
      Cc: David Chaw <david_chaw@adaptec.com>
      Cc: Luben Tuikov <luben_tuikov@adaptec.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      3e2f4679
    • Lee Jones's avatar
      scsi: sd: Fix function name in header · ad907c54
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/sd.c:1537: warning: expecting prototype for sd_ioctl(). Prototype was for sd_ioctl_common() instead
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-7-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Drew Eckhardt <drew@colorado.edu>
      Cc: Eric Youngdale <eric@andante.org>
      Cc: Jirka Hanika <geo@ff.cuni.cz>
      Cc: Richard Gooch <rgooch@atnf.csiro.au>
      Cc: Torben Mathiasen <tmm@image.dk>
      Cc: Alex Davis <letmein@erols.com>
      Cc: Douglas Gilbert <dgilbert@interlog.com>
      Cc: Badari Pulavarty <pbadari@us.ibm.com>
      Cc: willy@debian.org
      Cc: Kurt Garloff <garloff@suse.de>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      ad907c54
    • Lee Jones's avatar
      scsi: pmcraid: Fix a whole host of kernel-doc issues · 3673b7b0
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/pmcraid.c:455: warning: Function parameter or member 'intrs' not described in 'pmcraid_enable_interrupts'
       drivers/scsi/pmcraid.c:455: warning: Excess function parameter 'intr' description in 'pmcraid_enable_interrupts'
       drivers/scsi/pmcraid.c:543: warning: Function parameter or member '' not described in 'pmcraid_ioa_reset'
       drivers/scsi/pmcraid.c:543: warning: expecting prototype for pmcraid_bist_done(). Prototype was for pmcraid_ioa_reset() instead
       drivers/scsi/pmcraid.c:603: warning: Function parameter or member 't' not described in 'pmcraid_reset_alert_done'
       drivers/scsi/pmcraid.c:603: warning: Excess function parameter 'cmd' description in 'pmcraid_reset_alert_done'
       drivers/scsi/pmcraid.c:638: warning: Function parameter or member '' not described in 'pmcraid_notify_ioastate'
       drivers/scsi/pmcraid.c:638: warning: Function parameter or member 'u32' not described in 'pmcraid_notify_ioastate'
       drivers/scsi/pmcraid.c:638: warning: expecting prototype for pmcraid_reset_alert(). Prototype was for pmcraid_notify_ioastate() instead
       drivers/scsi/pmcraid.c:687: warning: Function parameter or member 't' not described in 'pmcraid_timeout_handler'
       drivers/scsi/pmcraid.c:687: warning: Excess function parameter 'cmd' description in 'pmcraid_timeout_handler'
       drivers/scsi/pmcraid.c:858: warning: expecting prototype for pmcraid_fire_command(). Prototype was for _pmcraid_fire_command() instead
       drivers/scsi/pmcraid.c:972: warning: Function parameter or member '' not described in 'pmcraid_querycfg'
       drivers/scsi/pmcraid.c:972: warning: expecting prototype for pmcraid_get_fwversion_done(). Prototype was for pmcraid_querycfg() instead
       drivers/scsi/pmcraid.c:1398: warning: Function parameter or member 'aen_msg' not described in 'pmcraid_notify_aen'
       drivers/scsi/pmcraid.c:1398: warning: Function parameter or member 'data_size' not described in 'pmcraid_notify_aen'
       drivers/scsi/pmcraid.c:1398: warning: Excess function parameter 'type' description in 'pmcraid_notify_aen'
       drivers/scsi/pmcraid.c:1781: warning: Function parameter or member '' not described in 'pmcraid_initiate_reset'
       drivers/scsi/pmcraid.c:1781: warning: expecting prototype for pmcraid_process_ldn(). Prototype was for pmcraid_initiate_reset() instead
       drivers/scsi/pmcraid.c:1887: warning: Function parameter or member '' not described in 'pmcraid_reinit_buffers'
       drivers/scsi/pmcraid.c:1887: warning: expecting prototype for pmcraid_reset_enable_ioa(). Prototype was for pmcraid_reinit_buffers() instead
       drivers/scsi/pmcraid.c:2704: warning: Function parameter or member 'timeout' not described in 'pmcraid_reset_device'
       drivers/scsi/pmcraid.c:3025: warning: expecting prototype for pmcraid_eh_xxxx_reset_handler(). Prototype was for pmcraid_eh_device_reset_handler() instead
       drivers/scsi/pmcraid.c:3327: warning: expecting prototype for pmcraid_queuecommand(). Prototype was for pmcraid_queuecommand_lck() instead
       drivers/scsi/pmcraid.c:3437: warning: Function parameter or member 'inode' not described in 'pmcraid_chr_open'
       drivers/scsi/pmcraid.c:3437: warning: Function parameter or member 'filep' not described in 'pmcraid_chr_open'
       drivers/scsi/pmcraid.c:3437: warning: expecting prototype for pmcraid_open(). Prototype was for pmcraid_chr_open() instead
       drivers/scsi/pmcraid.c:3457: warning: Function parameter or member 'fd' not described in 'pmcraid_chr_fasync'
       drivers/scsi/pmcraid.c:3457: warning: Function parameter or member 'filep' not described in 'pmcraid_chr_fasync'
       drivers/scsi/pmcraid.c:3457: warning: Function parameter or member 'mode' not described in 'pmcraid_chr_fasync'
       drivers/scsi/pmcraid.c:3457: warning: expecting prototype for pmcraid_fasync(). Prototype was for pmcraid_chr_fasync() instead
       drivers/scsi/pmcraid.c:3574: warning: Function parameter or member 'ioctl_cmd' not described in 'pmcraid_ioctl_passthrough'
       drivers/scsi/pmcraid.c:3574: warning: Function parameter or member 'buflen' not described in 'pmcraid_ioctl_passthrough'
       drivers/scsi/pmcraid.c:3574: warning: Excess function parameter 'cmd' description in 'pmcraid_ioctl_passthrough'
       drivers/scsi/pmcraid.c:3905: warning: Function parameter or member 'filep' not described in 'pmcraid_chr_ioctl'
       drivers/scsi/pmcraid.c:3905: warning: Function parameter or member 'cmd' not described in 'pmcraid_chr_ioctl'
       drivers/scsi/pmcraid.c:3905: warning: Function parameter or member 'arg' not described in 'pmcraid_chr_ioctl'
       drivers/scsi/pmcraid.c:3905: warning: expecting prototype for pmcraid_ioctl(). Prototype was for pmcraid_chr_ioctl() instead
       drivers/scsi/pmcraid.c:3969: warning: cannot understand function prototype: 'const struct file_operations pmcraid_fops = '
       drivers/scsi/pmcraid.c:3993: warning: Function parameter or member 'attr' not described in 'pmcraid_show_log_level'
       drivers/scsi/pmcraid.c:4015: warning: Function parameter or member 'attr' not described in 'pmcraid_store_log_level'
       drivers/scsi/pmcraid.c:4055: warning: Function parameter or member 'attr' not described in 'pmcraid_show_drv_version'
       drivers/scsi/pmcraid.c:4081: warning: Function parameter or member 'attr' not described in 'pmcraid_show_adapter_id'
       drivers/scsi/pmcraid.c:4081: warning: expecting prototype for pmcraid_show_io_adapter_id(). Prototype was for pmcraid_show_adapter_id() instead
       drivers/scsi/pmcraid.c:4600: warning: Function parameter or member 'pinstance' not described in 'pmcraid_allocate_cmd_blocks'
       drivers/scsi/pmcraid.c:5153: warning: Function parameter or member 'minor' not described in 'pmcraid_release_minor'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-6-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      3673b7b0
    • Lee Jones's avatar
      scsi: sd_zbc: Place function name into header · 59863cb5
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/sd_zbc.c:137: warning: wrong kernel-doc identifier on line:
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-5-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Hannes Reinecke <hare@suse.de>
      Cc: Le Moal <damien.lemoal@hgst.com>
      Cc: Shaun Tancheff <shaun.tancheff@seagate.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      59863cb5
    • Lee Jones's avatar
      scsi: mvumi: Fix formatting and doc-rot issues · 5ccd6265
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/mvumi.c:191: warning: Function parameter or member 'sg_count' not described in 'mvumi_make_sgl'
       drivers/scsi/mvumi.c:1301: warning: Function parameter or member 'ob_frame' not described in 'mvumi_complete_cmd'
       drivers/scsi/mvumi.c:2084: warning: Function parameter or member 'shost' not described in 'mvumi_queue_command'
       drivers/scsi/mvumi.c:2084: warning: Excess function parameter 'done' description in 'mvumi_queue_command'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-4-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Marvell <jyli@marvell.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      5ccd6265
    • Lee Jones's avatar
      scsi: ipr: Fix incorrect function names in their headers · 637b5c3e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/ipr.c:5335: warning: expecting prototype for ipr_eh_dev_reset(). Prototype was for __ipr_eh_dev_reset() instead
       drivers/scsi/ipr.c:5594: warning: expecting prototype for ipr_eh_abort(). Prototype was for ipr_scan_finished() instead
       drivers/scsi/ipr.c:5616: warning: expecting prototype for ipr_eh_host_reset(). Prototype was for ipr_eh_abort() instead
       drivers/scsi/ipr.c:6725: warning: expecting prototype for ipr_info(). Prototype was for ipr_ioa_info() instead
      
      [mkp: tweaked ipr_scan_finished() comment]
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-3-lee.jones@linaro.org
      Cc: Brian King <brking@us.ibm.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      637b5c3e
    • Lee Jones's avatar
      scsi: myrb: Demote non-conformant kernel-doc headers and fix others · 12a1b740
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/myrb.c:91: warning: Function parameter or member 'pdev' not described in 'myrb_create_mempools'
       drivers/scsi/myrb.c:91: warning: Function parameter or member 'cb' not described in 'myrb_create_mempools'
       drivers/scsi/myrb.c:141: warning: Function parameter or member 'cb' not described in 'myrb_destroy_mempools'
       drivers/scsi/myrb.c:153: warning: Function parameter or member 'cmd_blk' not described in 'myrb_reset_cmd'
       drivers/scsi/myrb.c:164: warning: Function parameter or member 'cb' not described in 'myrb_qcmd'
       drivers/scsi/myrb.c:164: warning: Function parameter or member 'cmd_blk' not described in 'myrb_qcmd'
       drivers/scsi/myrb.c:187: warning: Function parameter or member 'cb' not described in 'myrb_exec_cmd'
       drivers/scsi/myrb.c:187: warning: Function parameter or member 'cmd_blk' not described in 'myrb_exec_cmd'
       drivers/scsi/myrb.c:208: warning: Function parameter or member 'cb' not described in 'myrb_exec_type3'
       drivers/scsi/myrb.c:208: warning: Function parameter or member 'op' not described in 'myrb_exec_type3'
       drivers/scsi/myrb.c:208: warning: Function parameter or member 'addr' not described in 'myrb_exec_type3'
       drivers/scsi/myrb.c:231: warning: Function parameter or member 'cb' not described in 'myrb_exec_type3D'
       drivers/scsi/myrb.c:231: warning: Function parameter or member 'op' not described in 'myrb_exec_type3D'
       drivers/scsi/myrb.c:231: warning: Function parameter or member 'sdev' not described in 'myrb_exec_type3D'
       drivers/scsi/myrb.c:231: warning: Function parameter or member 'pdev_info' not described in 'myrb_exec_type3D'
       drivers/scsi/myrb.c:341: warning: Function parameter or member 'cb' not described in 'myrb_get_errtable'
       drivers/scsi/myrb.c:388: warning: Function parameter or member 'cb' not described in 'myrb_get_ldev_info'
       drivers/scsi/myrb.c:440: warning: Function parameter or member 'cb' not described in 'myrb_get_rbld_progress'
       drivers/scsi/myrb.c:440: warning: Function parameter or member 'rbld' not described in 'myrb_get_rbld_progress'
       drivers/scsi/myrb.c:472: warning: Function parameter or member 'cb' not described in 'myrb_update_rbld_progress'
       drivers/scsi/myrb.c:533: warning: Function parameter or member 'cb' not described in 'myrb_get_cc_progress'
       drivers/scsi/myrb.c:580: warning: Function parameter or member 'cb' not described in 'myrb_bgi_control'
       drivers/scsi/myrb.c:671: warning: Function parameter or member 'cb' not described in 'myrb_hba_enquiry'
       drivers/scsi/myrb.c:782: warning: Function parameter or member 'cb' not described in 'myrb_set_pdev_state'
       drivers/scsi/myrb.c:782: warning: Function parameter or member 'sdev' not described in 'myrb_set_pdev_state'
       drivers/scsi/myrb.c:782: warning: Function parameter or member 'state' not described in 'myrb_set_pdev_state'
       drivers/scsi/myrb.c:808: warning: Function parameter or member 'cb' not described in 'myrb_enable_mmio'
       drivers/scsi/myrb.c:808: warning: Function parameter or member 'mmio_init_fn' not described in 'myrb_enable_mmio'
       drivers/scsi/myrb.c:913: warning: Function parameter or member 'cb' not described in 'myrb_get_hba_config'
       drivers/scsi/myrb.c:1200: warning: Function parameter or member 'cb' not described in 'myrb_unmap'
       drivers/scsi/myrb.c:1236: warning: Function parameter or member 'cb' not described in 'myrb_cleanup'
       drivers/scsi/myrb.c:2249: warning: Function parameter or member 'dev' not described in 'myrb_is_raid'
       drivers/scsi/myrb.c:2260: warning: Function parameter or member 'dev' not described in 'myrb_get_resync'
       drivers/scsi/myrb.c:2287: warning: Function parameter or member 'dev' not described in 'myrb_get_state'
       drivers/scsi/myrb.c:2493: warning: Function parameter or member 'cb' not described in 'myrb_err_status'
       drivers/scsi/myrb.c:2493: warning: Function parameter or member 'error' not described in 'myrb_err_status'
       drivers/scsi/myrb.c:2493: warning: Function parameter or member 'parm0' not described in 'myrb_err_status'
       drivers/scsi/myrb.c:2493: warning: Function parameter or member 'parm1' not described in 'myrb_err_status'
      
      Link: https://lore.kernel.org/r/20210317091230.2912389-2-lee.jones@linaro.org
      Cc: Hannes Reinecke <hare@kernel.org>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Linux GmbH <hare@suse.com>
      Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      12a1b740
    • Lee Jones's avatar
      scsi: nsp32: Correct expected types in debug print formatting · 45d59ab3
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/nsp32.c: In function ‘nsp32_setup_sg_table’:
       drivers/scsi/nsp32.c:879:6: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘unsigned int’ [-Wformat=]
       drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’
       drivers/scsi/nsp32.c:879:52: note: format string is defined here
       drivers/scsi/nsp32.c: In function ‘nsp32_detect’:
       drivers/scsi/nsp32.c:2719:6: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=]
       drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’
       drivers/scsi/nsp32.c:2719:22: note: format string is defined here
       drivers/scsi/nsp32.c:2719:6: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘int’ [-Wformat=]
       drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’
       drivers/scsi/nsp32.c:2719:28: note: format string is defined here
       drivers/scsi/nsp32.c: In function ‘nsp32_suspend’:
       drivers/scsi/nsp32.c:3267:23: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘pm_message_t’ {aka ‘struct pm_message’} [-Wformat=]
       drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’
       drivers/scsi/nsp32.c:3267:56: note: format string is defined here
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-9-lee.jones@linaro.org
      Cc: GOTO Masanori <gotom@debian.or.jp>
      Cc: YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: gotom@debian.org
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      45d59ab3
    • Lee Jones's avatar
      scsi: isci: Make local function port_state_name() static · 72444bbd
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/port.c:65:13: warning: no previous prototype for ‘port_state_name’ [-Wmissing-prototypes]
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-8-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      72444bbd
    • Lee Jones's avatar
      scsi: isci: Make local function isci_remote_device_wait_for_resume_from_abort() static · ab3f2d15
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/isci/remote_device.c:1387:6: warning: no previous prototype for ‘isci_remote_device_wait_for_resume_from_abort’ [-Wmissing-prototypes]
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-7-lee.jones@linaro.org
      Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      ab3f2d15
    • Lee Jones's avatar
      scsi: sim710: Remove unused variable 'err' from sim710_init() · 886eb6d5
      Lee Jones authored
      Take the opportunity to rework the comment a little.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/sim710.c: In function ‘sim710_init’:
       drivers/scsi/sim710.c:216:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-6-lee.jones@linaro.org
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: Richard Hirst <richard@sleepie.demon.co.uk>
      Cc: c by <James.Bottomley@SteelEye.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      886eb6d5
    • Lee Jones's avatar
      scsi: FlashPoint: Remove unused variable 'TID' from FlashPoint_AbortCCB() · f466690b
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/FlashPoint.c: In function ‘FlashPoint_AbortCCB’:
       drivers/scsi/FlashPoint.c:1618:16: warning: variable ‘TID’ set but not used [-Wunused-but-set-variable]
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-5-lee.jones@linaro.org
      Cc: Khalid Aziz <khalid@gonehiking.org>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: linux-scsi@vger.kernel.org
      Acked-by: default avatarKhalid Aziz <khalid@gonehiking.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      f466690b
    • Lee Jones's avatar
      scsi: nsp32: Remove or exclude unused variables · 94685e7a
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/nsp32.c: In function ‘nsp32_selection_autoscsi’:
       drivers/scsi/nsp32.c:584:17: warning: variable ‘execph’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/nsp32.c: In function ‘nsp32_msgout_occur’:
       drivers/scsi/nsp32.c:1785:7: warning: variable ‘new_sgtp’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/nsp32.c: In function ‘nsp32_analyze_sdtr’:
       drivers/scsi/nsp32.c:2227:20: warning: variable ‘syncnum’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/nsp32.c:2223:20: warning: variable ‘synct’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/nsp32.c: In function ‘nsp32_do_bus_reset’:
       drivers/scsi/nsp32.c:2841:17: warning: variable ‘intrdat’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/nsp32.c: In function ‘nsp32_getprom_param’:
       drivers/scsi/nsp32.c:2912:11: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-4-lee.jones@linaro.org
      Cc: GOTO Masanori <gotom@debian.or.jp>
      Cc: YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: gotom@debian.org
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      94685e7a
    • Lee Jones's avatar
      scsi: nsp32: Supply __printf(x, y) formatting for nsp32_message() · 66730771
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/nsp32.c: In function ‘nsp32_message’:
       drivers/scsi/nsp32.c:318:2: warning: function ‘nsp32_message’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-3-lee.jones@linaro.org
      Cc: GOTO Masanori <gotom@debian.or.jp>
      Cc: YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: gotom@debian.org
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      66730771
    • Lee Jones's avatar
      scsi: BusLogic: Supply __printf(x, y) formatting for blogic_msg() · 5c9e2596
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       In file included from drivers/scsi/BusLogic.c:51:
       drivers/scsi/BusLogic.c: In function ‘blogic_msg’:
       drivers/scsi/BusLogic.c:3591:2: warning: function ‘blogic_msg’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
      
      Link: https://lore.kernel.org/r/20210317091125.2910058-2-lee.jones@linaro.org
      Cc: Khalid Aziz <khalid@gonehiking.org>
      Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
      Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
      Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
      Cc: linux-scsi@vger.kernel.org
      Acked-by: default avatarKhalid Aziz <khalid@gonehiking.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      5c9e2596