- 03 Jul, 2013 40 commits
-
-
Sachin Kamat authored
Use #include <linux/io.h> instead of <asm/io.h> as pointed out by checkpatch. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Cc: George G. Davis <gdavis@mvista.com> Cc: Jingoo Han <jg1.han@samsung.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Sachin Kamat authored
Fixes the following error: ERROR: spaces required around that '>=' (ctx:WxV) Signed-off-by:
-
Sachin Kamat authored
pr_warn is preferred to pr_warning. Signed-off-by:
-
Sachin Kamat authored
WARNING: please, no space before tabs Signed-off-by:
-
Sachin Kamat authored
Fixes the following warning: WARNING: space prohibited before semicolon Signed-off-by:
-
Sachin Kamat authored
Fixes the following warning: WARNING: space prohibited before semicolon Signed-off-by:
-
Sachin Kamat authored
Silences the following type of warnings: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: -
Sachin Kamat authored
Silences the following checkpatch warning: WARNING: space prohibited before semicolon Signed-off-by:
-
Sachin Kamat authored
Silences the following checkpatch warning: WARNING: please, no space before tabs Signed-off-by:
-
Sachin Kamat authored
Fixes the following warning: WARNING: please, no space before tabs Signed-off-by:
-
Sachin Kamat authored
Fixes the following types of issues: WARNING: please, no spaces at the start of a line WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Sachin Kamat authored
Fixes the following types of issues: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by:
-
Sachin Kamat authored
Silences the following type of warnings: WARNING: sizeof buf should be sizeof(buf) Signed-off-by:
-
Sachin Kamat authored
Silences the following warning: WARNING: please, no space before tabs Signed-off-by:
-
Sachin Kamat authored
Fixes the following types of issues: ERROR: space required after that ',' (ctx:VxV) WARNING: please, no spaces at the start of a line Signed-off-by:
-
Sachin Kamat authored
Silences the following checkpatch warning: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by:
-
Sachin Kamat authored
Fixes the following error: ERROR: space required before the open parenthesis '(' Signed-off-by: -
Sachin Kamat authored
Fixes the following types of errors: ERROR: "foo* bar" should be "foo *bar" ERROR: else should follow close brace '}' WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Sachin Kamat authored
Remove a redundant goto statement left over during the conversion of this driver to use devm_* APIs. Signed-off-by:
-
Jingoo Han authored
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d063 ("device-core: Ensure drvdata = NULL when no driver is bound"). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
-
Mathias Krause authored
When writing invalid input to 'debug/kprobes/enabled' it'll silently be ignored. Even worse, when writing an empty string to this file, the outcome is purely random as the switch statement will make its decision based on the value of an uninitialized stack variable. Fix this by handling invalid/empty input as error returning -EINVAL. Signed-off-by:
Mathias Krause <minipli@googlemail.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Signed-off-by:
-
Toralf Förster authored
Trivial, but it really looks better. Signed-off-by:
Toralf Förster <toralf.foerster@gmx.de> Signed-off-by:
-
Steven Rostedt authored
do_one_initcall() uses a 64 byte string buffer to save a message. This buffer is declared static and is only used at boot up and when a module is loaded. As 64 bytes is very small, and this function has very limited scope, there's no reason to waste permanent memory with this string and not just simply put it on the stack. Signed-off-by:
Steven Rostedt <rostedt@goodmis.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by:
-
Joe Perches authored
Add a file to cache the CamelCase variables found by <commit> to reduce the time it takes to scan the include/ directory. Filename is '.checkpatch-camelcase.<commit>' and it is created only only if a .git directory exists. <commit> is determined by the last non-merge commit id in the include/ path. Reduces checkpatch run time by ~12 cpu seconds on my little netbook. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Jacob Keller authored
The current $logFunction regular expression allows names like dev_warn, e_dbg, netdev_info, etc, but some log functions are now written like e_dev_warn, so allow 1 or 2 word blocks with an underscore before the logging level. Signed-off-by:
Jacob Keller <jacob.e.keller@intel.com> Tested-by:
Aaron Brown <aaron.f.brown@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by:
-
Joe Perches authored
When using --strict, CamelCase uses are described with CHECK: messages. These CamelCase uses may be acceptable and should not generate these messages when the variable is already defined in a file from the include/... path. So, change checkpatch to read all the .h files in include/... and look for preexisting CamelCase #defines, typedefs and function prototypes. Add these to the existing camelcase hash so that any uses in the patch or file can be ignored. There are currently ~3500 files in include/. It takes about 10 cpu seconds on my little netbook to grep for and preseed these existing uses. That's about 4x the time for a similar git grep. This preseeding is only done once when using --strict and only when there is a CamelCase use found. If a .git directory is found, it uses 'git ls-files include' If not, it uses 'find $root/include -name "*.h" Signed-off-by:
-
Joe Perches authored
Many existing variable names use SI like variants that should be otherwise obvious and acceptable. Whitelist them from the CamelCase message. Signed-off-by:
Phil Carmody <phil.carmody@partner.samsung.com> Acked-by:
-
Joe Perches authored
Moving this test allows the --fix option to work better. Signed-off-by:
-
Joe Perches authored
Some patches have simple defects in whitespace and formatting that checkpatch could correct automatically. Attempt to do so. Add a --fix option to create a "<inputfile>.EXPERIMENTAL-checkpatch-fixes" file that tries to use normal kernel style for some of these formatting errors. Add warnings against using this file without verifying the changes. Signed-off-by:
-
Joe Perches authored
Some false positives exist on this test. For instance: *va_arg(args, signed char *) = val.s; or memset(foo, 0, sizeof(struct bar *) * baz)); Ignore lines that have an arithmetic operator or assignment after what appears to be a cast to a pointer "(foo *)". Add $Arithmetic convenience variable. Signed-off-by:
-
Joe Perches authored
Comparing to true or false is error prone. Add tests for the various forms of (foo == true) && (false != bar) that are only reported with --strict. Signed-off-by:
-
Joe Perches authored
Check to make sure the blank lines aren't comment lines like: bool foo(bool bar) { /* Don't warn on a leading comment */ return !bar; /* Don't warn on a trailing comment either */ } Signed-off-by: -
Joe Perches authored
Figure out first how to determine if this is in a struct declaration or in a function body before enabling this. Signed-off-by:
-
Joe Perches authored
Allow "#define foo struct.member" without bleating a warning. This also allows "#define foo bar.baz->qux" and so on. Signed-off-by:
-
Joe Perches authored
Comparing get_jiffies_64() is almost always wrong and time_before64 and time_after64 should be used instead. Warn on any comparison to get_jiffies_64(). Signed-off-by:
-
Joe Perches authored
Comparing jiffies is almost always wrong and time_before and time_after should be used instead. Warn on any comparison to jiffies. Signed-off-by:
-
Joe Perches authored
Some block comments in network are written as: /* block comment line 1 block comment line 2 */ Emit a warning on the "block comment line 2" because it should be /* block comment line 1 * block comment line 2 */ This warning is only emitted on the second line of a block comment. Signed-off-by:
-
Joe Perches authored
Show the first line of the comment after a line with just /* to better show where the defective comment style is in the file. Signed-off-by:
-
Joe Perches authored
Commit be987d9f ("checkpatch: improve CamelCase test for Page") added it but it shouldn't be there. Must have been my fault. Make sure that the tested variable doesn't contain a constant. Signed-off-by:
-
Joe Perches authored
Add another test for memory allocation style to follow Documentation/CodingStyle: Chapter 14: Allocating memory The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...); Signed-off-by:
-
