1. 13 Jul, 2024 6 commits
    • Linus Torvalds's avatar
      Merge tag 'i2c-for-6.10-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · 4d145e3f
      Linus Torvalds authored
      Pull i2c fixes from Wolfram Sang:
       "Fixes for the I2C testunit, the Renesas R-Car driver and some
        MAINTAINERS corrections"
      
      * tag 'i2c-for-6.10-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
        i2c: testunit: avoid re-issued work after read message
        i2c: rcar: ensure Gen3+ reset does not disturb local targets
        i2c: mark HostNotify target address as used
        i2c: testunit: correct Kconfig description
        MAINTAINERS: VIRTIO I2C loses a maintainer, gains a reviewer
        MAINTAINERS: delete entries for Thor Thayer
        i2c: rcar: clear NO_RXDMA flag after resetting
        i2c: rcar: bring hardware to known state when probing
      4d145e3f
    • Linus Torvalds's avatar
      Merge tag '6.10-rc7-smb3-client-fix' of git://git.samba.org/sfrench/cifs-2.6 · d0d0cd38
      Linus Torvalds authored
      Pull smb client fix from Steve French:
       "Small fix, also for stable"
      
      * tag '6.10-rc7-smb3-client-fix' of git://git.samba.org/sfrench/cifs-2.6:
        cifs: fix setting SecurityFlags to true
      d0d0cd38
    • Steve French's avatar
      cifs: fix setting SecurityFlags to true · d2346e28
      Steve French authored
      If you try to set /proc/fs/cifs/SecurityFlags to 1 it
      will set them to CIFSSEC_MUST_NTLMV2 which no longer is
      relevant (the less secure ones like lanman have been removed
      from cifs.ko) and is also missing some flags (like for
      signing and encryption) and can even cause mount to fail,
      so change this to set it to Kerberos in this case.
      
      Also change the description of the SecurityFlags to remove mention
      of flags which are no longer supported.
      
      Cc: stable@vger.kernel.org
      Reviewed-by: default avatarShyam Prasad N <sprasad@microsoft.com>
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      d2346e28
    • Wolfram Sang's avatar
      Merge tag 'i2c-host-fixes-6.10-rc8' of... · 3fdd2d21
      Wolfram Sang authored
      Merge tag 'i2c-host-fixes-6.10-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux into i2c/for-current
      
      This tag includes three fixes for the Renesas R-Car driver:
      
       1. Ensures the device is in a known state after probing.
       2. Allows clearing the NO_RXDMA flag after a reset.
       3. Forces a reset before any transfer on Gen3+ platforms to
          prevent disruption of the configuration during parallel
          transfers.
      3fdd2d21
    • Linus Torvalds's avatar
      Merge tag 'net-6.10-rc8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 528dd46d
      Linus Torvalds authored
      Pull more networking fixes from Jakub Kicinski:
       "A quick follow up to yesterday's pull. We got a regressions report for
        the bnxt patch as soon as it got to your tree. The ethtool fix is also
        good to have, although it's an older regression.
      
        Current release - regressions:
      
         - eth: bnxt_en: fix crash in bnxt_get_max_rss_ctx_ring() on older HW
           when user tries to decrease the ring count
      
        Previous releases - regressions:
      
         - ethtool: fix RSS setting, accept "no change" setting if the driver
           doesn't support the new features
      
         - eth: i40e: remove needless retries of NVM update, don't wait 20min
           when we know the firmware update won't succeed"
      
      * tag 'net-6.10-rc8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net:
        bnxt_en: Fix crash in bnxt_get_max_rss_ctx_ring()
        octeontx2-af: fix issue with IPv4 match for RSS
        octeontx2-af: fix issue with IPv6 ext match for RSS
        octeontx2-af: fix detection of IP layer
        octeontx2-af: fix a issue with cpt_lf_alloc mailbox
        octeontx2-af: replace cpt slot with lf id on reg write
        i40e: fix: remove needless retries of NVM update
        net: ethtool: Fix RSS setting
      528dd46d
    • Michael Chan's avatar
      bnxt_en: Fix crash in bnxt_get_max_rss_ctx_ring() · f7ce5eb2
      Michael Chan authored
      On older chips not supporting multiple RSS contexts, reducing
      ethtool channels will crash:
      
      BUG: kernel NULL pointer dereference, address: 00000000000000b8
      PGD 0 P4D 0
      Oops: Oops: 0000 [#1] PREEMPT SMP PTI
      CPU: 1 PID: 7032 Comm: ethtool Tainted: G S                 6.10.0-rc4 #1
      Hardware name: Dell Inc. PowerEdge R730/072T6D, BIOS 2.4.3 01/17/2017
      RIP: 0010:bnxt_get_max_rss_ctx_ring+0x4c/0x90 [bnxt_en]
      Code: c3 d3 eb 4c 8b 83 38 01 00 00 48 8d bb 38 01 00 00 4c 39 c7 74 42 41 8d 54 24 ff 31 c0 0f b7 d2 4c 8d 4c 12 02 66 85 ed 74 1d <49> 8b 90 b8 00 00 00 49 8d 34 11 0f b7 0a 66 39 c8 0f 42 c1 48 83
      RSP: 0018:ffffaaa501d23ba8 EFLAGS: 00010202
      RAX: 0000000000000000 RBX: ffff8efdf600c940 RCX: 0000000000000000
      RDX: 000000000000007f RSI: ffffffffacf429c4 RDI: ffff8efdf600ca78
      RBP: 0000000000000080 R08: 0000000000000000 R09: 0000000000000100
      R10: 0000000000000001 R11: ffffaaa501d238c0 R12: 0000000000000080
      R13: 0000000000000000 R14: ffff8efdf600c000 R15: 0000000000000006
      FS:  00007f977a7d2740(0000) GS:ffff8f041f840000(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      CR2: 00000000000000b8 CR3: 00000002320aa004 CR4: 00000000003706f0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      Call Trace:
      <TASK>
      ? __die_body+0x15/0x60
      ? page_fault_oops+0x157/0x440
      ? do_user_addr_fault+0x60/0x770
      ? _raw_spin_lock_irqsave+0x12/0x40
      ? exc_page_fault+0x61/0x120
      ? asm_exc_page_fault+0x22/0x30
      ? bnxt_get_max_rss_ctx_ring+0x4c/0x90 [bnxt_en]
      ? bnxt_get_max_rss_ctx_ring+0x25/0x90 [bnxt_en]
      bnxt_set_channels+0x9d/0x340 [bnxt_en]
      ethtool_set_channels+0x14b/0x210
      __dev_ethtool+0xdf8/0x2890
      ? preempt_count_add+0x6a/0xa0
      ? percpu_counter_add_batch+0x23/0x90
      ? filemap_map_pages+0x417/0x4a0
      ? avc_has_extended_perms+0x185/0x420
      ? __pfx_udp_ioctl+0x10/0x10
      ? sk_ioctl+0x55/0xf0
      ? kmalloc_trace_noprof+0xe0/0x210
      ? dev_ethtool+0x54/0x170
      dev_ethtool+0xa2/0x170
      dev_ioctl+0xbe/0x530
      sock_do_ioctl+0xa3/0xf0
      sock_ioctl+0x20d/0x2e0
      
      bp->rss_ctx_list is not initialized if the chip or firmware does not
      support multiple RSS contexts.  Fix it by adding a check in
      bnxt_get_max_rss_ctx_ring() before proceeding to reference
      bp->rss_ctx_list.
      
      Fixes: 0d1b7d6c ("bnxt: fix crashes when reducing ring count with active RSS contexts")
      Reported-by: default avatarBreno Leitao <leitao@debian.org>
      Link: https://lore.kernel.org/netdev/ZpFEJeNpwxW1aW9k@gmail.com/Reviewed-by: default avatarAndy Gospodarek <andrew.gospodarek@broadcom.com>
      Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
      Link: https://patch.msgid.link/20240712175318.166811-1-michael.chan@broadcom.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      f7ce5eb2
  2. 12 Jul, 2024 25 commits
  3. 11 Jul, 2024 9 commits
    • Wolfram Sang's avatar
      i2c: rcar: ensure Gen3+ reset does not disturb local targets · ea5ea84c
      Wolfram Sang authored
      R-Car Gen3+ needs a reset before every controller transfer. That erases
      configuration of a potentially in parallel running local target
      instance. To avoid this disruption, avoid controller transfers if a
      local target is running. Also, disable SMBusHostNotify because it
      requires being a controller and local target at the same time.
      
      Fixes: 3b770017 ("i2c: rcar: handle RXDMA HW behaviour on Gen3")
      Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
      Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
      ea5ea84c
    • Linus Torvalds's avatar
      Merge tag 'for-6.10/dm-fixes-2' of... · 43db1e03
      Linus Torvalds authored
      Merge tag 'for-6.10/dm-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm
      
      Pull device mapper fix from Mikulas Patocka:
      
       - Fix broken discard for device mapper VDO target
      
      * tag 'for-6.10/dm-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm:
        dm vdo: replace max_discard_sectors with max_hw_discard_sectors
      43db1e03
    • Bruce Johnston's avatar
      dm vdo: replace max_discard_sectors with max_hw_discard_sectors · d5cfecfe
      Bruce Johnston authored
      Commit 4f563a64 ("block: add a max_user_discard_sectors queue
      limit") changed block core to set max_discard_sectors to:
      min(lim->max_hw_discard_sectors, lim->max_user_discard_sectors)
      
      Commit 825d8bbd ("dm: always manage discard support in terms
      of max_hw_discard_sectors") fixed most dm targetss to deal with
      this, by replacing max_discard_sectors with max_hw_discard_sectors.
      Unfortunately, dm-vdo did not get fixed at that time.
      
      Fixes: 825d8bbd ("dm: always manage discard support in terms of max_hw_discard_sectors")
      Signed-off-by: default avatarBruce Johnston <bjohnsto@redhat.com>
      Signed-off-by: default avatarMatthew Sakai <msakai@redhat.com>
      Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
      d5cfecfe
    • Linus Torvalds's avatar
      Merge tag 'spi-fix-v6.10-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi · 8a18fda0
      Linus Torvalds authored
      Pull spi fixes from Mark Brown:
       "This fixes two regressions that have been bubbling along for a large
        part of this release.
      
        One is a revert of the multi mode support for the OMAP SPI controller,
        this introduced regressions on a number of systems and while there has
        been progress on fixing those we've not got something that works for
        everyone yet so let's just drop the change for now.
      
        The other is a series of fixes from David Lechner for his recent
        message optimisation work, this interacted badly with spi-mux which
        is altogether too clever with recursive use of the bus and creates
        situations that hadn't been considered.
      
        There are also a couple of small driver specific fixes, including one
        more patch from David for sleep duration calculations in the AXI
        driver"
      
      * tag 'spi-fix-v6.10-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
        spi: mux: set ctlr->bits_per_word_mask
        spi: add defer_optimize_message controller flag
        spi: don't unoptimize message in spi_async()
        spi: omap2-mcspi: Revert multi mode support
        spi: davinci: Unset POWERDOWN bit when releasing resources
        spi: axi-spi-engine: fix sleep calculation
        spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices
      8a18fda0
    • Linus Torvalds's avatar
      Merge tag 'net-6.10-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 51df8e0c
      Linus Torvalds authored
      Pull networking fixes from Paolo Abeni:
       "Including fixes from bpf and netfilter.
      
        Current release - regressions:
      
         - core: fix rc7's __skb_datagram_iter() regression
      
        Current release - new code bugs:
      
         - eth: bnxt: fix crashes when reducing ring count with active RSS
           contexts
      
        Previous releases - regressions:
      
         - sched: fix UAF when resolving a clash
      
         - skmsg: skip zero length skb in sk_msg_recvmsg2
      
         - sunrpc: fix kernel free on connection failure in
           xs_tcp_setup_socket
      
         - tcp: avoid too many retransmit packets
      
         - tcp: fix incorrect undo caused by DSACK of TLP retransmit
      
         - udp: Set SOCK_RCU_FREE earlier in udp_lib_get_port().
      
         - eth: ks8851: fix deadlock with the SPI chip variant
      
         - eth: i40e: fix XDP program unloading while removing the driver
      
        Previous releases - always broken:
      
         - bpf:
             - fix too early release of tcx_entry
             - fail bpf_timer_cancel when callback is being cancelled
             - bpf: fix order of args in call to bpf_map_kvcalloc
      
         - netfilter: nf_tables: prefer nft_chain_validate
      
         - ppp: reject claimed-as-LCP but actually malformed packets
      
         - wireguard: avoid unaligned 64-bit memory accesses"
      
      * tag 'net-6.10-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (33 commits)
        net, sunrpc: Remap EPERM in case of connection failure in xs_tcp_setup_socket
        net/sched: Fix UAF when resolving a clash
        net: ks8851: Fix potential TX stall after interface reopen
        udp: Set SOCK_RCU_FREE earlier in udp_lib_get_port().
        netfilter: nf_tables: prefer nft_chain_validate
        netfilter: nfnetlink_queue: drop bogus WARN_ON
        ethtool: netlink: do not return SQI value if link is down
        ppp: reject claimed-as-LCP but actually malformed packets
        selftests/bpf: Add timer lockup selftest
        net: ethernet: mtk-star-emac: set mac_managed_pm when probing
        e1000e: fix force smbus during suspend flow
        tcp: avoid too many retransmit packets
        bpf: Defer work in bpf_timer_cancel_and_free
        bpf: Fail bpf_timer_cancel when callback is being cancelled
        bpf: fix order of args in call to bpf_map_kvcalloc
        net: ethernet: lantiq_etop: fix double free in detach
        i40e: Fix XDP program unloading while removing the driver
        net: fix rc7's __skb_datagram_iter()
        net: ks8851: Fix deadlock with the SPI chip variant
        octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability()
        ...
      51df8e0c
    • Linus Torvalds's avatar
      Merge tag 'vfs-6.10-rc8.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs · 83ab4b46
      Linus Torvalds authored
      Pull vfs fixes from Christian Brauner:
       "cachefiles:
      
         - Export an existing and add a new cachefile helper to be used in
           filesystems to fix reference count bugs
      
         - Use the newly added fscache_ty_get_volume() helper to get a
           reference count on an fscache_volume to handle volumes that are
           about to be removed cleanly
      
         - After withdrawing a fscache_cache via FSCACHE_CACHE_IS_WITHDRAWN
           wait for all ongoing cookie lookups to complete and for the object
           count to reach zero
      
         - Propagate errors from vfs_getxattr() to avoid an infinite loop in
           cachefiles_check_volume_xattr() because it keeps seeing ESTALE
      
         - Don't send new requests when an object is dropped by raising
           CACHEFILES_ONDEMAND_OJBSTATE_DROPPING
      
         - Cancel all requests for an object that is about to be dropped
      
         - Wait for the ondemand_boject_worker to finish before dropping a
           cachefiles object to prevent use-after-free
      
         - Use cyclic allocation for message ids to better handle id recycling
      
         - Add missing lock protection when iterating through the xarray when
           polling
      
        netfs:
      
         - Use standard logging helpers for debug logging
      
        VFS:
      
         - Fix potential use-after-free in file locks during
           trace_posix_lock_inode(). The tracepoint could fire while another
           task raced it and freed the lock that was requested to be traced
      
         - Only increment the nr_dentry_negative counter for dentries that are
           present on the superblock LRU. Currently, DCACHE_LRU_LIST list is
           used to detect this case. However, the flag is also raised in
           combination with DCACHE_SHRINK_LIST to indicate that dentry->d_lru
           is used. So checking only DCACHE_LRU_LIST will lead to wrong
           nr_dentry_negative count. Fix the check to not count dentries that
           are on a shrink related list
      
        Misc:
      
         - hfsplus: fix an uninitialized value issue in copy_name
      
         - minix: fix minixfs_rename with HIGHMEM. It still uses kunmap() even
           though we switched it to kmap_local_page() a while ago"
      
      * tag 'vfs-6.10-rc8.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs:
        minixfs: Fix minixfs_rename with HIGHMEM
        hfsplus: fix uninit-value in copy_name
        vfs: don't mod negative dentry count when on shrinker list
        filelock: fix potential use-after-free in posix_lock_inode
        cachefiles: add missing lock protection when polling
        cachefiles: cyclic allocation of msg_id to avoid reuse
        cachefiles: wait for ondemand_object_worker to finish when dropping object
        cachefiles: cancel all requests for the object that is being dropped
        cachefiles: stop sending new request when dropping object
        cachefiles: propagate errors from vfs_getxattr() to avoid infinite loop
        cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie()
        cachefiles: fix slab-use-after-free in fscache_withdraw_volume()
        netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume()
        netfs: Switch debug logging to pr_debug()
      83ab4b46
    • Bastien Curutchet's avatar
      mmc: davinci_mmc: Prevent transmitted data size from exceeding sgm's length · 16198eef
      Bastien Curutchet authored
      No check is done on the size of the data to be transmiited. This causes
      a kernel panic when this size exceeds the sg_miter's length.
      
      Limit the number of transmitted bytes to sgm->length.
      
      Cc: stable@vger.kernel.org
      Fixes: ed01d210 ("mmc: davinci_mmc: Use sg_miter for PIO")
      Signed-off-by: default avatarBastien Curutchet <bastien.curutchet@bootlin.com>
      Link: https://lore.kernel.org/r/20240711081838.47256-2-bastien.curutchet@bootlin.comSigned-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
      16198eef
    • Adrian Hunter's avatar
      mmc: sdhci: Fix max_seg_size for 64KiB PAGE_SIZE · 63d20a94
      Adrian Hunter authored
      blk_queue_max_segment_size() ensured:
      
      	if (max_size < PAGE_SIZE)
      		max_size = PAGE_SIZE;
      
      whereas:
      
      blk_validate_limits() makes it an error:
      
      	if (WARN_ON_ONCE(lim->max_segment_size < PAGE_SIZE))
      		return -EINVAL;
      
      The change from one to the other, exposed sdhci which was setting maximum
      segment size too low in some circumstances.
      
      Fix the maximum segment size when it is too low.
      
      Fixes: 616f8766 ("mmc: pass queue_limits to blk_mq_alloc_disk")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      Acked-by: default avatarJon Hunter <jonathanh@nvidia.com>
      Tested-by: default avatarJon Hunter <jonathanh@nvidia.com>
      Link: https://lore.kernel.org/r/20240710180737.142504-1-adrian.hunter@intel.comSigned-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
      63d20a94
    • Takashi Iwai's avatar
      Merge tag 'asoc-fix-v6.10-rc7' of... · f19e1027
      Takashi Iwai authored
      Merge tag 'asoc-fix-v6.10-rc7' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus
      
      ASoC: Fixes for v6.10
      
      A few fairly small fixes for ASoC, there's a relatively large set of
      hardening changes for the cs_dsp firmware file parsing and a couple of
      other small device specific fixes.
      f19e1027