- 31 Jul, 2018 4 commits
-
-
Jia-Ju Bai authored
mpt_attach() and mptfc_probe() are never called in atomic context. They call kzalloc() and kcalloc() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by:
Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Colin Ian King authored
The null checks on nvmebuf are redundant as nvmebuf is always obtained from a container_of() and hence can never be null. Remove all the redundant null checks. This also cleans up a static analysis warning. Detected by CoverityScan, CID#1471753 ("Dereference before null check") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Dominique Martinet authored
Generated by scripts/coccinelle/misc/strncpy_truncation.cocci Signed-off-by:
Dominique Martinet <asmadeus@codewreck.org> Signed-off-by:
-
Dominique Martinet authored
Generated by scripts/coccinelle/misc/strncpy_truncation.cocci Signed-off-by:
-
- 20 Jul, 2018 14 commits
-
-
Xiang Chen authored
Add a check ERR bit of status to decide whether there is something wrong with initial register-D2H FIS. If error exist, PHY link reset the channel to restart OOB. Directly call work HISI_PHYE_LINK_RESET replacing disable_phy_vx_hw() and enable_phy_vx_hw(). Signed-off-by:
Xiang Chen <chenxiang66@hisilicon.com> Signed-off-by:
John Garry <john.garry@huawei.com> Signed-off-by:
-
Xiaofei Tan authored
In task start delivery function, we need to add a memory barrier to prevent re-ordering of reading memory by hardware. Because the slot data is set in task prepare function and it could be running in another CPU. This patch adds an memory barrier after s->ready is read in the task start delivery function, and uses WRITE_ONCE() in the places where s->ready is set to ensure that the compiler does not re-order. Signed-off-by:
Xiaofei Tan <tanxiaofei@huawei.com> Signed-off-by:
-
Xiang Chen authored
To decrease the usage of spinlock during delivery IO, relocate some code in hisi_sas_task_prep(). Also an invalid comment is removed. Signed-off-by:
-
Xiaofei Tan authored
This patch implements handlers of PCIe FLR for v3 hw, reset_prepare() and reset_done(). User can issue FLR through sysfs interface, as v3 hw support PCIe FLR. Then if we don't implement these two handlers, our SAS controller will not work after executing FLR. Signed-off-by:
-
Xiaofei Tan authored
Much code of PM suspend function also exists in soft reset function. This is not concise. So, this patch relocates the common code of these two functions to a separate function. Signed-off-by:
-
Xiaofei Tan authored
This patch tidies host controller reset function by putting some code to two new functions, and exports these two functions out, so that they could be used by FLR feature to be realised. Signed-off-by:
-
Xiaofei Tan authored
There is an issue that link reset can't recover PHY when STP link timeout. Because current process of enabling PHY for v3 hw will wait last transmission done. The time of one transmission depends IO size, disk model and so on. Normally, it should be shorter than 50ms. But the last transmission could be never done for some abnormal scenarios, such as STP link timeout. This patch is to fix the issue. Check PHY status after starting process of enabling PHY for 50ms. If the PHY is still active, we disable it forcibly by PHY reset. Of course, we need to clear the PHY reset bit when enable PHY. Besides, the function disable_phy_v3_hw() should not be suitable to call in interrupts for hilink bug for this 50ms delay. Then, we do link reset for hilink bug directly. The change is that we don't clear the invalid dword count register. This is better. Because we should not clear such error count while not saved. Signed-off-by:
-
Xiaofei Tan authored
The ISR of channel interrupt of v3 hw is a little long and messy. This patch tidies it by relocating CHL_INT1 and CHL_INT2 handling to new function separately. Signed-off-by:
-
John Garry authored
For some time now we have not used hisi_sas_slot_abort() to handle erroring slots, apart from in archaic v1 hw. As such, remove this function and associated code. For v1 hw, move error handling to same scheme as other hw revisions, where we allow erroring commands to timeout. Signed-off-by:
-
Varun Prakash authored
T5/T6 can have different pack and pad boundary value. This patch sets packing boundary based on cache line size and PCI-E maximum payload size and sets smallest padding boundary value. Signed-off-by:
Varun Prakash <varun@chelsio.com> Signed-off-by:
-
liwei authored
Signed-off-by:
Li Wei <liwei213@huawei.com> Signed-off-by:
Zhangfei Gao <zhangfei.gao@linaro.org> Signed-off-by:
Guodong Xu <guodong.xu@linaro.org> Tested-by:
John Stultz <john.stultz@linaro.org> Signed-off-by:
-
liwei authored
arm64: dts: add ufs node for Hisilicon. Signed-off-by:
Rob Herring <robh@kernel.org> Tested-by:
Wei Xu <xuwei5@hisilicon.com> Signed-off-by:
-
liwei authored
add ufs node document for Hisilicon. Signed-off-by:
-
liwei authored
add Hisilicon ufs driver code. Signed-off-by:
Geng Jianfeng <gengjianfeng@hisilicon.com> Signed-off-by:
Zang Leigang <zangleigang@hisilicon.com> Signed-off-by:
Yu Jianfeng <steven.yujianfeng@hisilicon.com> Tested-by:
-
- 13 Jul, 2018 9 commits
-
-
Douglas Gilbert authored
A test program's runtime became impractically long since any non zero ndelay (e.g. 1 nanosec) caused Start Stop Unit to delay over 8 magnitudes greater than other commands. This patch skips long delays (on Start Stop Unit and Synchronize Cache) if ndelay is less than or equal to 10 microsecs. Signed-off-by:
Douglas Gilbert <dgilbert@interlog.com> Signed-off-by:
-
Arnd Bergmann authored
We don't want to use 'struct timespec' because of the y2038 overflow problem. The overflow is not actually an issue here, but it's easy to replace with 'timespec64' for consistency. However, it's worth pointing out that nanosecond values have nine digits, not eight or ten, so I'm fixing the format strings accordingly as well. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Hannes Reinecke authored
When calling either fc_rport_logon() or fc_rport_logoff() during rport list traversal we cannot use the RCU list traversal, as either of these functions will be taking a mutex. So we need to partially revert commit a407c593 to take the disc mutex during traversal. We should, however, continue to use krefs to ensure that the rport object will not be freed from under us. Fixes: a407c593 ("scsi: libfc: Fixup disc_mutex handling") Signed-off-by:
Hannes Reinecke <hare@suse.com> Reviewed-by:
Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by:
-
Hannes Reinecke authored
The discovery rport list handling is quite odd; the list traversal is independent from the lifetime of the rport itself. This makes auditing quite tricky, and the chance remains that we've missed something. So this patch adds a WARN_ON() statement when freeing an rport which is still part of a list. Signed-off-by:
-
Hannes Reinecke authored
fc_disc_stop_rports() is calling fc_rport_logoff(), which in turn is acquiring the rport mutex. So we cannot use RCU list traversal here, but rather need to hold the disc mutex to avoid list corruption while traversing. Fixes: a407c593 ("scsi: libfc: Fixup disc_mutex handling") Signed-off-by:
-
Hannes Reinecke authored
fc_rport_recv_plogi_req() needs the lport mutex to be held; the rport mutex will be acquired in the function itself. Fixes: ee35624e ("scsi: libfc: Add lockdep annotations") Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
Chaitra P B authored
Commit cf6bf971 ("scsi: mpt3sas: Bug fix for big endian systems") was merged to address sparse warnings. However, the patch introduced a regression on big endian since the code accidentally mixed I/O memory accessors, which do endian swaps, and regular CPU loads and stores. Do a partial revert of the offending commit. [mkp: replaced commit message] Signed-off-by:
Chaitra P B <chaitra.basappa@broadcom.com> Signed-off-by:
-
Ching Huang authored
Update driver version to v1.40.00.09-20180709 Signed-off-by:
Ching Huang <ching2048@areca.com.tw> Signed-off-by:
-
Ching Huang authored
Fix error of resuming from hibernation for adapter type E. Signed-off-by:
-
- 11 Jul, 2018 13 commits
-
-
Johannes Thumshirn authored
The NCR QUAD 720 SCSI driver depends on microchannel support, but microchannel support was removed from the kernel with commit bb8187d3 ("MCA: delete all remaining traces of microchannel bus support.") over 6 years ago. So zap the Q720 SCSI driver as well. Signed-off-by:
James E.J. Bottomley <James.Bottomley@HansenPartnership.com> Signed-off-by:
-
Johannes Thumshirn authored
The NCR DUAL 700 SCSI driver depends on microchannel support, but microchannel support was removed from the kernel with commit bb8187d3 ("MCA: delete all remaining traces of microchannel bus support.") over 6 years ago. So zap the D700 SCSI driver as well. Signed-off-by:
-
Johannes Thumshirn authored
Remove the ScsiResult macro and open code it on all call sites. This will make subsequent refactoring in this area easier. Signed-off-by:
-
Johannes Thumshirn authored
Remove the ScsiResult macro and open code it on all call sites. This will make subsequent refactoring in this area easier. Signed-off-by:
Bart Van Assche <bart.vanassche@wdc.com> Signed-off-by:
-
Johannes Thumshirn authored
Remove the ScsiResult macro and open code it on all call sites. This will make subsequent refactoring in this area easier. Signed-off-by:
-
Johannes Thumshirn authored
Remove the AAC_STAT_GOOD definition and open code it in the places it was used. This will make subsequent refactoring in this area easier. Signed-off-by:
Dave Carroll <david.carroll@microsemi.com> Signed-off-by:
-
Hannes Reinecke authored
fc_rport_login() will be calling mutex_lock() while running inside an RCU-protected section, triggering the warning 'sleeping function called from invalid context'. To fix this we can drop the rcu functions here altogether as the disc mutex protecting the list itself is already held, preventing any list manipulation. Fixes: a407c593 ("scsi: libfc: Fixup disc_mutex handling") Signed-off-by:
Johannes Thumshirn <jth@kernel.org> Signed-off-by:
-
Hannes Reinecke authored
Convert the free text locking notes into proper lockdep annotations. Signed-off-by:
-
Johannes Thumshirn authored
It has been more than one year since we tried to change the default from legacy to multi queue in SCSI with commit c279bd9e406 ("scsi: default to scsi-mq"). But due to issues with suspend/resume and performance problems it had been reverted again with commit cbe7dfa2 ("Revert "scsi: default to scsi-mq""). In the meantime there have been a substantial amount of performance improvements and suspend/resume got fixed as well, thus we can re-enable scsi-mq without a significant performance penalty. Signed-off-by:Ming Lei <ming.lei@redhat.com> Acked-by:
-
Gustavo A. R. Silva authored
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 2 was used: -Wimplicit-fallthrough=2 Signed-off-by:
Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by:
-
Arnd Bergmann authored
The target core runs into a warning in the linux/sbitmap.h file in some configurations: In file included from include/target/target_core_base.h:7, from drivers/target/target_core_fabric_lib.c:41: include/linux/sbitmap.h:331:46: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] void sbitmap_show(struct sbitmap *sb, struct seq_file *m); ^~~~~~~~ In general, headers should not depend on others being included first, so this fixes it with a forward declaration for that struct name, but we probably want to merge the patch through the scsi tree to help bisection. Fixes: 10e9cbb6 ("scsi: target: Convert target drivers to use sbitmap") Signed-off-by:Omar Sandoval <osandov@fb.com> Reviewed-by:
Jens Axboe <axboe@kernel.dk> Signed-off-by:
-
James Smart authored
Change references from "Broadcom Limited" to "Broadcom Inc." in the copyright message. Update copyright duration if not yet updated for 2018. Signed-off-by:
Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by:
James Smart <james.smart@broadcom.com> Signed-off-by:
-
James Smart authored
Update the driver version to 12.0.0.5 Signed-off-by:
-
