- 11 Mar, 2022 6 commits
-
-
Youghandhar Chintala authored
Currently in case of target hardware restart, we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted. Many ath10k wifi chipsets have sequence numbers for the data packets assigned by firmware and the mac sequence number will restart from zero after target hardware restart leading to mismatch in the sequence number expected by the remote peer vs the sequence number of the frame sent by the target firmware. This mismatch in sequence number will cause out-of-order packets on the remote peer and all the frames sent by the device are dropped until we reach the sequence number which was sent before we restarted the target hardware In order to fix this, we trigger a sta disconnect, in case of target hw restart. After this there will be a fresh connection and thereby avoiding the dropping of frames by remote peer. The right fix would be to pull the entire data path into the host which is not feasible or would need lots of complex changes and will still be inefficient. Tested on ath10k using WCN3990, QCA6174 Signed-off-by:
Youghandhar Chintala <youghand@codeaurora.org> Link: https://lore.kernel.org/r/20220308115325.5246-2-youghand@codeaurora.orgSigned-off-by:
Johannes Berg <johannes.berg@intel.com>
-
Linus Lüssing authored
While commit 6a01afcf ("mac80211: mesh: Free ie data when leaving mesh") fixed a memory leak on mesh leave / teardown it introduced a potential memory corruption caused by a double free when rejoining the mesh: ieee80211_leave_mesh() -> kfree(sdata->u.mesh.ie); ... ieee80211_join_mesh() -> copy_mesh_setup() -> old_ie = ifmsh->ie; -> kfree(old_ie); This double free / kernel panics can be reproduced by using wpa_supplicant with an encrypted mesh (if set up without encryption via "iw" then ifmsh->ie is always NULL, which avoids this issue). And then calling: $ iw dev mesh0 mesh leave $ iw dev mesh0 mesh join my-mesh Note that typically these commands are not used / working when using wpa_supplicant. And it seems that wpa_supplicant or wpa_cli are going through a NETDEV_DOWN/NETDEV_UP cycle between a mesh leave and mesh join where the NETDEV_UP resets the mesh.ie to NULL via a memcpy of default_mesh_setup in cfg80211_netdev_notifier_call, which then avoids the memory corruption, too. The issue was first observed in an application which was not using wpa_supplicant but "Senf" instead, which implements its own calls to nl80211. Fixing the issue by removing the kfree()'ing of the mesh IE in the mesh join function and leaving it solely up to the mesh leave to free the mesh IE. Cc: stable@vger.kernel.org Fixes: 6a01afcf ("mac80211: mesh: Free ie data when leaving mesh") Reported-by:
Matthias Kretschmer <mathias.kretschmer@fit.fraunhofer.de> Signed-off-by:
Linus Lüssing <ll@simonwunderlich.de> Tested-by:
-
MeiChia Chiu authored
There are no legacy rates on 60GHz or sub-1GHz band, so modify the check. Signed-off-by:
Ryder Lee <ryder.lee@mediatek.com> Signed-off-by:
MeiChia Chiu <MeiChia.Chiu@mediatek.com> Link: https://lore.kernel.org/r/20220308021645.16272-1-MeiChia.Chiu@mediatek.com [Ghz -> GHz] Signed-off-by:
-
Veerendranath Jakkam authored
It should be NL80211_IFTYPE_OCB instead. Signed-off-by:
Veerendranath Jakkam <quic_vjakkam@quicinc.com> Link: https://lore.kernel.org/r/1645542399-4680-1-git-send-email-quic_vjakkam@quicinc.comSigned-off-by:
-
Christophe JAILLET authored
Previous memory allocations in this function already use GFP_KERNEL, so use __dev_alloc_skb() and an explicit GFP_KERNEL instead of an implicit GFP_ATOMIC. This gives more opportunities of successful allocation. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/194a0e2ff00c3fae88cc9fba47431747360c8242.1645345378.git.christophe.jaillet@wanadoo.frSigned-off-by:
-
Yihao Han authored
Fix the following coccicheck warning: ./drivers/net/wireless/mac80211_hwsim.c:1040:0-23: WARNING: hwsim_fops_rx_rssi should be defined with DEFINE_DEBUGFS_ATTRIBUTE Signed-off-by:
Yihao Han <hanyihao@vivo.com> Link: https://lore.kernel.org/r/20220218070228.6210-1-hanyihao@vivo.com [fix indentation] Signed-off-by:
-
- 10 Mar, 2022 34 commits
-
-
git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.gitKalle Valo authored
ath.git patches for v5.18. Major changes: ath6kl * add device ID for WLU5150-D81
-
Kalle Valo authored
Merge tag 'iwlwifi-next-for-kalle-2022-03-10' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next iwlwifi patches for v5.18 * Mostly debugging infra changes; * Some more work on the Bz family of devices; * Bump the FW API twice; * Some other small fixes, clean-ups and improvements.
-
Ping-Ke Shih authored
Add a struct to access logic efuse map, and fill data according to the map. Signed-off-by:
Ping-Ke Shih <pkshih@realtek.com> Signed-off-by:
Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20220307060457.56789-14-pkshih@realtek.com
-
Ping-Ke Shih authored
Read phycap data programmed in efuse, and store them into array. Signed-off-by:
-
Ping-Ke Shih authored
DAV is an another efuse region that new chip, like 8852C, has this region. Extend the code to read it, and convert the physical map to logical map followed by original logical map. Signed-off-by:
-
Ping-Ke Shih authored
These tables are used to configure hardware buffer size according to operating mode. Signed-off-by:
-
Ping-Ke Shih authored
These registers are used to configure and access page size of HCI. Signed-off-by:
-
Ping-Ke Shih authored
This is a register-based H2C/C2H interface to exchange data with firmware. Since the register addresses of 8852A and 8852C are different, add fields to chip_info to support this. Signed-off-by:
-
Ping-Ke Shih authored
The HCI_FUNC_EN address of 8852C is different from existing chipset, so add a chip_info::hci_func_en_addr to fill the address individually. Signed-off-by:
-
Ping-Ke Shih authored
New chipset uses individual power_{on/off} functions to replace old power sequences, because it is hard to represent new complicated flow in a sequence table. Signed-off-by: -
Ping-Ke Shih authored
Only 8852A may get wrong chip version if power isn't on, so it needs additional actions to correct the version. Later chips don't need those. Signed-off-by:
-
Ping-Ke Shih authored
We have had a struct rtw89_pci_ch_dma_addr to describe register address, so use it as regular. Since the addresses should be changed dynamically according to operating mode, I don't change it to be constant. These changes don't affect the logic, so I put them in this separated patch. Signed-off-by:
-
Ping-Ke Shih authored
8852CE use V1 address, and flow is totally shared with 8852AE. Signed-off-by:
-
Ping-Ke Shih authored
Use this struct to implement chip::ops related to PCI interface. Signed-off-by:
-
Ping-Ke Shih authored
Add these files, and then I can add specific chip::ops or chip::info along with the existing chip. Signed-off-by:
-
Lorenzo Bianconi authored
Specify devicetree bindings entry for mt76 driver. Signed-off-by:
Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by:
-
Colin Ian King authored
Don't populate the read-only array pktflags on the stack but instead make it static const. Also makes the object code a little smaller. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Signed-off-by:
-
Lu Jicong authored
This function exists in phy_common.c as '_rtl92c_phy_set_rf_sleep'. Switch to the one in common file. Signed-off-by:
Lu Jicong <jiconglu58@gmail.com> Acked-by:
-
Colin Ian King authored
There are two identical assignments of chip->owner to the same value, the second assignment is redundant and can be removed. Cleans up cppcheck warning: drivers/bcma/driver_gpio.c:184:15: style: Variable 'chip->owner' is reassigned a value before the old one has been used. [redundantAssignment] Signed-off-by:
-
Wang Qing authored
Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by:Wang Qing <wangqing@vivo.com> Signed-off-by:
-
Double Lo authored
These email addresses no longer work, so remove them from MAINTAINERS. Signed-off-by:
Double Lo <Double.Lo@infineon.com> Signed-off-by:
-
Christian Lamparter authored
driver keeps the same survey_info struct for its lifetime around. This is used because while firmware does help by providing accounting information of the current channel, it doesn't keep track on the remaining channels. Signed-off-by:
Christian Lamparter <chunkeey@gmail.com> Signed-off-by:
Kalle Valo <quic_kvalo@quicinc.com> Link: https://lore.kernel.org/r/9b9a059b384f49587f4384ba47f01d3fb2115b22.1646250537.git.chunkeey@gmail.com
-
Christian Lamparter authored
the mem_bitmap is kept around for the lifetime of the driver device. This is a perfect candidate for devm. Signed-off-by:
-
Christian Lamparter authored
devres will take care of freeing the input_device once it is no longer needed. Signed-off-by:
-
Christian Lamparter authored
devres will take care of freeing the hwrng once it is no longer needed. Signed-off-by:
-
Christian Lamparter authored
Since ~2010, the driver is allowed to sleep in the ampdu_action callback thanks to: commit 85ad181e ("mac80211: allow drivers to sleep in ampdu_action") Signed-off-by:
-
Miaoqian Lin authored
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. This function only calls of_node_put() in the regular path. And it will cause refcount leak in error path. Fixes: 727fec79 ("ath10k: Setup the msa resources before qmi init") Signed-off-by:
Miaoqian Lin <linmq006@gmail.com> Reviewed-by:
Jeff Johnson <quic_jjohnson@quicinc.com> Signed-off-by:
-
Lv Ruyi (CGEL ZTE) authored
All work currently pending will be done first by calling destroy_workqueue, so there is no need to flush it explicitly. Reported-by:
Zeal Robot <zealci@zte.com.cn> Signed-off-by:
Lv Ruyi (CGEL ZTE) <lv.ruyi@zte.com.cn> Signed-off-by:
-
André Apitzsch authored
This device with a male Mini-B USB connector is part of Panasonic TVs. Signed-off-by:
André Apitzsch <git@apitzsch.eu> Signed-off-by:
-
Luca Coelho authored
Start supporting API version 72 for AX devices. Signed-off-by:
Luca Coelho <luciano.coelho@intel.com> Link: https://lore.kernel.org/r/iwlwifi.20220304131517.8de72a8ea67f.I66681363afeb34c619379a5989090264fe6b5f2a@changeidSigned-off-by:
-
Matt Chen authored
Move the ppag code to fw/acpi to keep consistency with the other ACPI handling we do. Signed-off-by:
Matt Chen <matt.chen@intel.com> Signed-off-by:
-
Mordechay Goodstein authored
Without trigger data set, no point in any collection. so check that we have the info for collecting the data. Signed-off-by:
Mordechay Goodstein <mordechay.goodstein@intel.com> Signed-off-by:
-
Mordechay Goodstein authored
Today in the code we have two options for collecting data sync/schedule, the two options call the same function and can lead to racing in free resources after done. So we call only one of two sync/schedule, and in case of sync only call sync function without also schedule to immediately run as a side job. Signed-off-by:
-
Johannes Berg authored
There's a hardware bug in Bz A-step that can be worked around by using 4k queue size, so do that. Signed-off-by:
-
