1. 15 Jul, 2011 1 commit
    • Shyam Iyer's avatar
      Separate handling of irq type flags variable from the irq_flags request_irq variable · 8279171a
      Shyam Iyer authored
      Commit 5f77898d does not completely
      fix the problem of handling allocations with irqs disabled..  The
      below patch on top of it fixes the problem completely.
      
      Based on review by "Ivan Vecera" <ivecera@redhat.com>..
      "
      Small note, the root of the problem was that non-atomic allocation was requested with IRQs disabled. Your patch description does not contain wwhy were the IRQs disabled.
      
      The function bnad_mbox_irq_alloc incorrectly uses 'flags' var for two different things, 1) to save current CPU flags and 2) for request_irq
      call.
      First the spin_lock_irqsave disables the IRQs and saves _all_ CPU flags (including one that enables/disables interrupts) to 'flags'. Then the 'flags' is overwritten by 0 or 0x80 (IRQF_SHARED). Finally the spin_unlock_irqrestore should restore saved flags, but these flags are now either 0x00 or 0x80. The interrupt bit value in flags register on x86 arch is 0x100.
      This means that the interrupt bit is zero (IRQs disabled) after spin_unlock_irqrestore so the request_irq function is called with disabled interrupts.
      "
      Signed-off-by: default avatarShyam Iyer <shyam_iyer@dell.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8279171a
  2. 14 Jul, 2011 39 commits