1. 15 Jan, 2014 4 commits
    • Barry Song's avatar
      pinctrl: sirf: use only one irq_domain for the whole device node · 8daeffb0
      Barry Song authored
      in sirfsoc gpio probe(), we create 5 irq_domains for 5 gpio banks. but
      in irq_create_of_mapping() of irqchip core level, irq_find_host() can
      only return the 1st irq_domain attached the pinctrl dt device node as
      we can see from the codes:
      
      unsigned int irq_create_of_mapping(struct device_node *controller,
      				   const u32 *intspec, unsigned int intsize)
      {
      	struct irq_domain *domain;
      	...
      	domain = controller ? irq_find_host(controller) : irq_default_domain;
      }
      
      struct irq_domain *irq_find_host(struct device_node *node)
      {
      	struct irq_domain *h, *found = NULL;
      	int rc;
      
      	/* We might want to match the legacy controller last since
      	 * it might potentially be set to match all interrupts in
      	 * the absence of a device node. This isn't a problem so far
      	 * yet though...
      	 */
      	mutex_lock(&irq_domain_mutex);
      	list_for_each_entry(h, &irq_domain_list, link) {
      		if (h->ops->match)
      			rc = h->ops->match(h, node);
      		else
      			rc = (h->of_node != NULL) && (h->of_node == node);
      
      		if (rc) {
      			found = h;
      			break;
      		}
      	}
      	mutex_unlock(&irq_domain_mutex);
      	return found;
      }
      
      for sirfsoc, the 1st irq_domain attached to the device_node(controller) only
      can do linear for the 1st 32 gpios. so for devices who use gpio hwirq above
      32 and put the information in dt like:
                                      tangoc-ts@5c{
                                              compatible = "pixcir,tangoc-ts";
      +                                       interrupt-parent = <&gpio>;
      +                                       interrupts = <34 0>;
                                      };
      
      we will fail to get the virq for these devices as hwirq will be bigger than
      domain->revmap_data.linear.size in:
      unsigned int irq_linear_revmap(struct irq_domain *domain,
      			       irq_hw_number_t hwirq)
      {
      
      	/* Check revmap bounds; complain if exceeded */
      	if (WARN_ON(hwirq >= domain->revmap_data.linear.size))
      		return 0;
      
      	return domain->revmap_data.linear.revmap[hwirq];
      }
      
      this patch drops redundant irq_domain and keep only one to fix the problem.
      Signed-off-by: default avatarBarry Song <Baohua.Song@csr.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      8daeffb0
    • Tomi Valkeinen's avatar
      pinctrl: single: fix infinite loop caused by bad mask · ad5d25fe
      Tomi Valkeinen authored
      commit 4e7e8017 (pinctrl: pinctrl-single:
      enhance to configure multiple pins of different modules) improved
      support for pinctrl-single,bits option, but also caused a regression
      in parsing badly configured mask data.
      
      If the masks in DT data are not quite right,
      pcs_parse_bits_in_pinctrl_entry() can end up in an infinite loop,
      trashing memory at the same time.
      
      Add a check to verify that each loop actually removes bits from the
      'mask', so that the loop can eventually end.
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      Acked-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      ad5d25fe
    • Tomi Valkeinen's avatar
      pinctrl: single: fix pcs_disable with bits_per_mux · dd4c2b3c
      Tomi Valkeinen authored
      pcs_enable() uses vals->mask instead of pcs->fmask when bits_per_mux is
      enabled. However, pcs_disable() always uses pcs->fmask.
      
      Fix pcs_disable() to use vals->mask with bits_per_mux.
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
      Acked-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      dd4c2b3c
    • Tomi Valkeinen's avatar
      pinctrl: single: fix DT bindings documentation · 2bce6954
      Tomi Valkeinen authored
      Remove extra comma in pinctrl-single documentation.
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      Acked-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      2bce6954
  2. 14 Jan, 2014 1 commit
  3. 08 Jan, 2014 5 commits
  4. 07 Jan, 2014 4 commits
  5. 20 Dec, 2013 5 commits
  6. 16 Dec, 2013 8 commits
  7. 13 Dec, 2013 2 commits
  8. 12 Dec, 2013 11 commits