- 10 Aug, 2023 1 commit
-
-
Asmaa Mnebhi authored
Enable reading and writing the size of the memory region associated with the large ICM carveout. The max size of the large ICM carveout is 1TB, has a granularity of 128MB and will be passed and printed in hex. The size unit is MB. Signed-off-by:
Asmaa Mnebhi <asmaa@nvidia.com> Reviewed-by:
Vadim Pasternak <vadimp@nvidia.com> Link: https://lore.kernel.org/r/20230809162857.21243-2-asmaa@nvidia.comSigned-off-by:
Hans de Goede <hdegoede@redhat.com>
-
- 09 Aug, 2023 1 commit
-
-
Armin Wolf authored
If a duplicate attribute is found using kset_find_obj(), a reference to that attribute is returned. This means that we need to dispose it accordingly. Use kobject_put() to dispose the duplicate attribute in such a case. Compile-tested only. Fixes: e8a60aa7 ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems") Signed-off-by:
Armin Wolf <W_Armin@gmx.de> Link: https://lore.kernel.org/r/20230805053610.7106-1-W_Armin@gmx.deReviewed-by:
-
- 07 Aug, 2023 9 commits
-
-
Li Zetao authored
There are some warnings reported by coccinelle: ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:317:35-42: WARNING opportunity for kmemdup ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:270:40-47: WARNING opportunity for kmemdup ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:233:36-43: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation. Signed-off-by:
Li Zetao <lizetao1@huawei.com> Reviewed-by:
Jorge Lopez <jorge.lopez2@hp.com> Link: https://lore.kernel.org/r/20230803032027.3044851-1-lizetao1@huawei.comReviewed-by:
-
Jorge Lopez authored
Replace use of same variable in inner loop. Signed-off-by:
-
Jorge Lopez authored
Update steps how password encoding size is evaluated Signed-off-by:
-
Jorge Lopez authored
Updates steps how enum possible values size is evaluated Signed-off-by:
-
Jorge Lopez authored
Update steps how order list size is evaluated Signed-off-by:
-
Jorge Lopez authored
Update steps taken to evaluate prerequisites size value Signed-off-by:
-
Jorge Lopez authored
Replace the word 'HACK' with 'step' from source code Signed-off-by:
-
Jorge Lopez authored
Fix uninitialized variable errors. Signed-off-by:
-
Jorge Lopez authored
Address memory leaks while handling elements in packages. Signed-off-by:
-
- 31 Jul, 2023 11 commits
-
-
Armin Wolf authored
The WMI Binary MOF driver is important for the development of modern WMI drivers, i am willing to maintain it. Also fix the mailing list address. Signed-off-by:
-
Armin Wolf authored
Replace offset handling code with a single call to memory_read_from_buffer() to simplify read_bmof(). Tested on a ASUS PRIME B650-PLUS. Reviewed-by:
Thomas Weißschuh <linux@weissschuh.net> Tested-by:
-
Armin Wolf authored
Use device_create_bin_file() instead of sysfs_create_bin_file() to avoid having to access the device kobject. Tested on a ASUS PRIME B650-PLUS. Reviewed-by:
-
Hans de Goede authored
Immutable branch between pdx86 simatic branch and LED due for the v6.6 merge window ib-pdx86-simatic-v6.6-2: v6.5-rc1 + ib-pdx86-simatic-v6.6 + more recent pdx86 simatic-ipc patches for merging into the LED subsystem for v6.6.
-
xingtong.wu authored
This is used for the Siemens Simatic IPC BX-59A, which can monitor the voltage of the CMOS battery with two bits that indicate low or empty state Signed-off-by:
xingtong.wu <xingtong.wu@siemens.com> Link: https://lore.kernel.org/r/20230731072148.4781-1-xingtong_wu@163.comReviewed-by:
-
xingtong.wu authored
This adds support for the Siemens Simatic IPC models BX-56A/BX-59A, led/watchdog/battery on these models are same, actual drivers for models will be sent in separate patches. Signed-off-by:
-
Henning Schild authored
There was a copy and paste mistake where the module name was not correct. Fixes: 917f5434 ("platform/x86: simatic-ipc: add CMOS battery monitoring") Signed-off-by:
Henning Schild <henning.schild@siemens.com> Link: https://lore.kernel.org/r/20230725093113.9739-3-henning.schild@siemens.comReviewed-by:
-
xingtong.wu authored
There was a case missing in a switch statement which lead to that model not actually reading the GPIOs. That switch statement got simplified now. Additionally on that model we need to initialize one pin differently. As a drive-by finding also add a missing newline. Fixes: 917f5434 ("platform/x86: simatic-ipc: add CMOS battery monitoring") Reported-by:
-
Henning Schild authored
With more files around move everything to a subdirectory. Users will only see the several options once they enable the main one. Suggested-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230719153518.13073-4-henning.schild@siemens.comReviewed-by:
-
Henning Schild authored
If a user did choose to enable Siemens Simatic platform support they likely want the LED drivers to be enabled without having to flip more config switches. So we make the LED drivers config switch default to the platform driver switches value. Signed-off-by:
Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230719153518.13073-3-henning.schild@siemens.comSigned-off-by:
-
Henning Schild authored
If a user did choose to enable Siemens Simatic platform support they likely want that driver to be enabled without having to flip more config switches. So we make the watchdog driver config switch default to the platform driver switches value. Signed-off-by:
Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20230719153518.13073-2-henning.schild@siemens.comSigned-off-by:
-
- 26 Jul, 2023 5 commits
-
-
Dan Carpenter authored
Return a negative error code instead of returning success. Fixes: a34fc329 ("platform/x86: hp-bioscfg: bioscfg") Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/138641cc-52c0-41a5-8176-ad01c7e28c67@moroto.mountainReviewed-by:
-
Dan Carpenter authored
This function escapes certain special characters like \n. So if the last character in the string is a '\n' then it gets changed into two characters '\' and '\n'. But maybe we only have space for the '\' so we need to check for that. The "conv_dst_size" variable is always less than or to equal the "size" variable. It's easier to just check "conv_dst_size" instead of checking both. Fixes: a34fc329 ("platform/x86: hp-bioscfg: bioscfg") Signed-off-by:
-
Dan Carpenter authored
The error handling won't work if "mid" is unsigned. "ret" is used to store negative error codes and declaring it as a u32 won't cause a bug but it's ugly. The "actual_outsize" variable is a number between 0-4096 so it can be declared as int as well. Fixes: 69ea03e3 ("platform/x86: hp-bioscfg: biosattr-interface") Signed-off-by:
-
Tim Crawford authored
System76 EC since system76/ec@9ac513128ad9 detects if the keyboard is white or RGB backlit via `RGBKB-DET#` at run-time instead of being set at compile-time. As part of this, the brightness of white-only backlit keyboards was also changed to behave more like the RGB-backlit keyboards: a value between 0 and 255 instead of a firmware-defined level. The EC ACPI methods in coreboot have been updated for this new functionality only, removing the old behavior. This should preserve behavior as we roll out new firmware with these changes included and users update to it. Link: https://github.com/system76/ec/pull/357 Link: https://review.coreboot.org/c/coreboot/+/76152Signed-off-by:
Tim Crawford <tcrawford@system76.com> Link: https://lore.kernel.org/r/20230719181324.47035-1-tcrawford@system76.comReviewed-by:
-
Rob Herring authored
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by:
Rob Herring <robh@kernel.org> Reviewed-by:
Tzung-Bi Shih <tzungbi@kernel.org> Link: https://lore.kernel.org/r/20230714174909.4062739-1-robh@kernel.orgSigned-off-by:
-
- 14 Jul, 2023 12 commits
-
-
Robert Joslyn authored
Add a driver for Schweitzer Engineering Laboratories SEL-3350 computers front LEDs and power supplies. LED and power supply status is provided by the Intel SoC GPIO. Signed-off-by:
Robert Joslyn <robert.joslyn@redrectangle.org> Link: https://lore.kernel.org/r/20230713035714.807819-1-robert.joslyn@redrectangle.orgReviewed-by:
-
Srinivas Pandruvada authored
Describe fields in the TPMI debugfs folder. Signed-off-by:
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Reviewed-by:
-
Srinivas Pandruvada authored
Add debugfs interface for debugging TPMI configuration and register contents. This shows PFS (PM Feature structure) for each TPMI device. For each feature, show full register contents and allow to modify register at an offset. This debugfs interface is not present on locked down kernel with no DEVMEM access and without CAP_SYS_RAWIO permission. Signed-off-by:
-
Srinivas Pandruvada authored
Some of the PM features can be locked or disabled. In that case, write interface can be locked. This status is read via a mailbox. There is one TPMI ID which provides base address for interface and data register for mail box operation. The mailbox operations is defined in the TPMI specification. Refer to https://github.com/intel/tpmi_power_management/ for TPMI specifications. An API is exposed to feature drivers to read feature control status. Signed-off-by:
-
Hans de Goede authored
Immutable branch between pdx86 simatic branch and LED due for the v6.6 merge window v6.5-rc1 + recent pdx86 simatic-ipc patches for merging into the LED subsystem for v6.6.
-
Henning Schild authored
We recently introduced a way to name additional modules to load for each device. Use that instead of wdtmode to load the watchdog module. This patch does not change behaviour, it is just style. Signed-off-by:
-
Henning Schild authored
In order to know which hwmon modules to load one would have to usually first probe from user-land i.e. with sensors-detect and create a config for each machine. But here we know exactly what machines we are dealing with, so we can request those howmon modules without user-mode detection and config files. Signed-off-by:
-
Henning Schild authored
This is the panel variant of a device we already did have. All the same, just no LEDs. Signed-off-by:
-
Henning Schild authored
We do not use PCI any longer since commit 446f0cf9 ("platform/x86: simatic-ipc: drop custom P2SB bar code")' Signed-off-by:
-
Henning Schild authored
Siemens Simatic Industrial PCs can monitor the voltage of the CMOS battery with two bits that indicate low or empty state. This can be GPIO or PortIO based. Here we model that as a hwmon voltage. The core driver does the PortIO and provides boilerplate for the GPIO versions. Which are split out to model runtime dependencies while allowing fine-grained kernel configuration. Signed-off-by:
-
Henning Schild authored
The IO region used for the watchdog also hold CMOS battery monitoring information. Make the access muxed so that a hwmon driver can use the region as well. Signed-off-by:
-
Henning Schild authored
This adds support for the Siemens Simatic IPC model BX-21A. Actual drivers for that model will be sent in separate patches. Signed-off-by:
-
- 12 Jul, 2023 1 commit
-
-
Thomas Weißschuh authored
Instead of relying on free-form comments to document locking requirements use well-known lockdep annotations. These can also be validated at runtime make sure the invariants are not violated. Signed-off-by:
-
