1. 19 Feb, 2022 16 commits
    • Volodymyr Mytnyk's avatar
      net: prestera: flower: fix destroy tmpl in chain · b3ae2d35
      Volodymyr Mytnyk authored
      Fix flower destroy template callback to release template
      only for specific tc chain instead of all chain tempaltes.
      
      The issue was intruduced by previous commit that introduced
      multi-chain support.
      
      Fixes: fa5d824c ("net: prestera: acl: add multi-chain support offload")
      Signed-off-by: default avatarVolodymyr Mytnyk <vmytnyk@marvell.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b3ae2d35
    • Eric Dumazet's avatar
      bridge: switch br_net_exit to batch mode · 36a29fb6
      Eric Dumazet authored
      cleanup_net() is competing with other rtnl users.
      
      Instead of calling br_net_exit() for each netns,
      call br_net_exit_batch() once.
      
      This gives cleanup_net() ability to group more devices
      and call unregister_netdevice_many() only once for all bridge devices.
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Cc: Roopa Prabhu <roopa@nvidia.com>
      Cc: Nikolay Aleksandrov <razor@blackwall.org>
      Acked-by: default avatarNikolay Aleksandrov <razor@blackwall.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      36a29fb6
    • David S. Miller's avatar
      Merge branch 'mctp-i2c' · a7cc3464
      David S. Miller authored
      Matt Johnston says:
      
      ====================
      MCTP I2C driver
      
      This patch series adds a netdev driver providing MCTP transport over
      I2C.
      
      I think I've addressed all the points raised in v5. It now has
      mctp_i2c_unregister() to run things in the correct order, waiting for
      the worker thread and I2C rx to complete.
      
      Cheers,
      Matt
      
      --
      
      v6:
       - Changed netdev register/unregister/free to avoid races. Ensure that
         netif functions are not used by irq handler/threads after unregister.
       - Fix incoming I2C hwaddr that was previously incorrect (left
         shifted 1 bit)
       - Add a check that byte_count wire header matches the length received
       - Renamed I2C driver to mctp-i2c-interface
       - Removed __func__ from print messages, added missing newlines
       - Removed sysfs mctp_current_mux file which was used for debug
       - Renamed curr_lock to sel_lock
       - Tidied comment formatting
       - Fix newline in Kconfig
      v5:
       - Fix incorrect format string
      v4:
       - Switch to __i2c_transfer() rather than __i2c_smbus_xfer(), drop 255 byte
         smbus patches
       - Use wait_event_idle() for the sleeping TX thread
       - Use dev_addr_set()
      v3:
       - Added Reviewed-bys for npcm7xx
       - Resend with net-next open
      v2:
       - Simpler Kconfig condition for i2c-mux dependency, from Randy Dunlap
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a7cc3464
    • Matt Johnston's avatar
      mctp i2c: MCTP I2C binding driver · f5b8abf9
      Matt Johnston authored
      Provides MCTP network transport over an I2C bus, as specified in
      DMTF DSP0237. All messages between nodes are sent as SMBus Block Writes.
      
      Each I2C bus to be used for MCTP is flagged in devicetree by a
      'mctp-controller' property on the bus node. Each flagged bus gets a
      mctpi2cX net device created based on the bus number. A
      'mctp-i2c-controller' I2C client needs to be added under the adapter. In
      an I2C mux situation the mctp-i2c-controller node must be attached only
      to the root I2C bus. The I2C client will handle incoming I2C slave block
      write data for subordinate busses as well as its own bus.
      
      In configurations without devicetree a driver instance can be attached
      to a bus using the I2C slave new_device mechanism.
      
      The MCTP core will hold/release the MCTP I2C device while responses
      are pending (a 6 second timeout or once a socket is closed, response
      received etc). While held the MCTP I2C driver will lock the I2C bus so
      that the correct I2C mux remains selected while responses are received.
      
      (Ideally we would just lock the mux to keep the current bus selected for
      the response rather than a full I2C bus lock, but that isn't exposed in
      the I2C mux API)
      Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
      Signed-off-by: default avatarJeremy Kerr <jk@codeconstruct.com.au>
      Reviewed-by: Wolfram Sang <wsa@kernel.org> # I2C transport parts
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f5b8abf9
    • Matt Johnston's avatar
      dt-bindings: net: New binding mctp-i2c-controller · 6881e493
      Matt Johnston authored
      Used to define a local endpoint to communicate with MCTP peripherals
      attached to an I2C bus. This I2C endpoint can communicate with remote
      MCTP devices on the I2C bus.
      
      In the example I2C topology below (matching the second yaml example) we
      have MCTP devices on busses i2c1 and i2c6. MCTP-supporting busses are
      indicated by the 'mctp-controller' DT property on an I2C bus node.
      
      A mctp-i2c-controller I2C client DT node is placed at the top of the
      mux topology, since only the root I2C adapter will support I2C slave
      functionality.
                                                     .-------.
                                                     |eeprom |
          .------------.     .------.               /'-------'
          | adapter    |     | mux  --@0,i2c5------'
          | i2c1       ----.*|      --@1,i2c6--.--.
          |............|    \'------'           \  \  .........
          | mctp-i2c-  |     \                   \  \ .mctpB  .
          | controller |      \                   \  '.0x30   .
          |            |       \  .........        \  '.......'
          | 0x50       |        \ .mctpA  .         \ .........
          '------------'         '.0x1d   .          '.mctpC  .
                                  '.......'          '.0x31   .
                                                      '.......'
      (mctpX boxes above are remote MCTP devices not included in the DT at
      present, they can be hotplugged/probed at runtime. A DT binding for
      specific fixed MCTP devices could be added later if required)
      Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
      Reviewed-by: default avatarRob Herring <robh@kernel.org>
      Acked-by: default avatarWolfram Sang <wsa@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6881e493
    • Mobashshera Rasool's avatar
      net: ip6mr: add support for passing full packet on wrong mif · 4b340a5a
      Mobashshera Rasool authored
      This patch adds support for MRT6MSG_WRMIFWHOLE which is used to pass
      full packet and real vif id when the incoming interface is wrong.
      While the RP and FHR are setting up state we need to be sending the
      registers encapsulated with all the data inside otherwise we lose it.
      The RP then decapsulates it and forwards it to the interested parties.
      Currently with WRONGMIF we can only be sending empty register packets
      and will lose that data.
      This behaviour can be enabled by using MRT_PIM with
      val == MRT6MSG_WRMIFWHOLE. This doesn't prevent MRT6MSG_WRONGMIF from
      happening, it happens in addition to it, also it is controlled by the same
      throttling parameters as WRONGMIF (i.e. 1 packet per 3 seconds currently).
      Both messages are generated to keep backwards compatibily and avoid
      breaking someone who was enabling MRT_PIM with val == 4, since any
      positive val is accepted and treated the same.
      Signed-off-by: default avatarMobashshera Rasool <mobash.rasool.linux@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4b340a5a
    • Alexander Lobakin's avatar
      i40e: remove dead stores on XSK hotpath · 7e1b54d0
      Alexander Lobakin authored
      The 'if (ntu == rx_ring->count)' block in i40e_alloc_rx_buffers_zc()
      was previously residing in the loop, but after introducing the
      batched interface it is used only to wrap-around the NTU descriptor,
      thus no more need to assign 'xdp'.
      
      'cleaned_count' in i40e_clean_rx_irq_zc() was previously being
      incremented in the loop, but after commit f12738b6
      ("i40e: remove unnecessary cleaned_count updates") it gets
      assigned only once after it, so the initialization can be dropped.
      
      Fixes: 6aab0bb0 ("i40e: Use the xsk batched rx allocation interface")
      Fixes: f12738b6 ("i40e: remove unnecessary cleaned_count updates")
      Signed-off-by: default avatarAlexander Lobakin <alexandr.lobakin@intel.com>
      Acked-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
      Tested-by: default avatarGeorge Kuruvinakunnel <george.kuruvinakunnel@intel.com>
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7e1b54d0
    • Jakub Kicinski's avatar
      Merge branch 'add-checks-for-incoming-packet-addresses' · bbcf340d
      Jakub Kicinski authored
      Jeremy Kerr says:
      
      ====================
      Add checks for incoming packet addresses
      
      This series adds a couple of checks for valid addresses on incoming MCTP
      packets. We introduce a couple of helpers in 1/2, and use them in the
      ingress path in 2/2.
      ====================
      
      Link: https://lore.kernel.org/r/20220218042554.564787-1-jk@codeconstruct.com.auSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      bbcf340d
    • Jeremy Kerr's avatar
      mctp: add address validity checking for packet receive · 86cdfd63
      Jeremy Kerr authored
      This change adds some basic sanity checks for the source and dest
      headers of packets on initial receive.
      Signed-off-by: default avatarJeremy Kerr <jk@codeconstruct.com.au>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      86cdfd63
    • Jeremy Kerr's avatar
      mctp: replace mctp_address_ok with more fine-grained helpers · cb196b72
      Jeremy Kerr authored
      Currently, we have mctp_address_ok(), which checks if an EID is in the
      "valid" range of 8-254 inclusive. However, 0 and 255 may also be valid
      addresses, depending on context. 0 is the NULL EID, which may be set
      when physical addressing is used. 255 is valid as a destination address
      for broadcasts.
      
      This change renames mctp_address_ok to mctp_address_unicast, and adds
      similar helpers for broadcast and null EIDs, which will be used in an
      upcoming commit.
      Signed-off-by: default avatarJeremy Kerr <jk@codeconstruct.com.au>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      cb196b72
    • Jacques de Laval's avatar
      net: Add new protocol attribute to IP addresses · 47f0bd50
      Jacques de Laval authored
      This patch adds a new protocol attribute to IPv4 and IPv6 addresses.
      Inspiration was taken from the protocol attribute of routes. User space
      applications like iproute2 can set/get the protocol with the Netlink API.
      
      The attribute is stored as an 8-bit unsigned integer.
      
      The protocol attribute is set by kernel for these categories:
      
      - IPv4 and IPv6 loopback addresses
      - IPv6 addresses generated from router announcements
      - IPv6 link local addresses
      
      User space may pass custom protocols, not defined by the kernel.
      
      Grouping addresses on their origin is useful in scenarios where you want
      to distinguish between addresses based on who added them, e.g. kernel
      vs. user space.
      
      Tagging addresses with a string label is an existing feature that could be
      used as a solution. Unfortunately the max length of a label is
      15 characters, and for compatibility reasons the label must be prefixed
      with the name of the device followed by a colon. Since device names also
      have a max length of 15 characters, only -1 characters is guaranteed to be
      available for any origin tag, which is not that much.
      
      A reference implementation of user space setting and getting protocols
      is available for iproute2:
      
      https://github.com/westermo/iproute2/commit/9a6ea18bd79f47f293e5edc7780f315ea42ff540Signed-off-by: default avatarJacques de Laval <Jacques.De.Laval@westermo.com>
      Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
      Link: https://lore.kernel.org/r/20220217150202.80802-1-Jacques.De.Laval@westermo.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      47f0bd50
    • Jakub Kicinski's avatar
      Merge branch 'ionic-driver-updates' · 6e2e59ea
      Jakub Kicinski authored
      Shannon Nelson says:
      
      ====================
      ionic: driver updates
      
      These are a couple of checkpatch cleanup patches, a bug fix,
      and something to alleviate memory pressure in tight places.
      ====================
      
      Link: https://lore.kernel.org/r/20220217220252.52293-1-snelson@pensando.ioSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      6e2e59ea
    • Shannon Nelson's avatar
      ionic: clean up comments and whitespace · ecea8bb4
      Shannon Nelson authored
      Fix up some checkpatch complaints that have crept in:
      doubled words words, mispellled words, doubled lines.
      Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      ecea8bb4
    • Shannon Nelson's avatar
      ionic: prefer strscpy over strlcpy · 799c230e
      Shannon Nelson authored
      Replace strlcpy with strscpy to clean up a checkpatch complaint.
      Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      799c230e
    • Brett Creeley's avatar
      ionic: Use vzalloc for large per-queue related buffers · 116dce0f
      Brett Creeley authored
      Use vzalloc for per-queue info structs that don't need any
      DMA mapping to help relieve memory pressure found when used
      in our limited SOC environment.
      Signed-off-by: default avatarBrett Creeley <brett@pensando.io>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      116dce0f
    • Shannon Nelson's avatar
      ionic: catch transition back to RUNNING with fw_generation 0 · 12b1b997
      Shannon Nelson authored
      In some graceful updates that get initially triggered by the
      RESET event, especially with older firmware, the fw_generation
      bits don't change but the fw_status is seen to go to 0 then back
      to 1.  However, the driver didn't perform the restart, remained
      waiting for fw_generation to change, and got left in limbo.
      
      This is because the clearing of idev->fw_status_ready to 0
      didn't happen correctly as it was buried in the transition
      trigger: since the transition down was triggered not here
      but in the RESET event handler, the clear to 0 didn't happen,
      so the transition back to 1 wasn't detected.
      
      Fix this particular case by bringing the setting of
      idev->fw_status_ready back out to where it was before.
      
      Fixes: 398d1e37 ("ionic: add FW_STOPPING state")
      Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      12b1b997
  2. 18 Feb, 2022 24 commits