1. 16 Dec, 2021 6 commits
    • Lukas Bulwahn's avatar
      mips: remove obsolete selection of CPU_HAS_LOAD_STORE_LR · bb900d43
      Lukas Bulwahn authored
      Commit 18d84e2e ("MIPS: make CPU_HAS_LOAD_STORE_LR opt-out") replaced
      the config CPU_HAS_LOAD_STORE_LR by the config with an inverted semantics,
      making the "LOAD_STORE_LR" cpu configuration the default.
      The ./arch/mips/Kconfig was adjusted accordingly.
      
      Later, commit 65ce6197 ("Revert "MIPS: Remove unused R4300 CPU
      support"") reintroduces a select CPU_HAS_LOAD_STORE_LR through its revert
      commit, restoring the config CPU_R4300 in ./arch/mips/Kconfig before the
      refactoring above.
      
      This select however now refers to a non-existing config and is further
      unneeded, as LOAD_STORE_LR is the default now.
      
      Remove the obsolete select for the reintroduced mips R4300 architecture.
      
      This issue is identified with ./scripts/checkkconfigsymbols.py.
      Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
      Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      bb900d43
    • Lukas Bulwahn's avatar
      mips: kgdb: adjust the comment to the actual ifdef condition · 301e4999
      Lukas Bulwahn authored
      The comment refers to CONFIG_CPU_32BIT, but the ifdef uses CONFIG_32BIT.
      As this ifdef and comment was introduced with initial mips-kgdb commit
      88547001 ("[MIPS] kgdb: add arch support for the kernel's kgdb core"),
      it is probably just a minor issue that was overlooked during the patch
      creation and refactoring before submission.
      
      This inconsistency was identified with ./scripts/checkkconfigsymbols.py.
      This script has been quite useful to identify a number of bugs with
      Kconfig symbols and deserves to be executed and checked regularly.
      
      So, adjust the comment to the actual ifdef condition to reduce the
      reports made the script and simplify to use this script, as new issues
      are easier to spot when the list of reports is shorter.
      Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
      Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      301e4999
    • Lukas Bulwahn's avatar
      mips: dec: provide the correctly capitalized config CPU_R4X00 in init error message · 9a53a8d7
      Lukas Bulwahn authored
      The config for MIPS R4000-series processors is named CPU_R4X00 with
      upper-case X, not CPU_R4x00 as the error message suggests.
      
      Hence, ./scripts/checkkconfigsymbols.py reports this invalid reference:
      
        CPU_R4x00
        Referencing files: arch/mips/dec/prom/init.c
      
      When human users encounter this error message, they probably just deal
      with this minor discrepancy; so, the spelling never was a big deal here.
      
      Still, the script ./scripts/checkkconfigsymbols.py has been quite useful
      to identify a number of bugs with Kconfig symbols and deserves to be
      executed and checked regularly.
      
      So, repair the error message to reduce the reports made the script and
      simplify to use this script, as new issues are easier to spot when the
      list of reports is shorter.
      Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
      Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      9a53a8d7
    • Lukas Bulwahn's avatar
      mips: drop selecting non-existing config NR_CPUS_DEFAULT_2 · 74320247
      Lukas Bulwahn authored
      Commit c5eaff3e ("MIPS: Kconfig: Drop obsolete NR_CPUS_DEFAULT_{1,2}
      options") removed the config NR_CPUS_DEFAULT_2, as with this commit, the
      NR_CPUS default value is 2.
      
      Commit 7505576d ("MIPS: add support for SGI Octane (IP30)") introduces
      the config SGI_IP30, which selects the removed config NR_CPUS_DEFAULT_2,
      but this has actually no effect.
      
      Fortunately, NR_CPUS defaults to 2 when there is no specific
      NR_CPUS_DEFAULT_* config selected. So, the effect of the intended
      'select NR_CPUS_DEFAULT_2' is achieved without further ado.
      
      Drop selecting the non-existing config NR_CPUS_DEFAULT_2.
      
      The issue was identified with ./scripts/checkkconfigsymbols.py.
      
      Fixes: 7505576d ("MIPS: add support for SGI Octane (IP30)")
      Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
      Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      74320247
    • Lukas Bulwahn's avatar
      mips: add SYS_HAS_CPU_MIPS64_R5 config for MIPS Release 5 support · fd4eb90b
      Lukas Bulwahn authored
      Commit ab7c01fd ("mips: Add MIPS Release 5 support") adds the two
      configs CPU_MIPS32_R5 and CPU_MIPS64_R5, which depend on the corresponding
      SYS_HAS_CPU_MIPS32_R5 and SYS_HAS_CPU_MIPS64_R5, respectively.
      
      The config SYS_HAS_CPU_MIPS32_R5 was already introduced with commit
      c5b36783 ("MIPS: Add support for XPA."); the config
      SYS_HAS_CPU_MIPS64_R5, however, was never introduced.
      
      Hence, ./scripts/checkkconfigsymbols.py warns:
      
        SYS_HAS_CPU_MIPS64_R5
        Referencing files: arch/mips/Kconfig, arch/mips/include/asm/cpu-type.h
      
      Add the definition for config SYS_HAS_CPU_MIPS64_R5 under the assumption
      that SYS_HAS_CPU_MIPS64_R5 follows the same pattern as the existing
      SYS_HAS_CPU_MIPS32_R5 and SYS_HAS_CPU_MIPS64_R6.
      
      Fixes: ab7c01fd ("mips: Add MIPS Release 5 support")
      Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
      Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      fd4eb90b
    • Sander Vanheule's avatar
      MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL · 6fb8a1b3
      Sander Vanheule authored
      MACH_REALTEK_RTL declares that the system supports early printk , but
      this is not actually implemented as intended. The system is left with a
      non-functional early0 console because the setup_8250_early_printk_port()
      call provided for MIPS_GENERIC is never used to set this up. Generic
      ns16550a earlycon works, so devices should use that for early output.
      This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250
      do not need to be selected.
      
      Additionally, as reported by Lukas Bulwahn, the selected symbol
      SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be
      dropped.
      
      Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
      Cc: Bert Vermeulen <bert@biot.com>
      Signed-off-by: default avatarSander Vanheule <sander@svanheule.net>
      Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      6fb8a1b3
  2. 14 Dec, 2021 6 commits
  3. 09 Dec, 2021 7 commits
  4. 30 Nov, 2021 1 commit
  5. 29 Nov, 2021 3 commits
  6. 28 Nov, 2021 8 commits
  7. 27 Nov, 2021 9 commits