1. 12 Aug, 2023 8 commits
    • Amir Goldstein's avatar
      ovl: auto generate uuid for new overlay filesystems · cbb44f09
      Amir Goldstein authored
      Add a new mount option uuid=auto, which is the default.
      
      If a persistent UUID xattr is found it is used.
      
      Otherwise, an existing ovelrayfs with copied up subdirs in upper dir
      that was never mounted with uuid=on retains the null UUID.
      
      A new overlayfs with no copied up subdirs, generates the persistent UUID
      on first mount.
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      cbb44f09
    • Amir Goldstein's avatar
      ovl: store persistent uuid/fsid with uuid=on · d9544c1b
      Amir Goldstein authored
      With uuid=on, store a persistent uuid in xattr on the upper dir to
      give the overlayfs instance a persistent identifier.
      
      This also makes f_fsid persistent and more reliable for reporting
      fid info in fanotify events.
      
      uuid=on is not supported on non-upper overlayfs or with upper fs
      that does not support xattrs.
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      d9544c1b
    • Amir Goldstein's avatar
      ovl: add support for unique fsid per instance · b0504bfe
      Amir Goldstein authored
      The legacy behavior of ovl_statfs() reports the f_fsid filled by
      underlying upper fs. This fsid is not unique among overlayfs instances
      on the same upper fs.
      
      With mount option uuid=on, generate a non-persistent uuid per overlayfs
      instance and use it as the seed for f_fsid, similar to tmpfs.
      
      This is useful for reporting fanotify events with fid info from different
      instances of overlayfs over the same upper fs.
      
      The old behavior of null uuid and upper fs fsid is retained with the
      mount option uuid=null, which is the default.
      
      The mount option uuid=off that disables uuid checks in underlying layers
      also retains the legacy behavior.
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      b0504bfe
    • Amir Goldstein's avatar
      ovl: support encoding non-decodable file handles · 16aac5ad
      Amir Goldstein authored
      When all layers support file handles, we support encoding non-decodable
      file handles (a.k.a. fid) even with nfs_export=off.
      
      When file handles do not need to be decoded, we do not need to copy up
      redirected lower directories on encode, and we encode also non-indexed
      upper with lower file handle, so fid will not change on copy up.
      
      This enables reporting fanotify events with file handles on overlayfs
      with default config/mount options.
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      16aac5ad
    • Alexander Larsson's avatar
      ovl: Handle verity during copy-up · 0c71faf5
      Alexander Larsson authored
      During regular metacopy, if lowerdata file has fs-verity enabled, and
      the verity option is enabled, we add the digest to the metacopy xattr.
      
      If verity is required, and lowerdata does not have fs-verity enabled,
      fall back to full copy-up (or the generated metacopy would not
      validate).
      Signed-off-by: default avatarAlexander Larsson <alexl@redhat.com>
      Reviewed-by: default avatarAmir Goldstein <amir73il@gmail.com>
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      0c71faf5
    • Alexander Larsson's avatar
      ovl: Validate verity xattr when resolving lowerdata · 184996e9
      Alexander Larsson authored
      The new digest field in the metacopy xattr is used during lookup to
      record whether the header contained a digest in the OVL_HAS_DIGEST
      flags.
      
      When accessing file data the first time, if OVL_HAS_DIGEST is set, we
      reload the metadata and check that the source lowerdata inode matches
      the specified digest in it (according to the enabled verity
      options). If the verity check passes we store this info in the inode
      flags as OVL_VERIFIED_DIGEST, so that we can avoid doing it again if
      the inode remains in memory.
      
      The verification is done in ovl_maybe_validate_verity() which needs to
      be called in the same places as ovl_maybe_lookup_lowerdata(), so there
      is a new ovl_verify_lowerdata() helper that calls these in the right
      order, and all current callers of ovl_maybe_lookup_lowerdata() are
      changed to call it instead.
      Signed-off-by: default avatarAlexander Larsson <alexl@redhat.com>
      Reviewed-by: default avatarAmir Goldstein <amir73il@gmail.com>
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      184996e9
    • Alexander Larsson's avatar
      ovl: Add versioned header for overlay.metacopy xattr · bf070890
      Alexander Larsson authored
      Historically overlay.metacopy was a zero-size xattr, and it's
      existence marked a metacopy file. This change adds a versioned header
      with a flag field, a length and a digest. The initial use-case of this
      will be for validating a fs-verity digest, but the flags field could
      also be used later for other new features.
      
      ovl_check_metacopy_xattr() now returns the size of the xattr,
      emulating a size of OVL_METACOPY_MIN_SIZE for empty xattrs to
      distinguish it from the no-xattr case.
      Signed-off-by: default avatarAlexander Larsson <alexl@redhat.com>
      Reviewed-by: default avatarAmir Goldstein <amir73il@gmail.com>
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      bf070890
    • Alexander Larsson's avatar
      ovl: Add framework for verity support · ae8cba40
      Alexander Larsson authored
      This adds the scaffolding (docs, config, mount options) for supporting
      the new digest field in the metacopy xattr. This contains a fs-verity
      digest that need to match the fs-verity digest of the lowerdata
      file. The mount option "verity" specifies how this xattr is handled.
      
      If you enable verity ("verity=on") all existing xattrs are validated
      before use, and during metacopy we generate verity xattr in the upper
      metacopy file (if the source file has verity enabled). This means
      later accesses can guarantee that the same data is used.
      
      Additionally you can use "verity=require". In this mode all metacopy
      files must have a valid verity xattr. For this to work metadata
      copy-up must be able to create a verity xattr (so that later accesses
      are validated). Therefore, in this mode, if the lower data file
      doesn't have fs-verity enabled we fall back to a full copy rather than
      a metacopy.
      
      Actual implementation follows in a separate commit.
      Signed-off-by: default avatarAlexander Larsson <alexl@redhat.com>
      Reviewed-by: default avatarAmir Goldstein <amir73il@gmail.com>
      Acked-by: default avatarEric Biggers <ebiggers@google.com>
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      ae8cba40
  2. 06 Aug, 2023 8 commits
    • Linus Torvalds's avatar
      Linux 6.5-rc5 · 52a93d39
      Linus Torvalds authored
      52a93d39
    • Linus Torvalds's avatar
      Merge tag 'v6.5-rc5.vfs.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs · 0108963f
      Linus Torvalds authored
      Pull vfs fixes from Christian Brauner:
      
       - Fix a wrong check for O_TMPFILE during RESOLVE_CACHED lookup
      
       - Clean up directory iterators and clarify file_needs_f_pos_lock()
      
      * tag 'v6.5-rc5.vfs.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs:
        fs: rely on ->iterate_shared to determine f_pos locking
        vfs: get rid of old '->iterate' directory operation
        proc: fix missing conversion to 'iterate_shared'
        open: make RESOLVE_CACHED correctly test for O_TMPFILE
      0108963f
    • Christian Brauner's avatar
      fs: rely on ->iterate_shared to determine f_pos locking · 7d84d1b9
      Christian Brauner authored
      Now that we removed ->iterate we don't need to check for either
      ->iterate or ->iterate_shared in file_needs_f_pos_lock(). Simply check
      for ->iterate_shared instead. This will tell us whether we need to
      unconditionally take the lock. Not just does it allow us to avoid
      checking f_inode's mode it also actually clearly shows that we're
      locking because of readdir.
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      7d84d1b9
    • Linus Torvalds's avatar
      vfs: get rid of old '->iterate' directory operation · 3e327154
      Linus Torvalds authored
      All users now just use '->iterate_shared()', which only takes the
      directory inode lock for reading.
      
      Filesystems that never got convered to shared mode now instead use a
      wrapper that drops the lock, re-takes it in write mode, calls the old
      function, and then downgrades the lock back to read mode.
      
      This way the VFS layer and other callers no longer need to care about
      filesystems that never got converted to the modern era.
      
      The filesystems that use the new wrapper are ceph, coda, exfat, jfs,
      ntfs, ocfs2, overlayfs, and vboxsf.
      
      Honestly, several of them look like they really could just iterate their
      directories in shared mode and skip the wrapper entirely, but the point
      of this change is to not change semantics or fix filesystems that
      haven't been fixed in the last 7+ years, but to finally get rid of the
      dual iterators.
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      3e327154
    • Linus Torvalds's avatar
      proc: fix missing conversion to 'iterate_shared' · 0a2c2baa
      Linus Torvalds authored
      I'm looking at the directory handling due to the discussion about f_pos
      locking (see commit 79796425: "file: reinstate f_pos locking
      optimization for regular files"), and wanting to clean that up.
      
      And one source of ugliness is how we were supposed to move filesystems
      over to the '->iterate_shared()' function that only takes the inode lock
      for reading many many years ago, but several filesystems still use the
      bad old '->iterate()' that takes the inode lock for exclusive access.
      
      See commit 61922694 ("introduce a parallel variant of ->iterate()")
      that also added some documentation stating
      
            Old method is only used if the new one is absent; eventually it will
            be removed.  Switch while you still can; the old one won't stay.
      
      and that was back in April 2016.  Here we are, many years later, and the
      old version is still clearly sadly alive and well.
      
      Now, some of those old style iterators are probably just because the
      filesystem may end up having per-inode mutable data that it uses for
      iterating a directory, but at least one case is just a mistake.
      
      Al switched over most filesystems to use '->iterate_shared()' back when
      it was introduced.  In particular, the /proc filesystem was converted as
      one of the first ones in commit f50752ea ("switch all procfs
      directories ->iterate_shared()").
      
      But then later one new user of '->iterate()' was then re-introduced by
      commit 6d9c939d ("procfs: add smack subdir to attrs").
      
      And that's clearly not what we wanted, since that new case just uses the
      same 'proc_pident_readdir()' and 'proc_pident_lookup()' helper functions
      that other /proc pident directories use, and they are most definitely
      safe to use with the inode lock held shared.
      
      So just fix it.
      
      This still leaves a fair number of oddball filesystems using the
      old-style directory iterator (ceph, coda, exfat, jfs, ntfs, ocfs2,
      overlayfs, and vboxsf), but at least we don't have any remaining in the
      core filesystems.
      
      I'm going to add a wrapper function that just drops the read-lock and
      takes it as a write lock, so that we can clean up the core vfs layer and
      make all the ugly 'this filesystem needs exclusive inode locking' be
      just filesystem-internal warts.
      
      I just didn't want to make that conversion when we still had a core user
      left.
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      0a2c2baa
    • Aleksa Sarai's avatar
      open: make RESOLVE_CACHED correctly test for O_TMPFILE · a0fc452a
      Aleksa Sarai authored
      O_TMPFILE is actually __O_TMPFILE|O_DIRECTORY. This means that the old
      fast-path check for RESOLVE_CACHED would reject all users passing
      O_DIRECTORY with -EAGAIN, when in fact the intended test was to check
      for __O_TMPFILE.
      
      Cc: stable@vger.kernel.org # v5.12+
      Fixes: 99668f61 ("fs: expose LOOKUP_CACHED through openat2() RESOLVE_CACHED")
      Signed-off-by: default avatarAleksa Sarai <cyphar@cyphar.com>
      Message-Id: <20230806-resolve_cached-o_tmpfile-v1-1-7ba16308465e@cyphar.com>
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      a0fc452a
    • Linus Torvalds's avatar
      Merge tag 'rust-fixes-6.5-rc5' of https://github.com/Rust-for-Linux/linux · f0ab9f34
      Linus Torvalds authored
      Pull rust fixes from Miguel Ojeda:
      
       - Allocator: prevent mis-aligned allocation
      
       - Types: delete 'ForeignOwnable::borrow_mut'. A sound replacement is
         planned for the merge window
      
       - Build: fix bindgen error with UBSAN_BOUNDS_STRICT
      
      * tag 'rust-fixes-6.5-rc5' of https://github.com/Rust-for-Linux/linux:
        rust: fix bindgen build error with UBSAN_BOUNDS_STRICT
        rust: delete `ForeignOwnable::borrow_mut`
        rust: allocator: Prevent mis-aligned allocation
      f0ab9f34
    • Linus Torvalds's avatar
      Merge tag 'ata-6.5-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata · fb0d9199
      Linus Torvalds authored
      Pull ata fix from Damien Le Moal:
      
       - Prevent the scsi disk driver from issuing a START STOP UNIT command
         for ATA devices during system resume as this causes various issues
         reported by multiple users.
      
      * tag 'ata-6.5-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata:
        ata,scsi: do not issue START STOP UNIT on resume
      fb0d9199
  3. 05 Aug, 2023 5 commits
  4. 04 Aug, 2023 13 commits
  5. 03 Aug, 2023 6 commits
    • Dave Airlie's avatar
      Merge tag 'drm-intel-fixes-2023-08-03' of... · 1958b0f9
      Dave Airlie authored
      Merge tag 'drm-intel-fixes-2023-08-03' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes
      
      - Fix bug in getting msg length in AUX CH registers handler [gvt] (Yan Zhao)
      - Gen12 AUX invalidation fixes [gt] (Andi Shyti, Jonathan Cavitt)
      - Fix premature release of request's reusable memory (Janusz Krzysztofik)
      
      - Merge tag 'gvt-fixes-2023-08-02' of https://github.com/intel/gvt-linux into drm-intel-fixes (Tvrtko Ursulin)
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/ZMtkxWGuUKpaRMmo@tursulin-desk
      1958b0f9
    • Dave Airlie's avatar
      Merge tag 'drm-misc-fixes-2023-08-03' of ssh://git.freedesktop.org/git/drm/drm-misc into drm-fixes · 062ff85b
      Dave Airlie authored
      A NULL pointer dereference fix for TTM, a timings fix for imx/ipuv3 and
      the addition of a MODULE_DEVICE_TABLE for the samsung-s6d7aa0 panel.
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      
      From: Maxime Ripard <mripard@redhat.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/ztfogof2dhtlvjwe73mvd2jp5kbldhkkav7k5culuseqblwpti@qfobohwx3c3j
      062ff85b
    • Linus Torvalds's avatar
      Merge tag 'perf-tools-fixes-for-v6.5-2-2023-08-03' of... · c1a515d3
      Linus Torvalds authored
      Merge tag 'perf-tools-fixes-for-v6.5-2-2023-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools
      
      Pull perf tools fixes from Arnaldo Carvalho de Melo:
      
       - Fix segfault in the powerpc specific arch_skip_callchain_idx
         function. The patch doing the reference count init/exit that went
         into 6.5 missed this function.
      
       - Fix regression reading the arm64 PMU cpu slots in sysfs, a patch
         removing some code duplication ended up duplicating the /sysfs prefix
         for these files.
      
       - Fix grouping of events related to topdown, addressing a regression on
         the CSV output produced by 'perf stat' noticed on the downstream tool
         toplev.
      
       - Fix the uprobe_from_different_cu 'perf test' entry, it is failing
         when gcc isn't available, so we need to check that and skip the test
         if it is not installed.
      
      * tag 'perf-tools-fixes-for-v6.5-2-2023-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools:
        perf test parse-events: Test complex name has required event format
        perf pmus: Create placholder regardless of scanning core_only
        perf test uprobe_from_different_cu: Skip if there is no gcc
        perf parse-events: Only move force grouped evsels when sorting
        perf parse-events: When fixing group leaders always set the leader
        perf parse-events: Extra care around force grouped events
        perf callchain powerpc: Fix addr location init during arch_skip_callchain_idx function
        perf pmu arm64: Fix reading the PMU cpu slots in sysfs
      c1a515d3
    • Linus Torvalds's avatar
      Merge tag 'cxl-fixes-6.5-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl · 638c1913
      Linus Torvalds authored
      Pull cxl fixes from Vishal Verma:
      
       - Fixup the Sanitixe device ABI that was merged for v6.5 to hide some
         sysfs files when the necessary support is missing. Update the ABI
         documentation around this as well.
      
      * tag 'cxl-fixes-6.5-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl:
        cxl/memdev: Only show sanitize sysfs files when supported
        cxl/memdev: Document security state in kern-doc
        cxl/memdev: Improve sanitize ABI descriptions
      638c1913
    • Linus Torvalds's avatar
      Merge tag 'net-6.5-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 999f6631
      Linus Torvalds authored
      Pull networking fixes from Jakub Kicinski:
       "Including fixes from bpf and wireless.
      
        Nothing scary here. Feels like the first wave of regressions from v6.5
        is addressed - one outstanding fix still to come in TLS for the
        sendpage rework.
      
        Current release - regressions:
      
         - udp: fix __ip_append_data()'s handling of MSG_SPLICE_PAGES
      
         - dsa: fix older DSA drivers using phylink
      
        Previous releases - regressions:
      
         - gro: fix misuse of CB in udp socket lookup
      
         - mlx5: unregister devlink params in case interface is down
      
         - Revert "wifi: ath11k: Enable threaded NAPI"
      
        Previous releases - always broken:
      
         - sched: cls_u32: fix match key mis-addressing
      
         - sched: bind logic fixes for cls_fw, cls_u32 and cls_route
      
         - add bound checks to a number of places which hand-parse netlink
      
         - bpf: disable preemption in perf_event_output helpers code
      
         - qed: fix scheduling in a tasklet while getting stats
      
         - avoid using APIs which are not hardirq-safe in couple of drivers,
           when we may be in a hard IRQ (netconsole)
      
         - wifi: cfg80211: fix return value in scan logic, avoid page
           allocator warning
      
         - wifi: mt76: mt7615: do not advertise 5 GHz on first PHY of MT7615D
           (DBDC)
      
        Misc:
      
         - drop handful of inactive maintainers, put some new in place"
      
      * tag 'net-6.5-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (98 commits)
        MAINTAINERS: update TUN/TAP maintainers
        test/vsock: remove vsock_perf executable on `make clean`
        tcp_metrics: fix data-race in tcpm_suck_dst() vs fastopen
        tcp_metrics: annotate data-races around tm->tcpm_net
        tcp_metrics: annotate data-races around tm->tcpm_vals[]
        tcp_metrics: annotate data-races around tm->tcpm_lock
        tcp_metrics: annotate data-races around tm->tcpm_stamp
        tcp_metrics: fix addr_same() helper
        prestera: fix fallback to previous version on same major version
        udp: Fix __ip_append_data()'s handling of MSG_SPLICE_PAGES
        net/mlx5e: Set proper IPsec source port in L4 selector
        net/mlx5: fs_core: Skip the FTs in the same FS_TYPE_PRIO_CHAINS fs_prio
        net/mlx5: fs_core: Make find_closest_ft more generic
        wifi: brcmfmac: Fix field-spanning write in brcmf_scan_params_v2_to_v1()
        vxlan: Fix nexthop hash size
        ip6mr: Fix skb_under_panic in ip6mr_cache_report()
        s390/qeth: Don't call dev_close/dev_open (DOWN/UP)
        net: tap_open(): set sk_uid from current_fsuid()
        net: tun_chr_open(): set sk_uid from current_fsuid()
        net: dcb: choose correct policy to parse DCB_ATTR_BCN
        ...
      999f6631
    • Jakub Kicinski's avatar
      MAINTAINERS: update TUN/TAP maintainers · 0765c5f2
      Jakub Kicinski authored
      Willem and Jason have agreed to take over the maintainer
      duties for TUN/TAP, thank you!
      
      There's an existing entry for TUN/TAP which only covers
      the user mode Linux implementation.
      Since we haven't heard from Maxim on the list for almost
      a decade, extend that entry and take it over, rather than
      adding a new one.
      Acked-by: default avatarWillem de Bruijn <willemb@google.com>
      Acked-by: default avatarJason Wang <jasowang@redhat.com>
      Link: https://lore.kernel.org/r/20230802182843.4193099-1-kuba@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      0765c5f2