1. 08 Oct, 2010 27 commits
    • Paul Walmsley's avatar
      OMAP: McBSP: implement McBSP CLKR and FSR signal muxing via mach-omap2/mcbsp.c · cf4c87ab
      Paul Walmsley authored
      The OMAP ASoC McBSP code implemented CLKR and FSR signal muxing via
      direct System Control Module writes on OMAP2+.  This required the
      omap_ctrl_{read,write}l() functions to be exported, which is against
      policy: the only code that should call those functions directly is
      OMAP core code, not device drivers.  omap_ctrl_{read,write}*() are no
      longer exported, so the driver no longer builds as a module.
      
      Fix the pinmuxing part of the problem by removing calls to
      omap_ctrl_{read,write}l() from the OMAP ASoC McBSP code and
      implementing signal muxing functions in arch/arm/mach-omap2/mcbsp.c.
      Due to the unfortunate way that McBSP support is implemented in ASoC
      and the OMAP tree, these symbols must be exported for use by
      sound/soc/omap/omap-mcbsp.c.
      
      Going forward, the McBSP device driver should be moved from
      arch/arm/*omap* into drivers/ or sound/soc/*, and the CPU DAI driver
      should be implemented as a platform_driver as many other ASoC CPU DAI
      drivers are.  These two steps should resolve many of the layering
      problems, which will rapidly reappear during a McBSP hwmod/PM runtime
      conversion.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      Acked-by: default avatarJarkko Nikula <jhnikula@gmail.com>
      Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@nokia.com>
      Acked-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
      Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      cf4c87ab
    • Paul Walmsley's avatar
      OMAP3xxx: clock: add clkdev aliases for McBSP fclk source switching · 829e5b12
      Paul Walmsley authored
      The OMAP3 clock tree already contains the infrastructure to support
      clock framework-based McBSP functional clock source switching.  But it
      did not contain the clkdev aliases for the McBSP code to refer to the
      parent clocks in an SoC integration-neutral way.  So, add the clkdev
      aliases for the parent clocks.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      829e5b12
    • Paul Walmsley's avatar
      OMAP2430: clock: add MCBSP_CLKS node and clkdev aliases · b115b743
      Paul Walmsley authored
      Add the MCBSP_CLKS clock and the clksel structures needed to support clock
      framework-based source switching for McBSPs 1-5.  Also, add clkdev
      aliases on the parent clocks for the McBSP source switching code, added
      in a subsequent patch.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      b115b743
    • Paul Walmsley's avatar
      OMAP2420: clock: add MCBSP_CLKS node and clkdev aliases · 1bccb345
      Paul Walmsley authored
      Add the MCBSP_CLKS clock and the clksel structures needed to support clock
      framework-based source switching for McBSP 1 and 2.  Also, add clkdev
      aliases on the parent clocks for the McBSP source switching code, added
      in a subsequent patch.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      1bccb345
    • Paul Walmsley's avatar
      OMAP2420: CTRL: fix OMAP242X_CTRL_REGADDR macro · 54164bb2
      Paul Walmsley authored
      Conform the OMAP2420_CTRL_BASE macro name to the standard of the rest of the
      OMAP*_CTRL_BASE macro names.  This fixes a bug in the OMAP2420 SCM code that
      prevented OMAP242X_CTRL_REGADDR from working.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      54164bb2
    • Paul Walmsley's avatar
      OMAP2+: Kconfig: disallow builds for boards that don't use the currently-selected SoC · 6515e489
      Paul Walmsley authored
      Currently, if, for example, CONFIG_ARCH_OMAP2420 is not selected, OMAP2420
      board files can still be included in the build.  This results in link errors:
      
      arch/arm/mach-omap2/built-in.o: In function `omap_generic_map_io':
      .../arch/arm/mach-omap2/board-generic.c:51: undefined reference to `omap2_set_globals_242x'
      arch/arm/mach-omap2/built-in.o: In function `omap_h4_init':
      .../arch/arm/mach-omap2/board-h4.c:330: undefined reference to `omap2420_mux_init'
      arch/arm/mach-omap2/built-in.o: In function `omap_h4_map_io':
      .../arch/arm/mach-omap2/board-h4.c:373: undefined reference to `omap2_set_globals_242x'
      arch/arm/mach-omap2/built-in.o: In function `omap_apollon_init':
      .../arch/arm/mach-omap2/board-apollon.c:325: undefined reference to `omap2420_mux_init'
      arch/arm/mach-omap2/built-in.o: In function `omap_apollon_map_io':
      .../arch/arm/mach-omap2/board-apollon.c:353: undefined reference to `omap2_set_globals_242x'
      make: *** [.tmp_vmlinux1] Error 1
      
      Fix this by making the boards depend on the Kconfig option for the
      specific SoC that they use.
      
      Also, while here, fix the mach-omap2/board-generic.c file to remove the
      dependency on OMAP2420.
      
      Charulatha Varadarajan <charu@ti.com> caught a typo - thanks Charu.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Charulatha Varadarajan <charu@ti.com>
      6515e489
    • Tony Lindgren's avatar
      omap: Update omap2plus_defconfig to use ttyO instead ttyS · 6f911492
      Tony Lindgren authored
      With the omap-serial the device has changed from ttyS to ttyO as
      the system may have both omap-serial and 8250 ports.
      
      Note that systems using omap-serial need to be updated to use ttyO[012]
      instead of ttyS[012] in the bootloader, CONFIG_CMDLINE, /etc/inittab,
      and the root file system with mknod. Also you may need to add ttyO[012]
      to /etc/securetty.
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      6f911492
    • Kevin Hilman's avatar
      OMAP2: PM: check UART status before trying to idle · 503923ee
      Kevin Hilman authored
      As is done on OMAP3, check omap_uart_can_sleep() as one of the
      pre-conditions for entering the idle loop.  Without this check,
      entering idle introduces large latencies on active UARTs, and is
      especially noticable on serial console.
      Signed-off-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      503923ee
    • Rajendra Nayak's avatar
      omap: hwmod: Handle modules with 16bit registers · cc7a1d2a
      Rajendra Nayak authored
      Some modules which have 16bit registers can cause imprecise
      aborts if a __raw_readl/writel is used to read/write 32 bits.
      
      Add an additional flag to identify modules which have such
      hard requirement, and handle it in the hwmod framework.
      Signed-off-by: default avatarRajendra Nayak <rnayak@ti.com>
      Acked-by: default avatarPaul Walmsley <paul@pwsan.com>
      Tested-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      cc7a1d2a
    • Nicolas Kaiser's avatar
      arm/omap: remove duplicated include · c710e192
      Nicolas Kaiser authored
      Remove duplicated include.
      Signed-off-by: default avatarNicolas Kaiser <nikai@nikai.net>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      c710e192
    • Charulatha V's avatar
      OMAP2PLUS: WDT: Fix: Disable WDT after reset during init · 20252d46
      Charulatha V authored
      Inorder to avoid any assumptions from bootloader, the watchdog
      timer module is reset during init. This enables the watchdog
      timer.
      
      Therefore, it is required to disable WDT after it is reset
      during init. Otherwise the system would reboot as per the default
      watchdog timer registers settings.
      
      Later, when the watchdog driver is loaded, the watchdog timer settings
      is adjusted as per the default timer_margin set in the driver and the
      driver would supports the normal operations supported by OMAP watchdog
      timer.
      Signed-off-by: default avatarCharulatha V <charu@ti.com>
      Reported-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
      Acked-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      20252d46
    • Enric Balletbo i Serra's avatar
      omap3: Remove VMMC2 regulator on IGEP v2 · 72f381ba
      Enric Balletbo i Serra authored
      VMMC2 regulator is configured but it's not used for the IGEP v2, so
      remove this regulator from board.
      Signed-off-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      72f381ba
    • Enric Balletbo i Serra's avatar
      omap3: Add i2c eeprom driver to read EDID on IGEP v2 · 91d139cf
      Enric Balletbo i Serra authored
      Add i2c eeprom driver to access monitor EDID binary information
      from user space, something that is required by 'decode-edid' and
      'parse-edid'.
      Signed-off-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      91d139cf
    • Enric Balletbo i Serra's avatar
      omap3: Fix handling some GPIO's for WLAN-BT combo on IGEP v2 · 5a9fcc99
      Enric Balletbo i Serra authored
      Some GPIO's used by WLAN-BT combo on IGEP v2 depends on hardware
      revision. This patch handles these GPIO's.
      
        ----------------------------------------------------------
       |       Hw Rev.       | WIFI_NPD | WIFI_NRESET | BT_NRESET |
        ----------------------------------------------------------
       |  B                  | gpio94  |   gpio95    |     -      |
       |  B/C (B-compatible) | gpio94  |   gpio95    |  gpio137   |
       |  C                  | gpio138 |   gpio139   |  gpio137   |
        ----------------------------------------------------------
      Signed-off-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      5a9fcc99
    • Enric Balletbo i Serra's avatar
      omap3: Introduce function to detect the IGEP v2 hardwarerevision · 3f8c48d9
      Enric Balletbo i Serra authored
      There are currently two versions of IGEP v2 board, this patch introduces a
      function to detect the hardware revision of IGEP board.
      
        --------------------------
       | Id. | Hw Rev. | GPIO 28  |
        --------------------------
       |  0  |   B/C   |   high   |
       |  1  |   C     |   low    |
        --------------------------
      Signed-off-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      3f8c48d9
    • Enric Balletbo i Serra's avatar
      omap3: fix and improve the LED handling on IGEP v2 board · bee15390
      Enric Balletbo i Serra authored
      The IGEP v2 board has four leds, this patch allows control all
      of these LEDs using the LED class if CONFIG_LEDS_GPIO is selected
      or using the General Purpose Input/Output (GPIO) interface if
      CONFIG_LEDS_GPIO is not selected.
      Signed-off-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      bee15390
    • Enric Balletbo i Serra's avatar
      omap3: Add external VBUS power switch and overcurrent detect onIGEP v2 board · 61e118dd
      Enric Balletbo i Serra authored
      GPIO for various devices are missing from the board initialization.
      This patch adds support for the VBUS and over current gpios.  Without this
      patch, input/outputs from these two sources are ignored.
      Signed-off-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      61e118dd
    • Enric Balletbo i Serra's avatar
      omap3: Add minimal OMAP3 IGEP module support · e844b1da
      Enric Balletbo i Serra authored
      The OMAP3 IGEP module is a low-power, high performance production-ready
      system-on-module (SOM) based on TI's OMAP3 family. More about this
      board at www.igep.es.
      Signed-off-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
      [tony@atomide.com: updated for the mmc changes and to be selected by default]
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      e844b1da
    • Tony Lindgren's avatar
      Merge branch 'pm-hwmods' of... · bc3caae8
      Tony Lindgren authored
      Merge branch 'pm-hwmods' of ssh://master.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm into omap-for-linus
      bc3caae8
    • Tony Lindgren's avatar
    • Tony Lindgren's avatar
      Merge branch 'pm-next-2' of... · 582c77d7
      Tony Lindgren authored
      Merge branch 'pm-next-2' of ssh://master.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm into omap-for-linus
      582c77d7
    • Manjunath Kondaiah G's avatar
      OMAP3: Keypad: Fix incorrect type initializer · bead4375
      Manjunath Kondaiah G authored
      The keypad matrix variable declaration is not matching
      with structure variable keymap declared in keypad_matrix.h.
      
      Due to this, following sparse warnings are generated with omap3_defconfig.
      
      arch/arm/mach-omap2/board-devkit8000.c:223:14: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-devkit8000.c:223:14:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-devkit8000.c:223:14:    got int static [toplevel] *<noident>
      
      arch/arm/mach-omap2/board-ldp.c:107:14: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-ldp.c:107:14:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-ldp.c:107:14:    got int static [toplevel] *<noident>
      
      arch/arm/mach-omap2/board-omap3evm.c:472:14: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-omap3evm.c:472:14:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-omap3evm.c:472:14:    got int static [toplevel] *<noident>
      
      arch/arm/mach-omap2/board-3430sdp.c:114:14: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-3430sdp.c:114:14:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-3430sdp.c:114:14:    got int static [toplevel] *<noident>
      
      arch/arm/mach-omap2/board-rx51-peripherals.c:248:14: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-rx51-peripherals.c:248:14:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-rx51-peripherals.c:248:14:    got int static [toplevel] *<noident>
      
      arch/arm/mach-omap2/board-zoom-peripherals.c:88:14: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-zoom-peripherals.c:88:14:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-zoom-peripherals.c:88:14:    got int static [toplevel] *<noident>
      
      arch/arm/mach-omap2/board-cm-t35.c:568:14: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-cm-t35.c:568:14:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-cm-t35.c:568:14:    got int static [toplevel] *<noident>
      
      arch/arm/mach-omap2/board-omap3stalker.c:415:13: warning: incorrect type in initializer (different signedness)
      arch/arm/mach-omap2/board-omap3stalker.c:415:13:    expected unsigned int const [usertype] *keymap
      arch/arm/mach-omap2/board-omap3stalker.c:415:13:    got int static [toplevel] *<noident>
      
      This patch modifies the variable keymap declaration as per declaration in matrix_keymap structure.
      Signed-off-by: default avatarManjunath Kondaiah G <manjugk@ti.com>
      Cc: linux-input@vger.kernel.org
      Cc: Dmitry Torokhov <dtor@mail.ru>
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: Nishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      bead4375
    • Manjunath Kondaiah G's avatar
      OMAP: plat-omap: Fix static function warnings · b0a330dc
      Manjunath Kondaiah G authored
      This patch fixes sparse warnings due non declarations of static functions.
      
      arch/arm/plat-omap/sram.c:130:13: warning: symbol 'omap_detect_sram' was not declared. Should it be static?
      arch/arm/plat-omap/sram.c:216:13: warning: symbol 'omap_map_sram' was not declared. Should it be static?
      arch/arm/plat-omap/sram.c:450:12: warning: symbol 'omap_sram_init' was not declared. Should it be static?
      arch/arm/plat-omap/sram.c:348:12: warning: symbol 'omap242x_sram_init' was not declared. Should it be static?
      arch/arm/plat-omap/sram.c:369:12: warning: symbol 'omap243x_sram_init' was not declared. Should it be static?
      arch/arm/plat-omap/sram.c:425:12: warning: symbol 'omap34xx_sram_init' was not declared. Should it be static?
      arch/arm/plat-omap/sram.c:441:12: warning: symbol 'omap44xx_sram_init' was not declared. Should it be static
      
      arch/arm/plat-omap/mcbsp.c:36:6: warning: symbol 'omap_mcbsp_write' was not declared. Should it be static?
      arch/arm/plat-omap/mcbsp.c:50:5: warning: symbol 'omap_mcbsp_read' was not declared. Should it be static?
      arch/arm/plat-omap/mcbsp.c:65:6: warning: symbol 'omap_mcbsp_st_write' was not declared. Should it be static?
      arch/arm/plat-omap/mcbsp.c:70:5: warning: symbol 'omap_mcbsp_st_read' was not declared. Should it be static?
      arch/arm/plat-omap/mcbsp.c:1648:15: warning: symbol 'omap_st_add' was not declared. Should it be static?
      
      arch/arm/plat-omap/fb.c:414:15: warning: symbol 'omapfb_reserve_sram' was not declared. Should it be static?
      arch/arm/plat-omap/cpu-omap.c:43:5: warning: symbol 'omap_verify_speed' was not declared. Should it be static?
      arch/arm/plat-omap/cpu-omap.c:61:14: warning: symbol 'omap_getspeed' was not declared. Should it be static?
      Signed-off-by: default avatarManjunath Kondaiah G <manjugk@ti.com>
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: Nishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      b0a330dc
    • Manjunath Kondaiah G's avatar
      OMAP: mach-omap2: Fix miscellaneous sparse warnings · 600ecd98
      Manjunath Kondaiah G authored
      This patch fixes miscellaneous sparse warnings in mach-omap2.
      
      arch/arm/mach-omap2/board-am3517evm.c:141:17: warning: Initializer entry defined twice
      arch/arm/mach-omap2/board-am3517evm.c:142:18:   also defined here
      
      arch/arm/mach-omap2/irq.c:50:35: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarManjunath Kondaiah G <manjugk@ti.com>
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: Nishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      600ecd98
    • Manjunath Kondaiah G's avatar
      OMAP2plus: Fix static function warnings · 04aeae77
      Manjunath Kondaiah G authored
      This patch fixes sparse warnings due non declarations of static functions.
      
      arch/arm/mach-omap2/timer-gp.c:115:12: warning: symbol 'omap2_gp_clockevent_set_gptimer' was not declared. Should it be static?
      arch/arm/mach-omap2/powerdomain.c:993:5: warning: symbol 'pwrdm_set_lowpwrstchange' was not declared. Should it be static?
      arch/arm/mach-omap2/board-flash.c:141:8: warning: symbol 'board_nand_init' was not declared. Should it be static?
      arch/arm/mach-omap2/board-n8x0.c:416:6: warning: symbol 'n8x0_mmc_slot1_cover_handler' was not declared. Should it be static?
      arch/arm/mach-omap2/board-n8x0.c:544:13: warning: symbol 'n8x0_mmc_init' was not declared. Should it be static?
      arch/arm/mach-omap2/board-rx51-peripherals.c:902:13: warning: symbol 'rx51_peripherals_init' was not declared. Should it be static?
      arch/arm/mach-omap2/board-rx51-video.c:107:13: warning: symbol 'rx51_video_mem_init' was not declared. Should it be static?
      arch/arm/mach-omap2/board-zoom-debugboard.c:155:12: warning: symbol 'zoom_debugboard_init' was not declared. Should it be static?
      arch/arm/mach-omap2/board-zoom-peripherals.c:280:13: warning: symbol 'zoom_peripherals_init' was not declared. Should it be static?
      arch/arm/mach-omap2/board-igep0020.c:110:13: warning: symbol 'igep2_flash_init' was not declared. Should it be static?
      arch/arm/mach-omap2/board-am3517evm.c:109:6: warning: symbol 'am3517_evm_ethernet_init' was not declared. Should it be static?
      drivers/mtd/onenand/omap2.c:577:5: warning: symbol 'omap2_onenand_rephase' was not declared. Should it be static?
      Signed-off-by: default avatarManjunath Kondaiah G <manjugk@ti.com>
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: Nishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      04aeae77
    • Manjunath Kondaiah G's avatar
      OMAP: mach-omap2: Fix static declaration warnings · 38815733
      Manjunath Kondaiah G authored
      This patch fixes sparse warnings due to non declaration of
      static structures and variables.
      
      Sparse warning logs fixed:
      arch/arm/mach-omap2/control.c:88:6: warning: symbol 'omap3_secure_ram_storage' was not declared. Should it be static?
      n
      arch/arm/mach-omap2/timer-gp.c:50:22: warning: symbol 'gptimer_wakeup' was not declared. Should it be static?
      arch/arm/mach-omap2/timer-gp.c:240:18: warning: symbol 'omap_timer' was not declared. Should it be static?
      arch/arm/mach-omap2/prcm.c:121:24: warning: symbol 'prcm_context' was not declared. Should it be static?
      arch/arm/mach-omap2/mux2420.c:510:29: warning: symbol 'omap2420_pop_ball' was not declared. Should it be static?
      arch/arm/mach-omap2/mux2430.c:589:29: warning: symbol 'omap2430_pop_ball' was not declared. Should it be static?
      arch/arm/mach-omap2/mux34xx.c:934:28: warning: symbol 'omap3_cus_subset' was not declared. Should it be static?
      arch/arm/mach-omap2/mux34xx.c:1080:29: warning: symbol 'omap3_cus_ball' was not declared. Should it be static?
      arch/arm/mach-omap2/mux34xx.c:1272:28: warning: symbol 'omap3_cbb_subset' was not declared. Should it be static?
      arch/arm/mach-omap2/mux34xx.c:1393:29: warning: symbol 'omap3_cbb_ball' was not declared. Should it be static?
      arch/arm/mach-omap2/mux34xx.c:1603:28: warning: symbol 'omap36xx_cbp_subset' was not declared. Should it be static?
      arch/arm/mach-omap2/mux34xx.c:1821:29: warning: symbol 'omap36xx_cbp_ball' was not declared. Should it be static?
      arch/arm/mach-omap2/pm-debug.c:165:15: warning: symbol 'pm_dbg_dir' was not declared. Should it be static?
      arch/arm/mach-omap2/board-omap3evm.c:587:30: warning: symbol 'ads7846_config' was not declared. Should it be static?
      arch/arm/mach-omap2/board-omap3evm.c:606:23: warning: symbol 'omap3evm_spi_board_info' was not declared. Should it be static?
      arch/arm/mach-omap2/board-rx51-sdram.c:46:25: warning: symbol 'rx51_sdrc_params' was not declared. Should it be static?
      arch/arm/mach-omap2/board-rx51-sdram.c:211:25: warning: symbol 'rx51_get_sdram_timings' was not declared. Should it be static?
      arch/arm/mach-omap2/board-omap3touchbook.c:64:15: warning: symbol 'touchbook_revision' was not declared. Should it be static?
      arch/arm/mach-omap2/board-am3517evm.c:350:24: warning: symbol 'am3517_evm_dss_device' was not declared. Should it be static?
      arch/arm/mach-omap2/board-omap3stalker.c:567:23: warning: symbol 'omap3stalker_spi_board_info' was not declared. Should it be static?
      Signed-off-by: default avatarManjunath Kondaiah G <manjugk@ti.com>
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: Nishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      38815733
    • Manjunath Kondaiah G's avatar
      OMAP: mach-omap2: Fix incorrect assignment warnings · 4d63bc1d
      Manjunath Kondaiah G authored
      This patch fixes below sparse warnings for incorrect assignments.
      
      arch/arm/mach-omap2/control.c:195:16: warning: incorrect type in assignment (different address spaces)
      arch/arm/mach-omap2/control.c:195:16:    expected unsigned int [usertype] *v_addr
      arch/arm/mach-omap2/control.c:195:16:    got void [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/control.c:199:25: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/control.c:199:25:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/control.c:199:25:    got unsigned int [usertype] *
      arch/arm/mach-omap2/control.c:320:28: warning: incorrect type in assignment (different address spaces)
      arch/arm/mach-omap2/control.c:320:28:    expected void *[noderef] <asn:2>scratchpad_address
      arch/arm/mach-omap2/control.c:320:28:    got void [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/control.c:321:9: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/control.c:321:9:    expected void volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/control.c:321:9:    got void *[noderef] <asn:2>scratchpad_address
      arch/arm/mach-omap2/control.c:324:9: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/control.c:324:9:    expected void volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/control.c:324:9:    got void *
      arch/arm/mach-omap2/control.c:327:9: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/control.c:327:9:    expected void volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/control.c:327:9:    got void *
      arch/arm/mach-omap2/control.c:334:9: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/control.c:334:9:    expected void volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/control.c:334:9:    got void *
      arch/arm/mach-omap2/control.c:321:9: warning: dereference of noderef expression
      arch/arm/mach-omap2/control.c:324:9: warning: dereference of noderef expression
      arch/arm/mach-omap2/control.c:327:9: warning: dereference of noderef expression
      arch/arm/mach-omap2/control.c:334:9: warning: dereference of noderef expression
      
      arch/arm/mach-omap2/pm34xx.c:323:28: warning: incorrect type in assignment (different address spaces)
      arch/arm/mach-omap2/pm34xx.c:323:28:    expected unsigned int [usertype] *scratchpad_address
      arch/arm/mach-omap2/pm34xx.c:323:28:    got void [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/pm34xx.c:326:26: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/pm34xx.c:326:26:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/pm34xx.c:326:26:    got unsigned int [usertype] *
      arch/arm/mach-omap2/pm34xx.c:329:26: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/pm34xx.c:329:26:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/pm34xx.c:329:26:    got unsigned int [usertype] *
      arch/arm/mach-omap2/pm34xx.c:334:29: warning: incorrect type in argument 1 (different address spaces)
      arch/arm/mach-omap2/pm34xx.c:334:29:    expected void const volatile [noderef] <asn:2>*<noident>
      arch/arm/mach-omap2/pm34xx.c:334:29:    got unsigned int [usertype] *
      Signed-off-by: default avatarManjunath Kondaiah G <manjugk@ti.com>
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: Nishanth Menon <nm@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      4d63bc1d
  2. 04 Oct, 2010 1 commit
  3. 01 Oct, 2010 12 commits