- 03 Aug, 2023 2 commits
-
-
Dmitry Baryshkov authored
All DSC_BLK_1_2 declarations incorrectly pass 0x29c as the block length. This includes the common block itself, enc subblocks and some empty space around. Change that to pass 0x4 instead, the length of common register block itself. Fixes: 0d1b10c6 ("drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets") Reported-by:
Ryan McCann <quic_rmccann@quicinc.com> Reviewed-by:
Abhinav Kumar <quic_abhinavk@quicinc.com> Signed-off-by:
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by:
Marijn Suijten <marijn.suijten@somainline.org> Patchwork: https://patchwork.freedesktop.org/patch/550998/ Link: https://lore.kernel.org/r/20230802183655.4188640-1-dmitry.baryshkov@linaro.org
-
Jonathan Marek authored
sm8550 has 16 vbif clients. This fixes the extra 2 clients (DMA4/DMA5) not having their memtype initialized. This fixes DMA4/DMA5 planes not displaying correctly. Fixes: efcd0107 ("drm/msm/dpu: add support for SM8550") Signed-off-by:
Jonathan Marek <jonathan@marek.ca> Reviewed-by:
-
- 02 Aug, 2023 24 commits
-
-
Dmitry Baryshkov authored
This function does nothing, just clears one struct field. Drop it now. Acked-by:
Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by:
-
Dmitry Baryshkov authored
dpu_core_perf should not make decisions on the maximum possible core clock rate. Pass the value from dpu_kms_hw_init() and drop handling of core_clk from dpu_core_perf.c Reviewed-by:
-
Dmitry Baryshkov authored
The dev_pm_opp_set_rate() already contains a call for clk_round_rate for the passed value. Stop calling it manually from _dpu_core_perf_get_core_clk_rate(). It is slightly incorrect to call it this way, as we should round the final calculated clock rate rather than rounding all the intermediate values. Reviewed-by:
-
Dmitry Baryshkov authored
Remove dpu_core_perf::dev and dpu_core_perf::debugfs_root fields, they are not used by the code. Reviewed-by:
-
Dmitry Baryshkov authored
Simplify dpu_core_perf code by using only dpu_perf_cfg instead of using full-featured catalog data. Acked-by:
-
Dmitry Baryshkov authored
The stop_req is true only in the dpu_crtc_disable() case, when crtc->enable has already been set to false. This renders the stop_req argument useless. Remove it completely. Reviewed-by:
-
Dmitry Baryshkov authored
dpu_core_perf.c contains several multi-line conditions which are hard to comprehent because of the indentation. Rework the identation of these conditions to make it easier to understand them. Reviewed-by:
-
Dmitry Baryshkov authored
The values in struct dpu_core_perf_tune are fixed per the core perf mode. Drop the 'tune' values and substitute them with known values when performing perf management. Note: min_bus_vote was not used at all, so it is just silently dropped. Reviewed-by:
-
Dmitry Baryshkov authored
Skip bandwidth aggregation and return early if there are no interconnect paths defined for the DPU device. Signed-off-by:
-
Dmitry Baryshkov authored
Drop the leftover of bus-client -> interconnect conversion, the enum dpu_core_perf_data_bus_id. Fixes: cb88482e ("drm/msm/dpu: clean up references of DPU custom bus scaling") Reviewed-by:
-
Dmitry Baryshkov authored
The feature bits DPU_MDP_BWC, DPU_MDP_UBWC_1_0, and DPU_MDP_UBWC_1_5 are not used by the driver, drop them completely. Signed-off-by:
-
Dmitry Baryshkov authored
As the DPU driver has switched to fetching data from MDSS driver, we can now drop the UBWC and highest_bank_bit parts of the DPU hw catalog. Reviewed-by:
-
Dmitry Baryshkov authored
Switch to using data from MDSS driver to program the SSPP fetch and UBWC configuration. As a side-effect, this also swithes the DPU driver from DPU_HW_UBWC_VER_xx values to the UBWC_x_y enum, which reflects the hardware register values. Signed-off-by:
-
Dmitry Baryshkov authored
As we are going to use MDSS data for DPU programming, populate missing MDSS data. The UBWC 1.0 and no UBWC cases do not require MDSS programming, so skip them. Signed-off-by:
-
Dmitry Baryshkov authored
DPU programming requires knowledge of some of UBWC parameters. This results in duplication of UBWC data between MDSS and DPU drivers. Export the required data from MDSS driver. Reviewed-by:
-
Dmitry Baryshkov authored
Rename the ubwc_version field to ubwc_enc_version, it denotes the version of the UBWC encoder, not the "UBWC version". Reviewed-by:
-
Dmitry Baryshkov authored
The SM8550 platform employs newer UBWC decoder, which requires slightly different programming. Fixes: a2f33995 ("drm/msm: mdss: add support for SM8550") Signed-off-by:
-
Dmitry Baryshkov authored
While reworking interrupts masks, it was easier to keep old MDP_INTFn_7xxx_INTR and MDP_INTFn_7xxx_TEAR_INTR symbols. Now it is time to drop them and use unified symbol names. Reviewed-by:
Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by:
-
Dmitry Baryshkov authored
Now as the list of the interrupts is constructed from the catalog data, drop the mdss_irqs field from catalog. Reviewed-by:
-
Dmitry Baryshkov authored
Declaring the mask of supported interrupts proved to be error-prone. It is very easy to add a bit with no corresponding backing block or to miss the INTF TE bit. Replace this with looping over the enabled INTF blocks to setup the irq mask. Reviewed-by:
-
Dmitry Baryshkov authored
There is no point in having a single enum (and a single array) for both DPU < 7.0 and DPU >= 7.0 interrupt registers. Instead define a single enum and two IRQ address arrays. Reviewed-by:
-
Dmitry Baryshkov authored
Inline __intr_offset(), there is no point in having a separate oneline function for setting base block address. Reviewed-by:
-
Ruan Jinjie authored
There is no need to call the DRM_DEV_ERROR() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by:
Ruan Jinjie <ruanjinjie@huawei.com> Reviewed-by:
-
Amit Pundir authored
Add and document the reserved memory region property in the mdss-common schema. For now (sdm845-db845c), it points to a framebuffer memory region reserved by the bootloader for splash screen. Acked-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Amit Pundir <amit.pundir@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/549376/ Link: https://lore.kernel.org/r/20230726132719.2117369-1-amit.pundir@linaro.orgSigned-off-by:
-
- 27 Jul, 2023 14 commits
-
-
Marijn Suijten authored
SM6125 features only a single PHY (despite a secondary PHY PLL source being available to the disp_cc_mdss_pclk0_clk_src clock), and downstream sources for this "trinket" SoC do not define the typical "vcca" regulator to be available nor used. This, including the register offset is identical to QCM2290, whose config struct can trivially be reused. Reviewed-by:
-
Marijn Suijten authored
Document availability of the 14nm DSI PHY on SM6125. Note that this compatible uses the SoC-suffix variant, intead of postfixing an arbitrary number without the sm/sdm portion. The PHY is not powered by a vcca regulator like on most SoCs, but by the MX power domain that is provided via the power-domains property and a single corresponding required-opps. Acked-by:
-
Marijn Suijten authored
SM6125 has an UBWC 3.0 decoder but only an UBWC 1.0 encoder. Reviewed-by:
-
Marijn Suijten authored
Add definitions for the display hardware used on the Qualcomm SM6125 platform. Reviewed-by:
-
Marijn Suijten authored
Document the SM6125 MDSS. Reviewed-by:
-
Marijn Suijten authored
SM6125 is identical to SM6375 including the throttle clock that is also provided to the MDP node downstream. Note that any SoC other than SM6375 (currently SC7180 and SM6350) has an unconstrained maximum number of clocks and could either pass or leave out this "throttle" clock. Signed-off-by:
-
Marijn Suijten authored
Document general compatibility of the DSI controller on SM6125. Reviewed-by:
-
Marijn Suijten authored
On SM6125 the dispcc block is gated behind VDDCX: allow this domain to be configured. Acked-by:
-
Marijn Suijten authored
The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will be passed from DT, and should be required by the bindings. Fixes: 8397c9c0 ("dt-bindings: clock: add QCOM SM6125 display clock bindings") Reviewed-by:
-
Marijn Suijten authored
Both SM6350 and SM6375 support only a single DSI link, and don't have a corresponding dsi1 node in DTS. Their examples should not suggest an output interface port on the display-controller node to this inexistant DSI host, with a dsi1_in label reference that doesn't exist in the example either. Fixes: 3b7502b0 ("dt-bindings: display/msm: Add SM6350 MDSS") Fixes: 2a5c1021 ("dt-bindings: display/msm: Add SM6375 MDSS") Signed-off-by:
-
Marijn Suijten authored
The regulator setup was likely copied from other SoCs by mistake. Just like SM6125 the DSI PHY on this platform is not getting power from a regulator but from the MX power domain. Fixes: 572e9fd6 ("drm/msm/dsi: Add phy configuration for QCM2290") Reviewed-by:
-
Abhinav Kumar authored
Now that all usages of DPU_INTF_DATA_COMPRESS have been replaced with the dpu core's major revision lets drop DPU_INTF_DATA_COMPRESS from the catalog completely. Signed-off-by:
-
Abhinav Kumar authored
Rename the intf's enable_compression() op to program_intf_cmd_cfg() and allow it to accept a struct intf_cmd_mode_cfg to program all the bits at once. This can be re-used by widebus later on as well as it touches the same register. changes in v5: - rename struct intf_cmd_mode_cfg to dpu_hw_intf_cmd_mode_cfg - remove couple of comments Signed-off-by:
-
Abhinav Kumar authored
dpu_hw_intf has a few instances of structs which do not have the dpu_hw prefix. Lets fix this by renaming those structs and updating the usage of those accordingly. Signed-off-by:
-
