1. 08 Apr, 2021 7 commits
  2. 07 Apr, 2021 8 commits
  3. 06 Apr, 2021 5 commits
  4. 02 Apr, 2021 6 commits
  5. 01 Apr, 2021 7 commits
    • Mac Chiang's avatar
    • Zhen Lei's avatar
      ASoC: intel, keembay-i2s: Fix a dt_binding_check warning · 52cad756
      Zhen Lei authored
      The property "dmas" contains two items: DMA "TX" and "RX" channel,
      Therefore, its value also needs to be written in two parts.
      
      Otherwise, below YAML check warning is reported:
      Documentation/devicetree/bindings/sound/intel,keembay-i2s.example.dt.yaml:\
      i2s@20140000: dmas: [[4294967295, 29, 4294967295, 33]] is too short
      Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
      Acked-by: default avatarRob Herring <robh@kernel.org>
      Link: https://lore.kernel.org/r/20210329081435.2200-1-thunder.leizhen@huawei.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      52cad756
    • Bhaskar Chowdhury's avatar
    • Mark Brown's avatar
      Merge series "ASoC: remove cppchecks warnings on lm49453 and da732x" from... · df421a3a
      Mark Brown authored
      Merge series "ASoC: remove cppchecks warnings on lm49453 and da732x" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:
      
      There are the last two patches in the cleanups, this time I am not
      sure what the code does and what the proper fix might be. Feedback
      welcome.
      
      Pierre-Louis Bossart (2):
        ASoC: lm49453: fix useless assignment before return
        ASoC: da732x: simplify code
      
       sound/soc/codecs/da732x.c  | 17 ++++++-----------
       sound/soc/codecs/da732x.h  | 12 ++++--------
       sound/soc/codecs/lm49453.c |  2 --
       3 files changed, 10 insertions(+), 21 deletions(-)
      
      --
      2.25.1
      df421a3a
    • Mark Brown's avatar
      Merge series "ASoC: dt-bindings: Rework audio-graph-port schema" from Rob... · 75c324d5
      Mark Brown authored
      Merge series "ASoC: dt-bindings: Rework audio-graph-port schema" from Rob Herring <robh@kernel.org>:
      
      This series refactors the audio-graph-port.yaml schema moving the
      'port' node out of the schema and updating to use graph.yaml schema.
      This allows users to define what each 'port' node is like other graph
      binding users.
      
      v2:
      - Rebase on ASoC tree
      
      Rob
      
      Cc: alsa-devel@alsa-project.org
      Cc: linux-tegra@vger.kernel.org
      Cc: Jonathan Hunter <jonathanh@nvidia.com>
      Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Cc: Lubomir Rintel <lkundrak@v3.sk>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
      Cc: Sameer Pujar <spujar@nvidia.com>
      Cc: Thierry Reding <thierry.reding@gmail.com>
      
      Rob Herring (3):
        ASoC: dt-bindings: Move port/ports properties out of
          audio-graph-port.yaml
        ASoC: dt-bindings: Use OF graph schema
        ASoC: dt-bindings: socionext: Use audio-graph-port schema
      
       .../bindings/sound/audio-graph-port.yaml      | 104 ++++++++----------
       .../bindings/sound/marvell,mmp-sspa.yaml      |   6 +-
       .../bindings/sound/nvidia,tegra186-dspk.yaml  |  11 +-
       .../sound/nvidia,tegra210-admaif.yaml         |  11 +-
       .../bindings/sound/nvidia,tegra210-ahub.yaml  |  11 +-
       .../bindings/sound/nvidia,tegra210-dmic.yaml  |  11 +-
       .../bindings/sound/nvidia,tegra210-i2s.yaml   |  11 +-
       .../bindings/sound/renesas,rsnd.yaml          |   5 +-
       .../sound/socionext,uniphier-aio.yaml         |   8 +-
       .../sound/socionext,uniphier-evea.yaml        |   8 +-
       10 files changed, 89 insertions(+), 97 deletions(-)
      
      --
      2.27.0
      75c324d5
    • Mark Brown's avatar
      Merge series "ASoC: soc-core: tidyup error handling for rtd" from Kuninori... · 73935e93
      Mark Brown authored
      Merge series "ASoC: soc-core: tidyup error handling for rtd" from Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>:
      
      Hi Mark
      
      These are small clanup patches for soc-core.
      [1/2] patch adds missing explanation, and
      [2/2] patch fixup error handling of rtd.
      
      Kuninori Morimoto (2):
        ASoC: soc-core: add comment for rtd freeing
        ASoC: soc-core: use device_unregister() if rtd allocation failed
      
       sound/soc/soc-core.c | 14 ++++++++++++--
       1 file changed, 12 insertions(+), 2 deletions(-)
      
      --
      2.25.1
      73935e93
    • Mark Brown's avatar
      Merge series "ASoC: remove cppcheck warnings for multiple SOCs" from... · 9c0da293
      Mark Brown authored
      Merge series "ASoC: remove cppcheck warnings for multiple SOCs" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:
      
      Trivial cleanups to make cppcheck less verbose.
      
      There should be no functionality change, except for the 'sti_uniperif'
      patch where an error check was added.
      
      Pierre-Louis Bossart (17):
        ASoC: amd: renoir: acp3x-pdm-dma: remove unnecessary assignments
        ASoC: atmel: fix shadowed variable
        ASoC: atmel: atmel-i2s: remove useless initialization
        ASoC: bcm: cygnus_ssp: remove useless initialization
        ASoC: meson: axg-tdmin: remove useless assignment
        ASoC: meson: axg-tdmout: remove useless assignment
        ASoC: pxa: remove useless assignment
        ASoC: sti: sti_uniperif: add missing error check
        ASoC: sti: uniperif: align function prototypes
        ASoC: stm: stm32_adfsdm: fix snprintf format string
        ASoC: sunxi: sun8i-codec: clarify expression
        ASoC: tegra: tegra20_das: clarify expression
        ASoC: tegra: tegra20_das: align function prototypes
        ASoC: ti: omap-abe-twl6040: remove useless assignment
        ASoC: ti: omap-mcsp: remove duplicate test
        ASoC: ux500: mop500: rename shadowing variable
        ASoC: ux500: mop500: align function prototype
      
       sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 --
       sound/soc/atmel/atmel-classd.c       | 6 +++---
       sound/soc/atmel/atmel-i2s.c          | 2 +-
       sound/soc/bcm/cygnus-ssp.c           | 2 +-
       sound/soc/meson/axg-tdmin.c          | 2 +-
       sound/soc/meson/axg-tdmout.c         | 2 +-
       sound/soc/pxa/mmp-pcm.c              | 2 +-
       sound/soc/sti/sti_uniperif.c         | 2 ++
       sound/soc/sti/uniperif.h             | 4 ++--
       sound/soc/stm/stm32_adfsdm.c         | 2 +-
       sound/soc/sunxi/sun8i-codec.c        | 2 +-
       sound/soc/tegra/tegra20_das.c        | 8 ++++----
       sound/soc/tegra/tegra20_das.h        | 6 +++---
       sound/soc/ti/omap-abe-twl6040.c      | 2 +-
       sound/soc/ti/omap-mcbsp.c            | 3 +--
       sound/soc/ux500/mop500.c             | 6 +++---
       sound/soc/ux500/mop500_ab8500.h      | 2 +-
       17 files changed, 27 insertions(+), 28 deletions(-)
      
      --
      2.25.1
      9c0da293
  6. 31 Mar, 2021 7 commits
    • Bhaskar Chowdhury's avatar
    • Pierre-Louis Bossart's avatar
      ASoC: ux500: mop500: align function prototype · b4d09a01
      Pierre-Louis Bossart authored
      cppcheck warning:
      
      sound/soc/ux500/mop500_ab8500.c:360:60: style:inconclusive: Function
      'mop500_ab8500_machine_init' argument 1 names different: declaration
      'runtime' definition 'rtd'. [funcArgNamesDifferent]
      
      int mop500_ab8500_machine_init(struct snd_soc_pcm_runtime *rtd)
                                                                 ^
      sound/soc/ux500/mop500_ab8500.h:16:60: note: Function
      'mop500_ab8500_machine_init' argument 1 names different: declaration
      'runtime' definition 'rtd'.
      int mop500_ab8500_machine_init(struct snd_soc_pcm_runtime *runtime);
                                                                 ^
      sound/soc/ux500/mop500_ab8500.c:360:60: note: Function
      'mop500_ab8500_machine_init' argument 1 names different: declaration
      'runtime' definition 'rtd'.
      int mop500_ab8500_machine_init(struct snd_soc_pcm_runtime *rtd)
                                                                 ^
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Link: https://lore.kernel.org/r/20210326215927.936377-18-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      b4d09a01
    • Pierre-Louis Bossart's avatar
      ASoC: ux500: mop500: rename shadowing variable · 5b920abe
      Pierre-Louis Bossart authored
      cppcheck warning:
      
      sound/soc/ux500/mop500.c:143:23: style: Local variable 'mop500_card'
      shadows outer variable [shadowVariable]
      
       struct snd_soc_card *mop500_card = platform_get_drvdata(pdev);
                            ^
      sound/soc/ux500/mop500.c:54:28: note: Shadowed declaration
      static struct snd_soc_card mop500_card = {
                                 ^
      sound/soc/ux500/mop500.c:143:23: note: Shadow variable
       struct snd_soc_card *mop500_card = platform_get_drvdata(pdev);
                            ^
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Link: https://lore.kernel.org/r/20210326215927.936377-17-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      5b920abe
    • Pierre-Louis Bossart's avatar
      ASoC: ti: omap-mcsp: remove duplicate test · 3d37b27f
      Pierre-Louis Bossart authored
      cppcheck warning:
      
      sound/soc/ti/omap-mcbsp.c:379:11: style: The if condition is the same
      as the previous if condition [duplicateCondition]
      
       if (mcbsp->irq) {
                ^
      sound/soc/ti/omap-mcbsp.c:376:11: note: First condition
       if (mcbsp->irq)
                ^
      sound/soc/ti/omap-mcbsp.c:379:11: note: Second condition
       if (mcbsp->irq) {
                ^
      
      Keeping two separate tests was probably intentional for clarity, but
      since this generates warnings we might as well make cppcheck happy so
      that we have fewer warnings.
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
      Link: https://lore.kernel.org/r/20210326215927.936377-16-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      3d37b27f
    • Pierre-Louis Bossart's avatar
      ASoC: ti: omap-abe-twl6040: remove useless assignment · 248d4dc9
      Pierre-Louis Bossart authored
      cppcheck warning:
      
      sound/soc/ti/omap-abe-twl6040.c:173:10: style: Variable 'ret' is
      assigned a value that is never used. [unreadVariable]
       int ret = 0;
               ^
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
      Link: https://lore.kernel.org/r/20210326215927.936377-15-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      248d4dc9
    • Pierre-Louis Bossart's avatar
      ASoC: tegra: tegra20_das: align function prototypes · 53567ebc
      Pierre-Louis Bossart authored
      cppcheck warnings:
      
      sound/soc/tegra/tegra20_das.c:35:40: style:inconclusive: Function
      'tegra20_das_connect_dap_to_dac' argument 1 names different:
      declaration 'dap_id' definition 'dap'. [funcArgNamesDifferent]
      
      int tegra20_das_connect_dap_to_dac(int dap, int dac)
                                             ^
      sound/soc/tegra/tegra20_das.h:98:47: note: Function
      'tegra20_das_connect_dap_to_dac' argument 1 names different:
      declaration 'dap_id' definition 'dap'.
      extern int tegra20_das_connect_dap_to_dac(int dap_id, int dac_sel);
                                                    ^
      sound/soc/tegra/tegra20_das.c:35:40: note: Function
      'tegra20_das_connect_dap_to_dac' argument 1 names different:
      declaration 'dap_id' definition 'dap'.
      int tegra20_das_connect_dap_to_dac(int dap, int dac)
                                             ^
      sound/soc/tegra/tegra20_das.c:35:49: style:inconclusive: Function
      'tegra20_das_connect_dap_to_dac' argument 2 names different:
      declaration 'dac_sel' definition 'dac'. [funcArgNamesDifferent]
      int tegra20_das_connect_dap_to_dac(int dap, int dac)
                                                      ^
      sound/soc/tegra/tegra20_das.h:98:59: note: Function
      'tegra20_das_connect_dap_to_dac' argument 2 names different:
      declaration 'dac_sel' definition 'dac'.
      extern int tegra20_das_connect_dap_to_dac(int dap_id, int dac_sel);
                                                                ^
      sound/soc/tegra/tegra20_das.c:35:49: note: Function 'tegra20_das_connect_dap_to_dac' argument 2 names different: declaration 'dac_sel' definition 'dac'.
      int tegra20_das_connect_dap_to_dac(int dap, int dac)
                                                      ^
      sound/soc/tegra/tegra20_das.c:53:40: style:inconclusive: Function
      'tegra20_das_connect_dap_to_dap' argument 1 names different:
      declaration 'dap_id' definition 'dap'. [funcArgNamesDifferent]
      int tegra20_das_connect_dap_to_dap(int dap, int otherdap, int master,
                                             ^
      sound/soc/tegra/tegra20_das.h:108:47: note: Function
      'tegra20_das_connect_dap_to_dap' argument 1 names different:
      declaration 'dap_id' definition 'dap'.
      extern int tegra20_das_connect_dap_to_dap(int dap_id, int other_dap_sel,
                                                    ^
      sound/soc/tegra/tegra20_das.c:53:40: note: Function
      'tegra20_das_connect_dap_to_dap' argument 1 names different:
      declaration 'dap_id' definition 'dap'.
      int tegra20_das_connect_dap_to_dap(int dap, int otherdap, int master,
                                             ^
      sound/soc/tegra/tegra20_das.c:53:49: style:inconclusive: Function
      'tegra20_das_connect_dap_to_dap' argument 2 names different:
      declaration 'other_dap_sel' definition
      'otherdap'. [funcArgNamesDifferent]
      int tegra20_das_connect_dap_to_dap(int dap, int otherdap, int master,
                                                      ^
      sound/soc/tegra/tegra20_das.h:108:59: note: Function
      'tegra20_das_connect_dap_to_dap' argument 2 names different:
      declaration 'other_dap_sel' definition 'otherdap'.
      extern int tegra20_das_connect_dap_to_dap(int dap_id, int other_dap_sel,
                                                                ^
      sound/soc/tegra/tegra20_das.c:53:49: note: Function
      'tegra20_das_connect_dap_to_dap' argument 2 names different:
      declaration 'other_dap_sel' definition 'otherdap'.
      int tegra20_das_connect_dap_to_dap(int dap, int otherdap, int master,
                                                      ^
      sound/soc/tegra/tegra20_das.c:75:40: style:inconclusive: Function
      'tegra20_das_connect_dac_to_dap' argument 1 names different:
      declaration 'dac_id' definition 'dac'. [funcArgNamesDifferent]
      int tegra20_das_connect_dac_to_dap(int dac, int dap)
                                             ^
      sound/soc/tegra/tegra20_das.h:118:47: note: Function
      'tegra20_das_connect_dac_to_dap' argument 1 names different:
      declaration 'dac_id' definition 'dac'.
      extern int tegra20_das_connect_dac_to_dap(int dac_id, int dap_sel);
                                                    ^
      sound/soc/tegra/tegra20_das.c:75:40: note: Function
      'tegra20_das_connect_dac_to_dap' argument 1 names different:
      declaration 'dac_id' definition 'dac'.
      int tegra20_das_connect_dac_to_dap(int dac, int dap)
                                             ^
      sound/soc/tegra/tegra20_das.c:75:49: style:inconclusive: Function
      'tegra20_das_connect_dac_to_dap' argument 2 names different:
      declaration 'dap_sel' definition 'dap'. [funcArgNamesDifferent]
      int tegra20_das_connect_dac_to_dap(int dac, int dap)
                                                      ^
      sound/soc/tegra/tegra20_das.h:118:59: note: Function
      'tegra20_das_connect_dac_to_dap' argument 2 names different:
      declaration 'dap_sel' definition 'dap'.
      extern int tegra20_das_connect_dac_to_dap(int dac_id, int dap_sel);
                                                                ^
      sound/soc/tegra/tegra20_das.c:75:49: note: Function
      'tegra20_das_connect_dac_to_dap' argument 2 names different:
      declaration 'dap_sel' definition 'dap'.
      int tegra20_das_connect_dac_to_dap(int dac, int dap)
                                                      ^
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Acked-by: default avatarThierry Reding <treding@nvidia.com>
      Link: https://lore.kernel.org/r/20210326215927.936377-14-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      53567ebc
    • Pierre-Louis Bossart's avatar
      ASoC: tegra: tegra20_das: clarify expression · 1bc6d7a9
      Pierre-Louis Bossart authored
      cppcheck warning:
      
      sound/soc/tegra/tegra20_das.c:64:60: style: Boolean result is used in
      bitwise operation. Clarify expression with
      parentheses. [clarifyCondition]
       reg = otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P |
                                                                 ^
      sound/soc/tegra/tegra20_das.c:65:61: style: Boolean result is used in
      bitwise operation. Clarify expression with
      parentheses. [clarifyCondition]
      
        !!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P |
                                                                  ^
      sound/soc/tegra/tegra20_das.c:66:61: style: Boolean result is used in
      bitwise operation. Clarify expression with
      parentheses. [clarifyCondition]
        !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P |
                                                                  ^
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Acked-by: default avatarThierry Reding <treding@nvidia.com>
      Link: https://lore.kernel.org/r/20210326215927.936377-13-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      1bc6d7a9