- 21 Mar, 2019 5 commits
-
-
Colin Ian King authored
Currently an error return is being assigned to an unsigned size_t varianle and then checked if the result is less than zero which will always be false. Fix this by making ret ssize_t rather than a size_t. Fixes: 0322913c ("scsi: target: Add device product id and revision configfs attributes") Signed-off-by:
Colin Ian King <colin.king@canonical.com> Reviewed-by:
Mike Christie <mchristi@redhat.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Nathan Chancellor authored
When building with -Wsometimes-uninitialized, Clang warns: drivers/scsi/ufs/ufs-mediatek.c:112:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (on) ^~ drivers/scsi/ufs/ufs-mediatek.c:120:9: note: uninitialized use occurs here return ret; ^~~ drivers/scsi/ufs/ufs-mediatek.c:112:3: note: remove the 'if' if its condition is always true if (on) ^~~~~~~ drivers/scsi/ufs/ufs-mediatek.c:108:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (!on) ^~~ drivers/scsi/ufs/ufs-mediatek.c:120:9: note: uninitialized use occurs here return ret; ^~~ drivers/scsi/ufs/ufs-mediatek.c:108:3: note: remove the 'if' if its condition is always true if (!on) ^~~~~~~~ drivers/scsi/ufs/ufs-mediatek.c:96:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 2 warnings generated. Remove the default case and initialize ret to -EINVAL to properly fix this warning. Fixes: ddd90623 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips") Link: https://github.com/ClangBuiltLinux/linux/issues/426Signed-off-by:Nathan Chancellor <natechancellor@gmail.com> Reviewed-by:
Nick Desaulniers <ndesaulniers@google.com> Reviewed-by:
Stanley Chu <stanley.chu@mediatek.com> Signed-off-by:
-
YueHaibing authored
Fix sparse warnings: drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static? drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static? drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static? Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Reviewed-by:
Mukesh Ojha <mojha@codeaurora.org> Reviewed-by:
-
James Smart authored
Declaring interrupt clear routines as inline is bogus as they are used as an indirect pointer. Remove the inline references. Signed-off-by:
Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by:
James Smart <jsmart2021@gmail.com> Signed-off-by:
-
James Bottomley authored
You can't declare a function inline in a header if it doesn't have a body available to the compiler. So realistically you either don't declare it inline or you make it a static inline in the header. I think the latter applies in this case, so this should be the fix Signed-off-by:
James Bottomley <James.Bottomley@HansenPartnership.com> Acked-by:
James Smart <james.smart@broadcom.com> Signed-off-by:
-
- 19 Mar, 2019 35 commits
-
-
YueHaibing authored
Fix following sparse warning: drivers/scsi/mvumi.c:1797:48: warning: Using plain integer as NULL pointer drivers/scsi/mvumi.c:2143:50: warning: Using plain integer as NULL pointer drivers/scsi/mvumi.c:755:58: warning: Using plain integer as NULL pointer Signed-off-by:
-
YueHaibing authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/qedi/qedi_fw.c: In function 'qedi_tmf_resp_work': drivers/scsi/qedi/qedi_fw.c:158:28: warning: variable 'cls_sess' set but not used [-Wunused-but-set-variable] drivers/scsi/qedi/qedi_fw.c: In function 'qedi_tmf_work': drivers/scsi/qedi/qedi_fw.c:1370:28: warning: variable 'cls_sess' set but not used [-Wunused-but-set-variable] It's never used since introduction. Signed-off-by:
-
Matteo Croce authored
Fix spelling mistake: "lenght" -> "length" Signed-off-by:
Matteo Croce <mcroce@redhat.com> Signed-off-by:
-
Milan P. Gandhi authored
Fixed a typo for 'iiDMA' cmd in qla_bsg.c. Signed-off-by:
Milan P. Gandhi <mgandhi@redhat.com> Signed-off-by:
-
Milan P. Gandhi authored
Fixed a minor formatting issue with comment section in qla_bsg.c Signed-off-by:
-
YueHaibing authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/message/fusion/mptspi.c: In function 'mptspi_writeIOCPage4': drivers/message/fusion/mptspi.c:262:9: warning: variable 'frameOffset' set but not used [-Wunused-but-set-variable] drivers/message/fusion/mptspi.c:261:9: warning: variable 'req_idx' set but not used [-Wunused-but-set-variable] They're never used and can be removed. Signed-off-by:
-
Gustavo A. R. Silva authored
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/message/fusion/mptbase.c: In function mptbase_reply : drivers/message/fusion/mptbase.c:643:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (event != MPI_EVENT_EVENT_CHANGE) ^ drivers/message/fusion/mptbase.c:646:2: note: here case MPI_FUNCTION_CONFIG: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by:Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by:
-
Colin Ian King authored
There are several statements and code blocks there are incorrectly indented. Fix these. Signed-off-by:
-
Colin Ian King authored
There are a few statements that are not indented correctly, so fix these. Also add empty line between variable declaration and first statements in functions. Also remove whitespace between * and mvi_dev to clean up a cppcheck warning. Signed-off-by:
-
Colin Ian King authored
An if statement is indented correctly and an outb statement has a redundant empty comment and incorrect indentation. Fix these. Signed-off-by:
-
Colin Ian King authored
There are several lines where the indentation has an extra space, fix this by removing the spaces. Signed-off-by:
-
Colin Ian King authored
Clean up { brace to fix cppcheck warning. Remove some trailing spaces at end of a statement. Also clean up an indentation issue. Signed-off-by: -
Stanley Chu authored
This patch adds UFS support for MediaTek SoC chips. Signed-off-by:
Avri Altman <avri.altman@wdc.com> Signed-off-by:
-
Stanley Chu authored
Add UFS M-PHY driver on MediaTek chipsets. Signed-off-by:
Chunfeng Yun <chunfeng.yun@mediatek.com> Signed-off-by:
-
Stanley Chu authored
Add UFS and UFS PHY node document for Mediatek SoC chips. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Stanley Chu authored
Add UFS M-PHY node document for MediaTek SoC chips. Signed-off-by:
-
Stanley Chu authored
ufshcd_get_pwr_dev_param function and ufs_dev_params struct have been relocated to ufs core. Switch ufs-hisi to the common interface. Signed-off-by:
Bean Huo <beanhuo@micron.com> Signed-off-by:
-
Stanley Chu authored
ufshcd_get_pwr_dev_param function and ufs_dev_params struct have been relocated to ufs core. Switch ufs-qcom to the common interface. Signed-off-by:
-
Stanley Chu authored
ufshcd_get_pwr_dev_param defines an interface for power mode management currently used by both ufs-qcom and ufs-hisi. Move the interface to ufs core so every driver can take advantage of it. Signed-off-by:
-
Dongli Zhang authored
Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding. Signed-off-by:
Dongli Zhang <dongli.zhang@oracle.com> Signed-off-by:
-
Dongli Zhang authored
Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding. Signed-off-by:
-
Dongli Zhang authored
Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding. Signed-off-by:
-
Dongli Zhang authored
Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding. Signed-off-by:
-
Kangjie Lu authored
devm_reset_control_get could fail, so the fix checks its return value and passes the error code upstream in case it fails. Signed-off-by:
Kangjie Lu <kjlu@umn.edu> Acked-by:
-
Colin Ian King authored
There are several lines of code where the indentation is at an incorrect level; fix these. Signed-off-by:
Jack Wang <jinpu.wang@cloud.ionos.com> Signed-off-by:
-
Finn Thain authored
Cc: Michael Schmitz <schmitzmic@gmail.com> Signed-off-by:
Finn Thain <fthain@telegraphics.com.au> Signed-off-by:
-
Finn Thain authored
Adjust comments accordingly. Cc: Gustavo A. R. Silva <gustavo@embeddedor.com> Cc: Michael Schmitz <schmitzmic@gmail.com> Signed-off-by:
-
Bart Van Assche authored
All code from which the OSD include files were included has been removed. Hence also remove the include files themselves. See also commit 19fcae3d ("scsi: remove the SCSI OSD library"). Cc: Christoph Hellwig <hch@lst.de> Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by:
Bart Van Assche <bvanassche@acm.org> Signed-off-by:
-
Christoph Hellwig authored
This function is only used inside the SCSI midlayer. Signed-off-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
-
Hannes Reinecke authored
no_scsi2_lun_in_cdb declares a new bitfield, but we should rather move it to the existing bitfield for better alignment. Signed-off-by:
Hannes Reinecke <hare@suse.com> Reviewed-by:
-
James Smart authored
Update lpfc version to 12.2.0.0 Signed-off-by:
-
James Smart authored
Revise driver copyright message to show 2019. Update couple of files modified by 12.2.0.1 patch set. Signed-off-by:
-
James Smart authored
Update the 6072 log message string to print the whole 32 bits of the extended status. Signed-off-by:
-
James Smart authored
Driver had duplicated log message numbers making debug difficult. Make all messages unique. Signed-off-by:
-
James Smart authored
Change the SLI4 queue creation code to use NUMA node based memory allocation based on the cpu the queues will be related to. Signed-off-by:
-
