1. 24 Apr, 2023 38 commits
  2. 21 Apr, 2023 2 commits
    • Hamza Mahfooz's avatar
      drm/amd/display: fix flickering caused by S/G mode · 8f7f1b02
      Hamza Mahfooz authored
      Currently, on a handful of ASICs. We allow the framebuffer for a given
      plane to exist in either VRAM or GTT. However, if the plane's new
      framebuffer is in a different memory domain than it's previous
      framebuffer, flipping between them can cause the screen to flicker. So,
      to fix this, don't perform an immediate flip in the aforementioned case.
      
      Cc: stable@vger.kernel.org
      Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2354Reviewed-by: default avatarRoman Li <Roman.Li@amd.com>
      Fixes: 81d0bcf9 ("drm/amdgpu: make display pinning more flexible (v2)")
      Signed-off-by: default avatarHamza Mahfooz <hamza.mahfooz@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      8f7f1b02
    • Arnd Bergmann's avatar
      drm/amd/display: dumb_abm_lcd: avoid missing-prototype warnings · 0026c273
      Arnd Bergmann authored
      The dmub_abm_set_ambient_level() function has no caller and can
      just be removed, the other ones have a declaration in the
      header file and just need to see the prototype:
      
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:122:14: error: no previous prototype for function 'dmub_abm_get_current_backlight' [-Werror,-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:133:14: error: no previous prototype for function 'dmub_abm_get_target_backlight' [-Werror,-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:144:6: error: no previous prototype for function 'dmub_abm_set_level' [-Werror,-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:163:6: error: no previous prototype for function 'dmub_abm_set_ambient_level' [-Werror,-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:183:6: error: no previous prototype for function 'dmub_abm_init_config' [-Werror,-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:213:6: error: no previous prototype for function 'dmub_abm_set_pause' [-Werror,-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:231:6: error: no previous prototype for function 'dmub_abm_set_pipe' [-Werror,-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:251:6: error: no previous prototype for function 'dmub_abm_set_backlight_level' [-Werror,-Wmissing-prototypes]
      
      Fixes: b8fe5637 ("drm/amd/display: Refactor ABM feature")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarHamza Mahfooz <hamza.mahfooz@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      0026c273