- 14 Apr, 2021 14 commits
-
-
Dylan Griffith authored
Prior to this change a guest in a private group would end up in the `groups_user_can_read_epics` branch of logic in `#permissioned_related_groups`. This loops through each subgroup one at a time checking permissions. Instead of unwinding that logic for now we are just going to add a logical short circuit for a common specific case. The `#permissioned_related_groups` only needs to check if the user has the ability to view all epics in all subgroups in a group. Previously we were using the `read_confidential_epic` permission to confirm that the user could access all epics in the subgroups as well. But this is not necessary because this class will already filter confidential epics later in `with_confidentiality_access_check` so really we just need to answer the question "Can a user view all epics in this group and all of it's subgroups". This seems deceptively like we could just check the `read_epic` permission but there is a weird edge case for public groups. A user can view epics in a public group even if they aren't a member but that public group can contain private subgroups and they won't be able to view those epics. So we can conclude that if a group is `private?` as well as the user having the ability to `read_epic` in that group then they will also be able to `read_epic` in all child groups as well. This MR also introduces a new explicit test for `guest` permissions with confidential issues. The reason being that we don't appear to have any such tests about guest users already and it may give us more confidence that confidentiality filtering is working correctly prior to implementing this optimization.
-
Evan Read authored
Update changelog to match final change See merge request gitlab-org/gitlab!59334
-
Marcel Amirault authored
-
Evan Read authored
Moved reference content to reference topic See merge request gitlab-org/gitlab!59184
-
Suzanne Selhorn authored
-
Ezekiel Kigbo authored
Add URL param for linking to a specific stage in group-level VSA See merge request gitlab-org/gitlab!57621
-
Martin Wortschack authored
-
Michael Kozono authored
Fix Rails/SaveBang offenses in spec/factories_spec.rb See merge request gitlab-org/gitlab!58102
-
Abdul Wadood authored
-
Evan Read authored
Compress documentation images See merge request gitlab-org/gitlab!59280
-
Marcel Amirault authored
Recommend to fill gaps in enum values See merge request gitlab-org/gitlab!58759
-
Fabio Pitino authored
-
Evan Read authored
Update codequality documentation See merge request gitlab-org/gitlab!59166
-
Maxime Orefice authored
-
- 13 Apr, 2021 26 commits
-
-
Enrique Alcántara authored
Reduce pipeline tooltip delay to 0 See merge request gitlab-org/gitlab!59155
-
Ezekiel Kigbo authored
Change language on welcome page See merge request gitlab-org/gitlab!59183
-
Ezekiel Kigbo authored
Externalize strings in projects/index.html.haml See merge request gitlab-org/gitlab!58160
-
Marvin Karegyeya authored
-
Stan Hu authored
Rename find to execute in EnvironmentsFinder See merge request gitlab-org/gitlab!59254
-
Mike Jang authored
Include user permission export screenshot See merge request gitlab-org/gitlab!59301
-
Jose Ivan Vargas authored
Merge branch '325778-moving-issue-to-board-list-of-different-type-should-not-remove-it-from-previous-list' into 'master' Clone issue card on move when necessary [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!58644
-
Scott Hampton authored
Fix FOSS specs broken by !58833 [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!59306
-
Miranda Fluharty authored
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/58833 was merged, but broke some FOSS specs because the code was moved to `ee/` while the corresponding specs were not moved.
-
Stan Hu authored
Remove issue_perform_after_creation_tasks_async feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!59042
-
Mayra Cabrera authored
Removes compliance framework administration abilities from subgroups See merge request gitlab-org/gitlab!58873
-
Nick Thomas authored
Add OncallScheduleEntity to users in Admin helper See merge request gitlab-org/gitlab!59093
-
Scott Hampton authored
Align UI to use "Runtime" for CI/CD job page See merge request gitlab-org/gitlab!58838
-
Marcel Amirault authored
Updates the text on the jobs page so that we use clear language to talk about the time it takes a job to run.
-
Mayra Cabrera authored
Create a migration to insert trail plans See merge request gitlab-org/gitlab!57814
-
Shreyas Agarwal authored
-
Olena Horal-Koretska authored
Refactor to using Vuex modules for project/group members views See merge request gitlab-org/gitlab!58828
-
Mayra Cabrera authored
Add cop Style/RegexpLiteralMixedPreserve [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!58898
-
Peter Leitzen authored
-
Jose Ivan Vargas authored
Fix dropdown toggle bug See merge request gitlab-org/gitlab!59309
-
Dmytro Zaporozhets (DZ) authored
Fix Rails/SaveBang Rubocop offenses for email handlers See merge request gitlab-org/gitlab!58095
-
Huzaifa Iftikhar authored
-
Nicolò Maria Mezzopera authored
Externalize strings in shared/_sign_in_link.html.haml See merge request gitlab-org/gitlab!58283
-
Marvin Karegyeya authored
-
Mike Jang authored
Resolve "Update screenshots for menu and sidebar UI updates - Manage" See merge request gitlab-org/gitlab!58511
-
Mike Jang authored
-