- 21 Mar, 2019 2 commits
-
-
Ivan Safonov authored
The sequence skb_put(skb); skb_pull(skb); leads to the same result as skb_reserve(skb); but second is a little shorter and clearer. Signed-off-by:Ivan Safonov <insafonov@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sanjana Sanikommu authored
Remove braces around single statement block. Issue found by checkpatch.pl WARNING: braces {} are not necessary for a single statement block Signed-off-by:Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by:
-
- 20 Mar, 2019 27 commits
-
-
Michael Straube authored
All defined WFD* in wifi.h are unused in the driver code, so remove them. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Wentao Cai authored
Correct SPDX-License-Identifier comment characters to silence checkpatch.pl warning: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 Signed-off-by:
Wentao Cai <etsai042@gmail.com> Signed-off-by:
-
Ian Abbott authored
The `insn_read` handler for the EEPROM subdevice on M-series boards (`ni_m_series_eeprom_insn_read()`) currently ignores `insn->n` (the number of samples to read) and assumes a single sample is to be read into `data[0]`. Fortunately, the Comedi core ensures that `data[]` has a length of at least 16 so there is no problem with array bounds. The usual Comedi convention for `insn_read` handlers is to read the same channel `insn->n` times into successive elements of `data[]` so let's do that. (Each channel corresponds to a single EEPROM address.) In this case, the data value comes from a local copy of the EEPROM contents. Also, follow the usual Comedi convention and return `insn->n` from the handler to indicate success (although any non-negative value will do). Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
The `insn_read` handler for the EEPROM subdevice on E-series boards (`ni_eeprom_insn_read()`) currently ignores `insn->n` (the number of samples to read) and assumes a single sample is to be read into `data[0]`. Fortunately, the Comedi core ensures that `data[]` has a length of at least 16 so there is no problem with array bounds. The usual Comedi convention for `insn_read` handlers is to read the same channel `insn->n` times into successive elements of `data[]` so let's do that. (Each channel number corresponds to a single EEPROM address.) Since we do not expect the EEPROM data at a particular address to change between readings, let's just read it once and copy the value `insn->n` times. Also, follow the usual Comedi convention and return `insn->n` from the handler to indicate success (although any non-negative value will do). Signed-off-by:
-
Ian Abbott authored
The `insn_read` handler for the calibration subdevice (`ni_calib_insn_read()`) currently ignores `insn->n` (the number of samples to read) and assumes a single sample is to be read into `data[0]`. Fortunately, the Comedi core ensures that `data[]` has a length of at least 16, so there is no problem with array bounds. The usual Comedi convention for `insn_read` handlers is to read the same channel `insn->n` times into successive elements of `data[]`, so let's do that. Also, follow the usual Comedi convention and return `insn->n` from the handler to indicate success (although any non-negative value will do). Signed-off-by:
-
Ian Abbott authored
The `insn_write` handler for the calibration subdevice (`ni_calib_insn_write()`) currently ignores `insn->n` (the number of samples to write) and assumes a single sample is to be written, but `insn->n` could be 0, meaning no samples should be written, in which case `data[0]` is invalid. Change `ni_calib_insn_write()` to only write to the calibration device if `insn->n > 0`. There isn't much point writing all the values when `insn->n > 1`, so just write the last one (`data[insn->n - 1]`). Also follow the usual Comedi convention and return `insn->n` from the handler to indicate success (although any non-negative return value will do as far as the Comedi core is concerned). Signed-off-by:
-
George Hilliard authored
A failure while processing the start command could cause dma_unmap_sg() to be called without first calling dma_map_sg(). Since calling dma_unmap_sg() is only needed when data != NULL, move the unmap call into the corresponding if {} block. Signed-off-by:George Hilliard <thirtythreeforty@gmail.com> Signed-off-by:
-
George Hilliard authored
Obvious typo. It is specified as BURST in the datasheet. Signed-off-by:
-
George Hilliard authored
There is no need to delay notifying the mmc layer. Schedule the delayed work to run immediately. Signed-off-by:
-
George Hilliard authored
This is set once during initialization and never changed. Don't bother setting it again in the interrupt handler. Signed-off-by:
-
George Hilliard authored
When waiting on completions, use the _io variant so the caller is charged as using I/O. This should have no effect on the module's functionality, only improve CPU accounting. Signed-off-by:
-
George Hilliard authored
The driver previously grabbed the SD pins for itself, ignoring the pin controller. Remove this, and allow the pinctrl subsystem to set up the pins using the device tree mappings. This allows this driver to work on related devices that have a different pin controller mapping, such as the MT7688. The hardcoded bit index was incorrect on that device. The driver now needs a pin controller reference in its device tree node: sdhci: /* ... */ { compatible = "ralink,mt7620-sdhci"; pinctrl-names = "default"; pinctrl-0 = <&sdhci_pins>; // ... }; This change could break SD controller functionality on existing devices whose device trees do not specify a pin controller and state for the SD node. Signed-off-by: -
George Hilliard authored
These comments don't contain useful code or alternate implementation ideas. Remove them. Signed-off-by:
-
George Hilliard authored
The compiler complains: drivers/staging/mt7621-mmc/dbg.c: In function ‘msdc_debug_proc_write’: drivers/staging/mt7621-mmc/dbg.c:237:12: warning: unused variable ‘size’ [-Wunused-variable] int mode, size; ^~~~ drivers/staging/mt7621-mmc/dbg.c:237:6: warning: unused variable ‘mode’ [-Wunused-variable] int mode, size; ^~~~ Remove these declarations. Signed-off-by: -
Nishka Dasgupta authored
Remove return variable and return return value directly. Issue found by Coccinelle using ret.cocci. Signed-off-by:
Nishka Dasgupta <nishka.dasgupta@yahoo.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Wentao Cai authored
Replace '--help--' in Kconfig and indent the subsequent text to silence checkpatch.pl warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by:
-
Wentao Cai authored
Replace '--help--' in Kconfig and indent the subsequent text to silence checkpatch.pl warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by:
-
Wentao Cai authored
Replace '--help--' in Kconfig and indent the subsequent text to silence checkpatch.pl warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by:
-
Vatsala Narang authored
Edit CamelCase function name Issue found by checkpatch.pl Signed-off-by:
Vatsala Narang <vatsalanarang@gmail.com> Signed-off-by:
-
Sanjana Sanikommu authored
Fix the spacce around else. Issue found by checkpatch.pl ERROR: spaces required before that open brace '{' ERROR: spaces required before that close brace '}' Signed-off-by: -
Sanjana Sanikommu authored
Replace NULL comparisons in the file. Issue found by checkpatch.pl Signed-off-by:
-
Sanjana Sanikommu authored
Remove unnecessary blank lines. Issue found by checkpatch.pl Signed-off-by:
-
Sanjana Sanikommu authored
Add spaces around the operators. Issue found by checkpatch.pl CHECK: spaces preferred around that '+' CHECK: spaces preferred around that '*' Signed-off-by:
-
Sanjana Sanikommu authored
Ajdust alignment to match open paranthesis. Issue found by checkpatch.pl CHECK: Alignment should match open paranthesis. Signed-off-by:
-
Nishka Dasgupta authored
Remove return variable and return the return value directly. Issue suggested by ret.cocci. Signed-off-by:
-
Nishka Dasgupta authored
Remove parentheses around variable. Signed-off-by:
-
Julian Merida authored
Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by:
Julian Merida <julianmr97@gmail.com> Reviewed-by:
Gao Xiang <gaoxiang25@huawei.com> Signed-off-by:
-
- 19 Mar, 2019 10 commits
-
-
Bhagyashri Dighole authored
Convert a ternary statement into a if statement which is detected while resolving "WARNING: line over 80 characters". Use BIT() macro instead manually left shifting. Signed-off-by:
Bhagyashri Dighole <digholebhagyashri@gmail.com> Signed-off-by:
-
Emanuel Bennici authored
Improve Code readability by adding Tabs and Spaces after #define Signed-off-by:
Emanuel Bennici <benniciemanuel78@gmail.com> Signed-off-by:
-
Sanjana Sanikommu authored
Fix the check as per Linux kernel style for use of spaces. Issue found by checkpatch.pl CHECK:spaces preffered around that '<<' Signed-off-by:
-
Madhumitha Prabakaran authored
Include missing NULL check for kmalloc in function rtw_init_evt_priv. Signed-off-by:
Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by:
-
Madhumitha Prabakaran authored
Replace NULL comparison with ! in function rtw_init_cmd_priv, to maintain Linux kernel coding style. Signed-off-by:
-
Madhumitha Prabakaran authored
Change values for standard error codes in functions rtw_init_cmd_priv and rtw_init_evt_priv, as _SUCCESS should be 0 and _FAIL should be -ENOMEM. Also, change the values in corresponding call sites of the functions. Signed-off-by:
-
Madhumitha Prabakaran authored
Remove unnecessary local variable 'res' in function and replace the value directly in the return of the function. Signed-off-by:
-
Sergey Senozhatsky authored
cpu_to_le16() is capable enough to detect __builtin_constant_p() and to use an appropriate compile time ___constant_swahbXX() function. So we can use cpu_to_le16() instead of __constant_cpu_to_le16(). Signed-off-by:
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Signed-off-by:
-
Colin Ian King authored
The range check on auth_type is redundant as there is a prior check on the auth_type values and the only way the block is entered is if auth_type is one of TYPE_PMK1, TYPE_GMK1 and TYPE_GMK2. Hence the auth_type check can be removed. Detected by static analysis with cppcheck. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Acked-by:
Jeremy Sowden <jeremy@azazel.net> Signed-off-by:
-
Michael Straube authored
All defined P2P* in wifi.h are unused in the driver code, so remove them. Signed-off-by:
-
- 18 Mar, 2019 1 commit
-
-
Sanjana Sanikommu authored
Adjust indentation for the condition statement. Issue found by checkpatch.pl WARNING: suspect code indent for condition statements(8,24) Signed-off-by:
-
